Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Nov 2019 12:23:37 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        "Andrew F. Davis" <afd@ti.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add HP output driver pop reduction
 controls
Message-ID: <20191128122337.GC4210@sirena.org.uk>
References: <20191128093955.29567-1-nikita.yoush@cogentembedded.com>
 <20191128121128.GA4210@sirena.org.uk>
 <ecfa48d3-284b-5234-02b9-adc0c6892b6f@cogentembedded.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="w7PDEPdKQumQfZlR"
Content-Disposition: inline
In-Reply-To: <ecfa48d3-284b-5234-02b9-adc0c6892b6f@cogentembedded.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--w7PDEPdKQumQfZlR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 28, 2019 at 03:19:38PM +0300, Nikita Yushchenko wrote:

> > I'm not seeing any integration with DAPM here, I'd expect to see that so
> > we don't cut off the start of audio especially with the longer times
> > available (which I'm frankly not sure are seriously usable).

> I believe driver already has that integration, there is
> aic31xx_dapm_power_event() that is called on DAPM events, and polls state in
> register bits waiting for operation to complete.

> Btw, the default setting for register fields in question is "304ms" /
> "3.9ms" thus some delay is already there. This patch just makes it
> explicitly controllable by those who wait it.

Can you confirm that this does take effect (should be easy with the
longer delays) and put a comment in indicating that please in case
someone is cut'n'pasting?

--w7PDEPdKQumQfZlR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3fvEkACgkQJNaLcl1U
h9DlHgf/SsdPanPk6tcxh3RNkH+E1k2QbOZyqz3ogi46FtVFl/EySbEnLUh0vvfV
yr8xLzJaENOWRlmBPP8NeB65/Zq4gfCp4vNX8fmm+0i7Uphn07vD13M2LMFMyWWn
H+NMnpM/8u+UsPY/dW7lk4cSt4sWhoV9D1FfwZt3fyabVGYF11+m440TFjUxqd1a
8NZTM7n2vOLlH7CXYXFyJqsJ0TGmmxdB1xWoT7S4XCHvsCBdyDYMyLFooZS/ClLW
MD24Rq9hH90CWAqcKbicRtGYs2fohXUZfzGEFDnSS2VYB7vlF4QPw7w8s9UGNvu1
bvEXSMuQhdTSHtz/BvV3d59WPNkRJw==
=+Mvy
-----END PGP SIGNATURE-----

--w7PDEPdKQumQfZlR--