Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191128105508.3916-1-kbingham@kernel.org> <20191128105508.3916-4-kbingham@kernel.org>
In-Reply-To: <20191128105508.3916-4-kbingham@kernel.org>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Thu, 28 Nov 2019 14:43:26 +0100
Message-ID: <CANiq72mnzeQ2SvKbFx+VMFhQnMYNeGQOXpKXy9Vz7kRZyXVbHg@mail.gmail.com>
Subject: Re: [PATCH 3/3] drivers: auxdisplay: Add JHD1313 I2C interface driver
To:     kbingham@kernel.org
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Simon Goda <simon.goda@doulos.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Kieran,

On Thu, Nov 28, 2019 at 11:55 AM <kbingham@kernel.org> wrote:
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8f075b866aaf..640f099ff7fb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8837,6 +8837,10 @@ S:       Maintained
>  F:     Documentation/admin-guide/jfs.rst
>  F:     fs/jfs/
>
> +JHD1313 LCD Dispaly driver

Typo (and it should be all uppercase; and perhaps "Display" is not
needed given LCD is there; but see also comments on the title below).

Also missing the "S:" entry.

> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index b8313a04422d..cfc61c1abdee 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -27,6 +27,18 @@ config HD44780
>           kernel and started at boot.
>           If you don't understand what all this is about, say N.
>
> +config JHD1313
> +       tristate "JHD1313 Character LCD support"
> +       depends on I2C
> +       select CHARLCD
> +       ---help---
> +         Enable support for Character LCDs using a JHD1313 controller on I2C.
> +         The LCD is accessible through the /dev/lcd char device (10, 156).
> +         This code can either be compiled as a module, or linked into the
> +         kernel and started at boot.
> +         This supports the LCD panel on the Grove 16x2 LCD series.
> +         If you don't understand what all this is about, say N.

Would it be useful/worth for users to put "Grove series" and/or "I2C"
in the tristate title? (i.e. like the help section explains and also
like the MODULE_DESCRIPTION says).

> diff --git a/drivers/auxdisplay/jhd1313.c b/drivers/auxdisplay/jhd1313.c
> new file mode 100644
> index 000000000000..abf270e128ac
> --- /dev/null
> +++ b/drivers/auxdisplay/jhd1313.c
> @@ -0,0 +1,111 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +

Unconventional (AFAIK) empty line.

Thanks for the driver!

Cheers,
Miguel