Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Nov 2019 13:16:44 +0100
From:   Oliver Graute <oliver.graute@gmail.com>
To:     Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc:     Andrew Lunn <andrew@lunn.ch>, Peng Fan <peng.fan@nxp.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Anson Huang <anson.huang@nxp.com>,
        =?iso-8859-1?Q?Andr=E9?= Draszik <git@andred.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Russell King <rmk+kernel@armlinux.org.uk>,
        dl-linux-imx <linux-imx@nxp.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_AT803X_PHY from m to y
Message-ID: <20191128121644.GD2460@optiplex>
References: <20191127124638.GC5108@optiplex>
 <1ed54a69-c29f-6008-02ae-11d16f68b265@free.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ed54a69-c29f-6008-02ae-11d16f68b265@free.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 28/11/19, Marc Gonzalez wrote:
> On 27/11/2019 13:46, Oliver Graute wrote:
> 
> > On 27/11/19, Marc Gonzalez wrote:
> >
> >> On 26/11/2019 15:54, Oliver Graute wrote:
> >>
> >>> this patch broke my imx8qm nfs setup. With the generic phy driver my
> >>> board is booting fine. But with the AT803X_PHY=y enabled  I'm running
> >>> into the following phy issue. So on my side it looks inverse as on
> >>> yours. What is the best proposal to fix this?
> >>>
> >>> [    5.550442] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> >>> [    5.573206] Sending DHCP requests ...... timed out!
> >>> [   95.339702] IP-Config: Retrying forever (NFS root)...
> >>> [   95.348873] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL)
> >>> [   99.438443] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
> >>> [   99.461206] Sending DHCP requests ...... timed out!
> >>
> >> Which DTS are you using?
> > 
> > I'am using this DTS which I'am currently working on:
> > 
> > https://lists.infradead.org/pipermail/linux-arm-kernel/2019-October/689501.html
> >>
> >> I bet one dollar that 6d4cd041f0af triggered a latent bug in the DTS.
> > 
> > So what should I fix in my device tree?
> 
> In the board DTS I used to work on, I had this:
> 
> &eth0 {
> 	phy-connection-type = "rgmii-id";
> 	phy-handle = <&eth0_phy>;
> 	#address-cells = <1>;
> 	#size-cells = <0>;
> 
> 	/* Atheros AR8035 */
> 	eth0_phy: ethernet-phy@4 {
> 		compatible = "ethernet-phy-id004d.d072",
> 			     "ethernet-phy-ieee802.3-c22";
> 		interrupts = <37 IRQ_TYPE_EDGE_RISING>;
> 		reg = <4>;
> 	};
> };
> 
> In your DTS, you #include "imx8qm.dtsi"
> I found no such file:
> $ git ls-files | grep imx8qm

yes this file is not yet added to Shawn Guos next tree.
Latest patch can be found here:

 https://patchwork.kernel.org/patch/11248331/

> 
> In your patch:
> https://patchwork.kernel.org/patch/11211567/
> 
> +&fec1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_fec1>;
> +	phy-mode = "rgmii-txid";
> +	phy-handle = <&ethphy0>;
> +	fsl,magic-packet;
> +	fsl,rgmii_rxc_dly;
> +	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethphy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-ieee802.3-c22";
> +			reg = <4>;
> +			at803x,eee-disabled;
> +			at803x,vddio-1p8v;
> +		};
> +	};
> +};
> 
> Try all possible 'phy-mode' (rgmii, rgmii-id, rgmii-rxid, rgmii-txid)
> Investigate 'fsl,rgmii_rxc_dly' (it's not a standard Linux DT prop)
> Documentation/devicetree/bindings/net/ethernet-controller.yaml

thx for this hint.

Best regards,

Oliver