Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191125145320.GA21484@haolee.github.io> <c8e88092-ddbe-2934-aa61-5db6cbad0c11@arm.com>
In-Reply-To: <c8e88092-ddbe-2934-aa61-5db6cbad0c11@arm.com>
From:   Hao Lee <haolee.swjtu@gmail.com>
Date:   Thu, 28 Nov 2019 23:12:10 +0800
Message-ID: <CA+PpKPnA2n+inG7nP0V66Q_-4LNn_nYZa2dqvHTz1fKT2J7e+Q@mail.gmail.com>
Subject: Re: [PATCH] mm: use the existing variable instead of a duplicate statement
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     akpm@linux-foundation.org, Mel Gorman <mgorman@suse.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 28 Nov 2019 at 18:02, Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index ee4eecc7e1c2..de4b2d1e66be 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -363,22 +363,21 @@ unsigned long lruvec_lru_size(struct lruvec *lruvec, enum lru_list lru, int zone
> >       for (zid = zone_idx + 1; zid < MAX_NR_ZONES; zid++) {
> >               struct zone *zone = &lruvec_pgdat(lruvec)->node_zones[zid];
> >               unsigned long size;
> >
> >               if (!managed_zone(zone))
> >                       continue;
> >
> >               if (!mem_cgroup_disabled())
> >                       size = mem_cgroup_get_zone_lru_size(lruvec, lru, zid);
> >               else
> > -                     size = zone_page_state(&lruvec_pgdat(lruvec)->node_zones[zid],
> > -                                    NR_ZONE_LRU_BASE + lru);
> > +                     size = zone_page_state(zone, NR_ZONE_LRU_BASE + lru);
>
> Is not this already merged with following commit on next-20191126 ?
>
> 54eacdb0dd8f9a ("mm: vmscan: simplify lruvec_lru_size()")

Yes...That's really a coincidence... I use torvalds' tree to develop
but never think this function has been refactored on next tree just a
few days ago. Thank you.

Regards,
Hao Lee