Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <9fcf53ca7372ef421e3b0836e4a7ec8239b380ec.camel@perches.com>
In-Reply-To: <9fcf53ca7372ef421e3b0836e4a7ec8239b380ec.camel@perches.com>
From:   =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <f4bug@amsat.org>
Date:   Thu, 28 Nov 2019 21:11:09 +0100
Message-ID: <CAAdtpL5bg=B6iKWT-QjnWzpW7hxU25PN_xtYq_1jX=2jbGfr=w@mail.gmail.com>
Subject: Re: [PATCH] MIPS: Kconfig: Use correct form for 'depends on'
To:     Joe Perches <joe@perches.com>
Cc:     Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paulburton@kernel.org>,
        James Hogan <jhogan@kernel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 28, 2019 at 6:23 PM Joe Perches <joe@perches.com> wrote:
>
> Remove the CONFIG_ prefix from "depends on" as it makes the selection
> not possible.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/platform/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index f4d0a86..5e77b0 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -18,7 +18,7 @@ if MIPS_PLATFORM_DEVICES
>
>  config CPU_HWMON
>         tristate "Loongson-3 CPU HWMon Driver"
> -       depends on CONFIG_MACH_LOONGSON64
> +       depends on MACH_LOONGSON64
>         select HWMON
>         default y
>         help
>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>