Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp7851734ybc; Fri, 29 Nov 2019 02:05:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzVRGmxWXLkz1CSa1q1onBUnzlsWha4SIRDz7HsglDnXGj+X4/YZ0kI2H7Y/pekkPsfFYrD X-Received: by 2002:a05:6402:2036:: with SMTP id ay22mr38589200edb.303.1575021924605; Fri, 29 Nov 2019 02:05:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575021924; cv=none; d=google.com; s=arc-20160816; b=AJQ37CcyZ5uArV+rcS0kVXEiVfNbk38u1HbDkVUM/R7qOnL/vYLUf/W2S/OjYXcpB0 kAapeZeOVga/cppY07+Q1qSbnj+c3wXwmO6uLkTOm9QIrWVu4U39dJ9JmNV5jszB9FcU yok4GmzCjrvHbmCBSc6eUOosmBAQiu5WPuSsvnsfjvvdSfs/4nMBVkD9H5vWBqhnbpQm AF+DnAfjj0xPwMs7352aynpE4bdLAOs+kbRR7QQjQ5WTgTQZoBqYeDtvCimQt+cIu72J z9gSK/jyASOCVANvC5aCp9fH5KDfpP4dvSgX4C6zxgjXH5DkY3gQUMMfun2v0pCYXNfu s6sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:references:cc:to:from:subject; bh=4N0t83ocMmrvl9/Thjyor4sfuejYaqQj7ANoSIaSlEs=; b=iADr16mDdqACCIyGC8JiQ992BdEPZpQ4bHx2Iv8ACZQXRc1nFxhTBzPU4KA3kqQBdO elrzp68JVHBdvcOng6MfnOM6QnOr3E+9SX+480Rcz6hAqyyGXcOzFi13CEI3J7WNqUvb 4f4hY0kfPf5ZtznBJSxjC8aMLXIIsOYBuL+7iNnu9rQL3wFQXwDBV+jDeXlvsR0fBZMP vsuWe6IayUglTmfxXAb9V9UeT9TKGKDiyfpiywm/rUOxwt2PD2FhDbLF64xrfPaYkpxx cGJS/SBgzZ0QG7FQZOyo7a8VsT4BW8c3CFz6ddwVm7RoLv4mGotMWCr1v7llXyg9+0AM kfvg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l15si7706707ejz.171.2019.11.29.02.04.59; Fri, 29 Nov 2019 02:05:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfK2KDA (ORCPT + 99 others); Fri, 29 Nov 2019 05:03:00 -0500 Received: from mga09.intel.com ([134.134.136.24]:43356 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbfK2KC7 (ORCPT ); Fri, 29 Nov 2019 05:02:59 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2019 02:02:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,257,1571727600"; d="scan'208";a="217758797" Received: from linux.intel.com ([10.54.29.200]) by fmsmga001.fm.intel.com with ESMTP; 29 Nov 2019 02:02:58 -0800 Received: from [10.125.252.110] (abudanko-mobl.ccr.corp.intel.com [10.125.252.110]) by linux.intel.com (Postfix) with ESMTP id D614F5802E4; Fri, 29 Nov 2019 02:02:55 -0800 (PST) Subject: [PATCH v3 1/3] tools bitmap: implement bitmap_equal() operation at bitmap API From: Alexey Budankov To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Ingo Molnar , Andi Kleen , linux-kernel References: <908dbe98-7d8d-0ec1-d4ae-242f3e104979@linux.intel.com> Organization: Intel Corp. Message-ID: Date: Fri, 29 Nov 2019 13:02:54 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <908dbe98-7d8d-0ec1-d4ae-242f3e104979@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Extend tools bitmap API with bitmap_equal() implementation. The implementation has been derived from the kernel. Extend tools bitmap API with bitmap_free() implementation for symmetry with bitmap_alloc() function. Signed-off-by: Alexey Budankov --- tools/include/linux/bitmap.h | 30 ++++++++++++++++++++++++++++++ tools/lib/bitmap.c | 15 +++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/tools/include/linux/bitmap.h b/tools/include/linux/bitmap.h index 05dca5c203f3..477a1cae513f 100644 --- a/tools/include/linux/bitmap.h +++ b/tools/include/linux/bitmap.h @@ -15,6 +15,8 @@ void __bitmap_or(unsigned long *dst, const unsigned long *bitmap1, const unsigned long *bitmap2, int bits); int __bitmap_and(unsigned long *dst, const unsigned long *bitmap1, const unsigned long *bitmap2, unsigned int bits); +int __bitmap_equal(const unsigned long *bitmap1, + const unsigned long *bitmap2, unsigned int bits); void bitmap_clear(unsigned long *map, unsigned int start, int len); #define BITMAP_FIRST_WORD_MASK(start) (~0UL << ((start) & (BITS_PER_LONG - 1))) @@ -123,6 +125,15 @@ static inline unsigned long *bitmap_alloc(int nbits) return calloc(1, BITS_TO_LONGS(nbits) * sizeof(unsigned long)); } +/* + * bitmap_free - Free bitmap + * @bitmap: pointer to bitmap + */ +static inline void bitmap_free(unsigned long *bitmap) +{ + free(bitmap); +} + /* * bitmap_scnprintf - print bitmap list into buffer * @bitmap: bitmap @@ -148,4 +159,23 @@ static inline int bitmap_and(unsigned long *dst, const unsigned long *src1, return __bitmap_and(dst, src1, src2, nbits); } +#ifdef __LITTLE_ENDIAN +#define BITMAP_MEM_ALIGNMENT 8 +#else +#define BITMAP_MEM_ALIGNMENT (8 * sizeof(unsigned long)) +#endif +#define BITMAP_MEM_MASK (BITMAP_MEM_ALIGNMENT - 1) +#define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) + +static inline int bitmap_equal(const unsigned long *src1, + const unsigned long *src2, unsigned int nbits) +{ + if (small_const_nbits(nbits)) + return !((*src1 ^ *src2) & BITMAP_LAST_WORD_MASK(nbits)); + if (__builtin_constant_p(nbits & BITMAP_MEM_MASK) && + IS_ALIGNED(nbits, BITMAP_MEM_ALIGNMENT)) + return !memcmp(src1, src2, nbits / 8); + return __bitmap_equal(src1, src2, nbits); +} + #endif /* _PERF_BITOPS_H */ diff --git a/tools/lib/bitmap.c b/tools/lib/bitmap.c index 38494782be06..5043747ef6c5 100644 --- a/tools/lib/bitmap.c +++ b/tools/lib/bitmap.c @@ -71,3 +71,18 @@ int __bitmap_and(unsigned long *dst, const unsigned long *bitmap1, BITMAP_LAST_WORD_MASK(bits)); return result != 0; } + +int __bitmap_equal(const unsigned long *bitmap1, + const unsigned long *bitmap2, unsigned int bits) +{ + unsigned int k, lim = bits/BITS_PER_LONG; + for (k = 0; k < lim; ++k) + if (bitmap1[k] != bitmap2[k]) + return 0; + + if (bits % BITS_PER_LONG) + if ((bitmap1[k] ^ bitmap2[k]) & BITMAP_LAST_WORD_MASK(bits)) + return 0; + + return 1; +} -- 2.20.1