Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp7964440ybc; Fri, 29 Nov 2019 03:48:34 -0800 (PST) X-Google-Smtp-Source: APXvYqx8VDJhMfVpfXYKV12hjr19+tlZF2CCYUV6T2zlnswbSxRnrp+ZYbtJOqlXvrKvjlDcwDDZ X-Received: by 2002:a17:906:4a0c:: with SMTP id w12mr60581907eju.306.1575028114590; Fri, 29 Nov 2019 03:48:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575028114; cv=none; d=google.com; s=arc-20160816; b=AFhYlpXJD3LxDZ7fE2rKamvXGcAKVQqeBYHFx2l7qWmdRNADyzeEsJCjQNrqrTqYCI 5dy7S8MG+RTYcmlIYsUkil0ScwbQI5qcgSGrWOxUCtR0HvwrDJTmj91VoTIXwigxY/EB N73tI/8fFP2itYJpdNAvnV1AhMWyWBQ068fzVoSuDYokKNWfG5pTk6vBdZ88LAXOOgTi u2Y8dreFG4cfpkYqOFtiYXAYKfc4I+sQA6F2x5EjDby+Mc0Wc/1pWH6hUCRasuoEY1Aq D3GXLp+WnVhUGKTK4ok4fRQQJF4Tn3160RA+E/kcw6aKLFmHEYjknmDQMxyX/uFh7LGq 8Hmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=cA0I5C6Q3B3d8zS+DiHH/GqBQJqrOgcRR1irSWspGPM=; b=tzWJN37ywbjGg937L2OTXpfos8Py/wCIXlou9ldAAf7Mi9GD07THryIdrbKYeHuagQ /3ER1P7s9PmFBfJwK8550YRKV1V0GUGKY1m23LUMIN7A1A+rqGuahFuTAkjSBJzbHfnh S/nt7Nl4ny/1TGakjWuHuOoS8Oo802aodGMhn5A62tVfvlbLjv5VeG+bhm88ljxS1KIi nQ1nYehf+N6B2lxz1f451O5dnXi3k2JJkDX4v7C3wbwfjJDaft8JnLdYGI3OmAc3LQkH 3LiUi73e0f7c182QAUQmkDGZexeA0EPPR2LTEwE+W7/my4FfCA3lJiUWLT8gQQwYM4n5 h5QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pFMcp9+t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g1si14325801edn.0.2019.11.29.03.48.08; Fri, 29 Nov 2019 03:48:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pFMcp9+t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbfK2LrN (ORCPT + 99 others); Fri, 29 Nov 2019 06:47:13 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:42322 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbfK2LrM (ORCPT ); Fri, 29 Nov 2019 06:47:12 -0500 Received: by mail-io1-f66.google.com with SMTP id f25so6017298iog.9; Fri, 29 Nov 2019 03:47:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=cA0I5C6Q3B3d8zS+DiHH/GqBQJqrOgcRR1irSWspGPM=; b=pFMcp9+t6yyFcDTzFFqnBBeSM2+ij0bvxSPTKEAqX/xVLp3tSqg8hROyoxiW1R99k+ y1HP4Aj6JGB4AQYzeWaF/7wvS+TomQinHwy2fAbFDMeEj02LXLc99u+ykxgzVhs3Cs44 07y+lwCu1/cGWHM7iTTCVxPuR6FyNwC8ht7xsM9yT8ahFoOZgrgzcdDR3RyOWuoQB5OD 9Ndb730hkoGGXkia1tNIRC7zNEwtc2KGxy9uif+M5LTJ58jZehsWKhyuMR+KkaDTwNld 7FvvMNNjgO5IyXkcCxgSDzaNfV8lLpYt9leTHd4ifkGxa0WIVAzdjYGAhSnGCW64pq1U gT7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=cA0I5C6Q3B3d8zS+DiHH/GqBQJqrOgcRR1irSWspGPM=; b=LiVdtoRhN9nFR/gXcnzyGuKT2QYSbfQsGtsIrn+P7gwMSmlw0cMK12yTzBwdwLt0pG +9fUpPk+BYyvOnUv215WBO2/k2ybEuY0lHJboByoFc13baEEC13N3rwTpndWHFzn6dhZ YnGLeL0ToLHDnYJ587Eug+DsAGJTCNHva2CBN9P2W4UFzPubLRbA7B5b2ST+vfoyZM8z CVj8IrHDMuXMBsMONzXU03MqZg+Gi25w33jeTbnbsP/1U9o7C5v6og4TY475au2FjRAe YoOvnKLFEYt8PDQssJP3eKQy/6iLyDgXcYV9ff3Uvl6SiDbhRMge2uWfxA5Nv8/4ALhq /U3g== X-Gm-Message-State: APjAAAUwnHStWyzdmLBN/aVf3pSDv+aJab5MmlsH927RKfI8R3Iz5oEz D+Nt+HzMXW3yk83CREIa4HHOKAghedbK7aQCPLQ= X-Received: by 2002:a02:c004:: with SMTP id y4mr13664465jai.12.1575028030345; Fri, 29 Nov 2019 03:47:10 -0800 (PST) MIME-Version: 1.0 References: <20191127052935.1719897-1-anarsoul@gmail.com> <20191127052935.1719897-2-anarsoul@gmail.com> <20191128170626.xsm7xmizmbenqval@core.my.home> In-Reply-To: <20191128170626.xsm7xmizmbenqval@core.my.home> From: Frank Lee Date: Fri, 29 Nov 2019 19:46:58 +0800 Message-ID: Subject: Re: [PATCH v6 1/7] thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40 To: Frank Lee , Vasily Khoruzhick , Zhang Rui , Eduardo Valentin , Daniel Lezcano , Amit Kucheria , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Linux PM , devicetree , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2019 at 1:06 AM Ond=C5=99ej Jirman wrot= e: > > On Fri, Nov 29, 2019 at 12:43:02AM +0800, Frank Lee wrote: > > HI, > > > > I took a closer look at it, and I had some questions about these places= . > > > > On Wed, Nov 27, 2019 at 1:30 PM Vasily Khoruzhick = wrote: > > > > > > From: Yangtao Li > > > > > > This patch adds the support for allwinner thermal sensor, within > > > allwinner SoC. It will register sensors for thermal framework > > > and use device tree to bind cooling device. > > > > > > Signed-off-by: Yangtao Li > > > Signed-off-by: Ondrej Jirman > > > Signed-off-by: Vasily Khoruzhick > > > --- > > > MAINTAINERS | 7 + > > > drivers/thermal/Kconfig | 14 + > > > drivers/thermal/Makefile | 1 + > > > drivers/thermal/sun8i_thermal.c | 643 ++++++++++++++++++++++++++++++= ++ > > > 4 files changed, 665 insertions(+) > > > create mode 100644 drivers/thermal/sun8i_thermal.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 66cc549ac327..da34f3f2e80b 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -688,6 +688,13 @@ L: linux-crypto@vger.kernel.org > > > S: Maintained > > > F: drivers/crypto/allwinner/ > > > > > > +ALLWINNER THERMAL DRIVER > > > +M: Yangtao Li > > > +L: linux-pm@vger.kernel.org > > > +S: Maintained > > > +F: Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83= t-ths.yaml > > > +F: drivers/thermal/sun8i_thermal.c > > > + > > > ALLWINNER VPU DRIVER > > > M: Maxime Ripard > > > M: Paul Kocialkowski > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > > index 001a21abcc28..0b0422e89adb 100644 > > > --- a/drivers/thermal/Kconfig > > > +++ b/drivers/thermal/Kconfig > > > @@ -262,6 +262,20 @@ config SPEAR_THERMAL > > > Enable this to plug the SPEAr thermal sensor driver into th= e Linux > > > thermal framework. > > > > > > +config SUN8I_THERMAL > > > + tristate "Allwinner sun8i thermal driver" > > > + depends on ARCH_SUNXI || COMPILE_TEST > > > + depends on HAS_IOMEM > > > + depends on NVMEM > > > + depends on OF > > > + depends on RESET_CONTROLLER > > > + help > > > + Support for the sun8i thermal sensor driver into the Linux = thermal > > > + framework. > > > + > > > + To compile this driver as a module, choose M here: the > > > + module will be called sun8i-thermal. > > > + > > > config ROCKCHIP_THERMAL > > > tristate "Rockchip thermal driver" > > > depends on ARCH_ROCKCHIP || COMPILE_TEST > > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > > index 74a37c7f847a..fa6f8b206281 100644 > > > --- a/drivers/thermal/Makefile > > > +++ b/drivers/thermal/Makefile > > > @@ -31,6 +31,7 @@ thermal_sys-$(CONFIG_DEVFREQ_THERMAL) +=3D devfreq_= cooling.o > > > obj-y +=3D broadcom/ > > > obj-$(CONFIG_THERMAL_MMIO) +=3D thermal_mmio.o > > > obj-$(CONFIG_SPEAR_THERMAL) +=3D spear_thermal.o > > > +obj-$(CONFIG_SUN8I_THERMAL) +=3D sun8i_thermal.o > > > obj-$(CONFIG_ROCKCHIP_THERMAL) +=3D rockchip_thermal.o > > > obj-$(CONFIG_RCAR_THERMAL) +=3D rcar_thermal.o > > > obj-$(CONFIG_RCAR_GEN3_THERMAL) +=3D rcar_gen3_thermal.o > > > diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_= thermal.c > > > new file mode 100644 > > > index 000000000000..e86b64f51196 > > > --- /dev/null > > > +++ b/drivers/thermal/sun8i_thermal.c > > > @@ -0,0 +1,643 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Thermal sensor driver for Allwinner SOC > > > + * Copyright (C) 2019 Yangtao Li > > > + * > > > + * Based on the work of Icenowy Zheng > > > + * Based on the work of Ondrej Jirman > > > + * Based on the work of Josef Gajdusek > > > + */ > > > + > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#define MAX_SENSOR_NUM 4 > > > + > > > +#define FT_TEMP_MASK GENMASK(11, 0) > > > +#define TEMP_CALIB_MASK GENMASK(11, 0= ) > > > +#define CALIBRATE_DEFAULT 0x800 > > > + > > > +#define SUN8I_THS_CTRL0 0x00 > > > +#define SUN8I_THS_CTRL2 0x40 > > > +#define SUN8I_THS_IC 0x44 > > > +#define SUN8I_THS_IS 0x48 > > > +#define SUN8I_THS_MFC 0x70 > > > +#define SUN8I_THS_TEMP_CALIB 0x74 > > > +#define SUN8I_THS_TEMP_DATA 0x80 > > > + > > > +#define SUN50I_THS_CTRL0 0x00 > > > +#define SUN50I_H6_THS_ENABLE 0x04 > > > +#define SUN50I_H6_THS_PC 0x08 > > > +#define SUN50I_H6_THS_DIC 0x10 > > > +#define SUN50I_H6_THS_DIS 0x20 > > > +#define SUN50I_H6_THS_MFC 0x30 > > > +#define SUN50I_H6_THS_TEMP_CALIB 0xa0 > > > +#define SUN50I_H6_THS_TEMP_DATA 0xc0 > > > + > > > +#define SUN8I_THS_CTRL0_T_ACQ0(x) (GENMASK(15, 0) & (x)= ) > > > +#define SUN8I_THS_CTRL2_T_ACQ1(x) ((GENMASK(15, 0) & (x= )) << 16) > > > +#define SUN8I_THS_DATA_IRQ_STS(x) BIT(x + 8) > > > + > > > +#define SUN50I_THS_CTRL0_T_ACQ(x) ((GENMASK(15, 0) & (x= )) << 16) > > > +#define SUN50I_THS_FILTER_EN BIT(2) > > > +#define SUN50I_THS_FILTER_TYPE(x) (GENMASK(1, 0) & (x)) > > > +#define SUN50I_H6_THS_PC_TEMP_PERIOD(x) ((GENMASK(19,= 0) & (x)) << 12) > > > +#define SUN50I_H6_THS_DATA_IRQ_STS(x) BIT(x) > > > + > > > +/* millidegree celsius */ > > > +#define THS_EFUSE_CP_FT_MASK 0x3000 > > > +#define THS_EFUSE_CP_FT_BIT 12 > > > +#define THS_CALIBRATION_IN_FT 1 > > > + > > > +struct ths_device; > > > + > > > +struct tsensor { > > > + struct ths_device *tmdev; > > > + struct thermal_zone_device *tzd; > > > + int id; > > > +}; > > > + > > > +struct ths_thermal_chip { > > > + bool has_mod_clk; > > > + bool has_bus_clk_reset; > > > + int sensor_num; > > > + int offset; > > > + int scale; > > > + int ft_deviation; > > > + int temp_data_base; > > > + int (*calibrate)(struct ths_device *tmdev, > > > + u16 *caldata, int callen); > > > + int (*init)(struct ths_device *tmdev); > > > + int (*irq_ack)(struct ths_device *tmdev); > > > + int (*calc_temp)(struct ths_device *tmdev, > > > + int id, int reg); > > > +}; > > > + > > > +struct ths_device { > > > + const struct ths_thermal_chip *chip; > > > + struct device *dev; > > > + struct regmap *regmap; > > > + struct reset_control *reset; > > > + struct clk *bus_clk; > > > + struct clk *mod_clk; > > > + struct tsensor sensor[MAX_SENSOR_NUM= ]; > > > + u32 cp_ft_flag; > > > +}; > > > + > > > +/* Temp Unit: millidegree Celsius */ > > > +static int sun8i_ths_calc_temp(struct ths_device *tmdev, > > > + int id, int reg) > > > +{ > > > + return tmdev->chip->offset - (reg * tmdev->chip->scale / 10); > > > +} > > > + > > > +static int sun50i_h5_calc_temp(struct ths_device *tmdev, > > > + int id, int reg) > > > +{ > > > + if (reg >=3D 0x500) > > > + return -1191 * reg / 10 + 223000; > > > + else if (!id) > > > + return -1452 * reg / 10 + 259000; > > > + else > > > + return -1590 * reg / 10 + 276000; > > > +} > > > + > > > +static int sun8i_ths_get_temp(void *data, int *temp) > > > +{ > > > + struct tsensor *s =3D data; > > > + struct ths_device *tmdev =3D s->tmdev; > > > + int val =3D 0; > > > + > > > + regmap_read(tmdev->regmap, tmdev->chip->temp_data_base + > > > + 0x4 * s->id, &val); > > > + > > > + /* ths have no data yet */ > > > + if (!val) > > > + return -EAGAIN; > > > + > > > + *temp =3D tmdev->chip->calc_temp(tmdev, s->id, val); > > > + /* > > > + * According to the original sdk, there are some platforms(ra= rely) > > > + * that add a fixed offset value after calculating the temper= ature > > > + * value. We can't simply put it on the formula for calculati= ng the > > > + * temperature above, because the formula for calculating the > > > + * temperature above is also used when the sensor is calibrat= ed. If > > > + * do this, the correct calibration formula is hard to know. > > > + */ > > > + *temp +=3D tmdev->chip->ft_deviation; > > > + > > > + return 0; > > > +} > > > + > > > +static const struct thermal_zone_of_device_ops ths_ops =3D { > > > + .get_temp =3D sun8i_ths_get_temp, > > > +}; > > > + > > > +static const struct regmap_config config =3D { > > > + .reg_bits =3D 32, > > > + .val_bits =3D 32, > > > + .reg_stride =3D 4, > > > + .fast_io =3D true, > > > + .max_register =3D 0xfc, > > > +}; > > > + > > > +static int sun8i_h3_irq_ack(struct ths_device *tmdev) > > > +{ > > > + int i, state, ret =3D 0; > > > + > > > + regmap_read(tmdev->regmap, SUN8I_THS_IS, &state); > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + if (state & SUN8I_THS_DATA_IRQ_STS(i)) { > > > + regmap_write(tmdev->regmap, SUN8I_THS_IS, > > > + SUN8I_THS_DATA_IRQ_STS(i)); > > > + ret |=3D BIT(i); > > > + } > > > + } > > > + > > > + return ret; > > > +} > > > + > > > +static int sun50i_h6_irq_ack(struct ths_device *tmdev) > > > +{ > > > + int i, state, ret =3D 0; > > > + > > > + regmap_read(tmdev->regmap, SUN50I_H6_THS_DIS, &state); > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + if (state & SUN50I_H6_THS_DATA_IRQ_STS(i)) { > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_DIS= , > > > + SUN50I_H6_THS_DATA_IRQ_STS(i)); > > > + ret |=3D BIT(i); > > > + } > > > + } > > > + > > > + return ret; > > > +} > > > + > > > +static irqreturn_t sun8i_irq_thread(int irq, void *data) > > > +{ > > > + struct ths_device *tmdev =3D data; > > > + int i, state; > > > + > > > + state =3D tmdev->chip->irq_ack(tmdev); > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + if (state & BIT(i)) > > > + thermal_zone_device_update(tmdev->sensor[i].t= zd, > > > + THERMAL_EVENT_UNSP= ECIFIED); > > > + } > > > + > > > + return IRQ_HANDLED; > > > +} > > > + > > > +static int sun8i_h3_ths_calibrate(struct ths_device *tmdev, > > > + u16 *caldata, int callen) > > > +{ > > > + int i; > > > + > > > + if (!caldata[0] || callen < 2 * tmdev->chip->sensor_num) > > > + return -EINVAL; > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + int offset =3D (i % 2) << 4; > > > + > > > + regmap_update_bits(tmdev->regmap, > > > + SUN8I_THS_TEMP_CALIB + (4 * (i >> = 1)), > > > + 0xfff << offset, > > > + caldata[i] << offset); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int sun50i_h6_ths_calibrate(struct ths_device *tmdev, > > > + u16 *caldata, int callen) > > > +{ > > > + struct device *dev =3D tmdev->dev; > > > + int i, ft_temp; > > > + > > > + if (!caldata[0] || callen < 2 + 2 * tmdev->chip->sensor_num) > > > + return -EINVAL; > > > + > > > + /* > > > + * efuse layout: > > > + * > > > + * 0 11 16 32 > > > + * +-------+-------+-------+ > > > + * |temp| |sensor0|sensor1| > > > + * +-------+-------+-------+ > > > + * > > > + * The calibration data on the H6 is the ambient temperature = and > > > + * sensor values that are filled during the factory test stag= e. > > > + * > > > + * The unit of stored FT temperature is 0.1 degreee celusis. > > > + * > > > + * We need to calculate a delta between measured and caluclat= ed > > > + * register values and this will become a calibration offset. > > > + */ > > > + ft_temp =3D (caldata[0] & FT_TEMP_MASK) * 100; > > > + tmdev->cp_ft_flag =3D (caldata[0] & THS_EFUSE_CP_FT_MASK) > > > + >> THS_EFUSE_CP_FT_BIT; > > > > Here got an unused data "cp_ft_flag", > > which is used in the calculation of the temperature function according > > to the source code. > > > > https://github.com/orangepi-xunlong/OrangePiH6_kernel/blob/master/drive= rs/thermal/sunxi_thermal/sunxi_ths_core.c#L392 > > It should be used to enable the addition of ft_deviation in > sun8i_ths_get_temp(), I guess. Probably an ommission. I guess most of H6 > chips will have this set anyway. > > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + int sensor_reg =3D caldata[i + 1]; > > > + int cdata, offset; > > > + int sensor_temp =3D tmdev->chip->calc_temp(tmdev, i, = sensor_reg); > > > + > > > + /* > > > + * Calibration data is CALIBRATE_DEFAULT - (calculate= d > > > + * temperature from sensor reading at factory tempera= ture > > > + * minus actual factory temperature) * 14.88 (scale f= rom > > > + * temperature to register values) > > > + */ > > > + cdata =3D CALIBRATE_DEFAULT - > > > + ((sensor_temp - ft_temp) * 10 / tmdev->chip->= scale); > > > > Why change the formula here. > > > > https://github.com/orangepi-xunlong/OrangePiH6_kernel/blob/master/drive= rs/thermal/sunxi_thermal/sunxi_ths_core.c#L339 > HI, I suggest keeping you as it was before this patch, just change this place to this. cdata =3D CALIBRATE_DEFAULT - ((ft_temp * 100 - sensor_temp) / tmdev->chip->scale); Yangtao > It looks the same to me as before. Here's the original patch: > > https://megous.com/git/linux/commit/?h=3Dths-5.4&id=3Dcae28a7dfa6fc79ba37= e31d4dff281947247e822 > > It's basicaly to avoid magic values TEMP_TO_REG and use what's defined > in the chip struct. > > regards, > o. > > > > + if (cdata & ~TEMP_CALIB_MASK) { > > > + /* > > > + * Calibration value more than 12-bit, but ca= libration > > > + * register is 12-bit. In this case, ths hard= ware can > > > + * still work without calibration, although t= he data > > > + * won't be so accurate. > > > + */ > > > + dev_warn(dev, "sensor%d is not calibrated.\n"= , i); > > > + continue; > > > + } > > > + > > > + offset =3D (i % 2) * 16; > > > + regmap_update_bits(tmdev->regmap, > > > + SUN50I_H6_THS_TEMP_CALIB + (i / 2 = * 4), > > > + 0xfff << offset, > > > + cdata << offset); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int sun8i_ths_calibrate(struct ths_device *tmdev) > > > +{ > > > + struct nvmem_cell *calcell; > > > + struct device *dev =3D tmdev->dev; > > > + u16 *caldata; > > > + size_t callen; > > > + int ret =3D 0; > > > + > > > + calcell =3D devm_nvmem_cell_get(dev, "calibration"); > > > + if (IS_ERR(calcell)) { > > > + if (PTR_ERR(calcell) =3D=3D -EPROBE_DEFER) > > > + return -EPROBE_DEFER; > > > + /* > > > + * Even if the external calibration data stored in si= d is > > > + * not accessible, the THS hardware can still work, a= lthough > > > + * the data won't be so accurate. > > > + * > > > + * The default value of calibration register is 0x800= for > > > + * every sensor, and the calibration value is usually= 0x7xx > > > + * or 0x8xx, so they won't be away from the default v= alue > > > + * for a lot. > > > + * > > > + * So here we do not return error if the calibartion = data is > > > + * not available, except the probe needs deferring. > > > + */ > > > + goto out; > > > + } > > > + > > > + caldata =3D nvmem_cell_read(calcell, &callen); > > > + if (IS_ERR(caldata)) { > > > + ret =3D PTR_ERR(caldata); > > > + goto out; > > > + } > > > + > > > + tmdev->chip->calibrate(tmdev, caldata, callen); > > > + > > > + kfree(caldata); > > > +out: > > > + return ret; > > > +} > > > + > > > +static int sun8i_ths_resource_init(struct ths_device *tmdev) > > > +{ > > > + struct device *dev =3D tmdev->dev; > > > + struct platform_device *pdev =3D to_platform_device(dev); > > > + struct resource *mem; > > > + void __iomem *base; > > > + int ret; > > > + > > > + mem =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > + base =3D devm_ioremap_resource(dev, mem); > > > + if (IS_ERR(base)) > > > + return PTR_ERR(base); > > > + > > > + tmdev->regmap =3D devm_regmap_init_mmio(dev, base, &config); > > > + if (IS_ERR(tmdev->regmap)) > > > + return PTR_ERR(tmdev->regmap); > > > + > > > + if (tmdev->chip->has_bus_clk_reset) { > > > + tmdev->reset =3D devm_reset_control_get(dev, 0); > > > + if (IS_ERR(tmdev->reset)) > > > + return PTR_ERR(tmdev->reset); > > > + > > > + tmdev->bus_clk =3D devm_clk_get(&pdev->dev, "bus"); > > > + if (IS_ERR(tmdev->bus_clk)) > > > + return PTR_ERR(tmdev->bus_clk); > > > + } > > > + > > > + if (tmdev->chip->has_mod_clk) { > > > + tmdev->mod_clk =3D devm_clk_get(&pdev->dev, "mod"); > > > + if (IS_ERR(tmdev->mod_clk)) > > > + return PTR_ERR(tmdev->mod_clk); > > > + } > > > + > > > + ret =3D reset_control_deassert(tmdev->reset); > > > + if (ret) > > > + return ret; > > > + > > > + ret =3D clk_prepare_enable(tmdev->bus_clk); > > > + if (ret) > > > + goto assert_reset; > > > + > > > + ret =3D clk_set_rate(tmdev->mod_clk, 24000000); > > > + if (ret) > > > + goto bus_disable; > > > + > > > + ret =3D clk_prepare_enable(tmdev->mod_clk); > > > + if (ret) > > > + goto bus_disable; > > > + > > > + ret =3D sun8i_ths_calibrate(tmdev); > > > + if (ret) > > > + goto mod_disable; > > > + > > > + return 0; > > > + > > > +mod_disable: > > > + clk_disable_unprepare(tmdev->mod_clk); > > > +bus_disable: > > > + clk_disable_unprepare(tmdev->bus_clk); > > > +assert_reset: > > > + reset_control_assert(tmdev->reset); > > > + > > > + return ret; > > > +} > > > + > > > +static int sun8i_h3_thermal_init(struct ths_device *tmdev) > > > +{ > > > + int val; > > > + > > > + /* average over 4 samples */ > > > + regmap_write(tmdev->regmap, SUN8I_THS_MFC, > > > + SUN50I_THS_FILTER_EN | > > > + SUN50I_THS_FILTER_TYPE(1)); > > > + /* > > > + * clkin =3D 24MHz > > > + * filter_samples =3D 4 > > > + * period =3D 0.25s > > > + * > > > + * x =3D period * clkin / 4096 / filter_samples - 1 > > > + * =3D 365 > > > + */ > > > + val =3D GENMASK(7 + tmdev->chip->sensor_num, 8); > > > + regmap_write(tmdev->regmap, SUN8I_THS_IC, > > > + SUN50I_H6_THS_PC_TEMP_PERIOD(365) | val); > > > + /* > > > + * T_acq =3D 20us > > > + * clkin =3D 24MHz > > > + * > > > + * x =3D T_acq * clkin - 1 > > > + * =3D 479 > > > + */ > > > + regmap_write(tmdev->regmap, SUN8I_THS_CTRL0, > > > + SUN8I_THS_CTRL0_T_ACQ0(479)); > > > + val =3D GENMASK(tmdev->chip->sensor_num - 1, 0); > > > + regmap_write(tmdev->regmap, SUN8I_THS_CTRL2, > > > + SUN8I_THS_CTRL2_T_ACQ1(479) | val); > > > + > > > + return 0; > > > +} > > > + > > > +/* > > > + * Without this undocummented value, the returned temperatures would > > > + * be higher than real ones by about 20C. > > > + */ > > > +#define SUN50I_H6_CTRL0_UNK 0x0000002f > > > + > > > +static int sun50i_h6_thermal_init(struct ths_device *tmdev) > > > +{ > > > + int val; > > > + > > > + /* > > > + * T_acq =3D 20us > > > + * clkin =3D 24MHz > > > + * > > > + * x =3D T_acq * clkin - 1 > > > + * =3D 479 > > > + */ > > > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0, > > > + SUN50I_H6_CTRL0_UNK | SUN50I_THS_CTRL0_T_ACQ(479= )); > > > + /* average over 4 samples */ > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC, > > > + SUN50I_THS_FILTER_EN | > > > + SUN50I_THS_FILTER_TYPE(1)); > > > + /* > > > + * clkin =3D 24MHz > > > + * filter_samples =3D 4 > > > + * period =3D 0.25s > > > + * > > > + * x =3D period * clkin / 4096 / filter_samples - 1 > > > + * =3D 365 > > > + */ > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC, > > > + SUN50I_H6_THS_PC_TEMP_PERIOD(365)); > > > + /* enable sensor */ > > > + val =3D GENMASK(tmdev->chip->sensor_num - 1, 0); > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_ENABLE, val); > > > + /* thermal data interrupt enable */ > > > + val =3D GENMASK(tmdev->chip->sensor_num - 1, 0); > > > + regmap_write(tmdev->regmap, SUN50I_H6_THS_DIC, val); > > > + > > > + return 0; > > > +} > > > + > > > +static int sun8i_ths_register(struct ths_device *tmdev) > > > +{ > > > + int i; > > > + > > > + for (i =3D 0; i < tmdev->chip->sensor_num; i++) { > > > + tmdev->sensor[i].tmdev =3D tmdev; > > > + tmdev->sensor[i].id =3D i; > > > + tmdev->sensor[i].tzd =3D > > > + devm_thermal_zone_of_sensor_register(tmdev->d= ev, > > > + i, > > > + &tmdev->= sensor[i], > > > + &ths_ops= ); > > > + if (IS_ERR(tmdev->sensor[i].tzd)) > > > + return PTR_ERR(tmdev->sensor[i].tzd); > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int sun8i_ths_probe(struct platform_device *pdev) > > > +{ > > > + struct ths_device *tmdev; > > > + struct device *dev =3D &pdev->dev; > > > + int ret, irq; > > > + > > > + tmdev =3D devm_kzalloc(dev, sizeof(*tmdev), GFP_KERNEL); > > > + if (!tmdev) > > > + return -ENOMEM; > > > + > > > + tmdev->dev =3D dev; > > > + tmdev->chip =3D of_device_get_match_data(&pdev->dev); > > > + if (!tmdev->chip) > > > + return -EINVAL; > > > + > > > + platform_set_drvdata(pdev, tmdev); > > > + > > > + ret =3D sun8i_ths_resource_init(tmdev); > > > + if (ret) > > > + return ret; > > > + > > > + irq =3D platform_get_irq(pdev, 0); > > > + if (irq < 0) > > > + return irq; > > > + > > > + ret =3D tmdev->chip->init(tmdev); > > > + if (ret) > > > + return ret; > > > + > > > + ret =3D sun8i_ths_register(tmdev); > > > + if (ret) > > > + return ret; > > > + > > > + /* > > > + * Avoid entering the interrupt handler, the thermal device i= s not > > > + * registered yet, we deffer the registration of the interrup= t to > > > + * the end. > > > + */ > > > + ret =3D devm_request_threaded_irq(dev, irq, NULL, > > > + sun8i_irq_thread, > > > + IRQF_ONESHOT, "ths", tmdev); > > > + if (ret) > > > + return ret; > > > + > > > + return ret; > > > +} > > > + > > > +static int sun8i_ths_remove(struct platform_device *pdev) > > > +{ > > > + struct ths_device *tmdev =3D platform_get_drvdata(pdev); > > > + > > > + clk_disable_unprepare(tmdev->mod_clk); > > > + clk_disable_unprepare(tmdev->bus_clk); > > > + reset_control_assert(tmdev->reset); > > > + > > > + return 0; > > > +} > > > + > > > +static const struct ths_thermal_chip sun8i_a83t_ths =3D { > > > + .sensor_num =3D 3, > > > + .scale =3D 705, > > > + .offset =3D 191668, > > > + .temp_data_base =3D SUN8I_THS_TEMP_DATA, > > > + .calibrate =3D sun8i_h3_ths_calibrate, > > > + .init =3D sun8i_h3_thermal_init, > > > + .irq_ack =3D sun8i_h3_irq_ack, > > > + .calc_temp =3D sun8i_ths_calc_temp, > > > +}; > > > + > > > +static const struct ths_thermal_chip sun8i_h3_ths =3D { > > > + .sensor_num =3D 1, > > > + .scale =3D 1211, > > > + .offset =3D 217000, > > > + .has_mod_clk =3D true, > > > + .has_bus_clk_reset =3D true, > > > + .temp_data_base =3D SUN8I_THS_TEMP_DATA, > > > + .calibrate =3D sun8i_h3_ths_calibrate, > > > + .init =3D sun8i_h3_thermal_init, > > > + .irq_ack =3D sun8i_h3_irq_ack, > > > + .calc_temp =3D sun8i_ths_calc_temp, > > > +}; > > > + > > > +static const struct ths_thermal_chip sun8i_r40_ths =3D { > > > + .sensor_num =3D 3, > > > + .offset =3D 251086, > > > + .scale =3D 1130, > > > + .has_mod_clk =3D true, > > > + .has_bus_clk_reset =3D true, > > > + .temp_data_base =3D SUN8I_THS_TEMP_DATA, > > > + .calibrate =3D sun8i_h3_ths_calibrate, > > > + .init =3D sun8i_h3_thermal_init, > > > + .irq_ack =3D sun8i_h3_irq_ack, > > > + .calc_temp =3D sun8i_ths_calc_temp, > > > +}; > > > + > > > +static const struct ths_thermal_chip sun50i_a64_ths =3D { > > > + .sensor_num =3D 3, > > > + .offset =3D 253890, > > > + .scale =3D 1170, > > > + .has_mod_clk =3D true, > > > + .has_bus_clk_reset =3D true, > > > + .temp_data_base =3D SUN8I_THS_TEMP_DATA, > > > + .calibrate =3D sun8i_h3_ths_calibrate, > > > + .init =3D sun8i_h3_thermal_init, > > > + .irq_ack =3D sun8i_h3_irq_ack, > > > + .calc_temp =3D sun8i_ths_calc_temp, > > > +}; > > > + > > > +static const struct ths_thermal_chip sun50i_h5_ths =3D { > > > + .sensor_num =3D 2, > > > + .has_mod_clk =3D true, > > > + .has_bus_clk_reset =3D true, > > > + .temp_data_base =3D SUN8I_THS_TEMP_DATA, > > > + .calibrate =3D sun8i_h3_ths_calibrate, > > > + .init =3D sun8i_h3_thermal_init, > > > + .irq_ack =3D sun8i_h3_irq_ack, > > > + .calc_temp =3D sun50i_h5_calc_temp, > > > +}; > > > + > > > +static const struct ths_thermal_chip sun50i_h6_ths =3D { > > > + .sensor_num =3D 2, > > > + .has_bus_clk_reset =3D true, > > > + .ft_deviation =3D 7000, > > > + .offset =3D 187744, > > > + .scale =3D 672, > > > + .temp_data_base =3D SUN50I_H6_THS_TEMP_DATA, > > > + .calibrate =3D sun50i_h6_ths_calibrate, > > > + .init =3D sun50i_h6_thermal_init, > > > + .irq_ack =3D sun50i_h6_irq_ack, > > > + .calc_temp =3D sun8i_ths_calc_temp, > > > +}; > > > + > > > +static const struct of_device_id of_ths_match[] =3D { > > > + { .compatible =3D "allwinner,sun8i-a83t-ths", .data =3D &sun8= i_a83t_ths }, > > > + { .compatible =3D "allwinner,sun8i-h3-ths", .data =3D &sun8i_= h3_ths }, > > > + { .compatible =3D "allwinner,sun8i-r40-ths", .data =3D &sun8i= _r40_ths }, > > > + { .compatible =3D "allwinner,sun50i-a64-ths", .data =3D &sun5= 0i_a64_ths }, > > > + { .compatible =3D "allwinner,sun50i-h5-ths", .data =3D &sun50= i_h5_ths }, > > > + { .compatible =3D "allwinner,sun50i-h6-ths", .data =3D &sun50= i_h6_ths }, > > > + { /* sentinel */ }, > > > +}; > > > +MODULE_DEVICE_TABLE(of, of_ths_match); > > > + > > > +static struct platform_driver ths_driver =3D { > > > + .probe =3D sun8i_ths_probe, > > > + .remove =3D sun8i_ths_remove, > > > + .driver =3D { > > > + .name =3D "sun8i-thermal", > > > + .of_match_table =3D of_ths_match, > > > + }, > > > +}; > > > +module_platform_driver(ths_driver); > > > + > > > +MODULE_DESCRIPTION("Thermal sensor driver for Allwinner SOC"); > > > +MODULE_LICENSE("GPL v2"); > > > -- > > > 2.24.0 > > > > > > > Thx, > > Yangtao