Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Nov 2019 14:07:10 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] perf record: adapt affinity to machines with
 #CPUs > 1K
Message-ID: <20191129130710.GB14169@krava>
References: <908dbe98-7d8d-0ec1-d4ae-242f3e104979@linux.intel.com>
 <21bc3ad7-e1f2-68da-f004-36354a6e40ea@linux.intel.com>
MIME-Version: 1.0
In-Reply-To: <21bc3ad7-e1f2-68da-f004-36354a6e40ea@linux.intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 29, 2019 at 01:05:26PM +0300, Alexey Budankov wrote:

SNIP

>  # undef REASON
>  #endif
> =20
> -=09CPU_ZERO(&rec->affinity_mask);
>  =09rec->opts.affinity =3D PERF_AFFINITY_SYS;
> =20
>  =09rec->evlist =3D evlist__new();
> @@ -2499,6 +2504,14 @@ int cmd_record(int argc, const char **argv)
> =20
>  =09symbol__init(NULL);
> =20
> +=09rec->affinity_mask.nbits =3D cpu__max_cpu();
> +=09rec->affinity_mask.bits =3D bitmap_alloc(rec->affinity_mask.nbits);
> +=09if (!rec->affinity_mask.bits) {
> +=09=09pr_err("Failed to allocate thread mask for %ld cpus\n", rec->affin=
ity_mask.nbits);
> +=09=09return -ENOMEM;
> +=09}
> +=09pr_debug2("thread mask[%ld]: empty\n", rec->affinity_mask.nbits);

above can be done only for (rec->opts.affinity !=3D PERF_AFFINITY_SYS)


> +
>  =09err =3D record__auxtrace_init(rec);
>  =09if (err)
>  =09=09goto out;
> @@ -2613,6 +2626,8 @@ int cmd_record(int argc, const char **argv)
> =20
>  =09err =3D __cmd_record(&record, argc, argv);
>  out:
> +=09if (rec->affinity_mask.bits)
> +=09=09bitmap_free(rec->affinity_mask.bits);
>  =09evlist__delete(rec->evlist);
>  =09symbol__exit();
>  =09auxtrace_record__free(rec->itr);
> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
> index 30ff7aef06f2..615d05870849 100644
> --- a/tools/perf/util/mmap.c
> +++ b/tools/perf/util/mmap.c
> @@ -219,6 +219,9 @@ static void perf_mmap__aio_munmap(struct mmap *map __=
maybe_unused)
> =20
>  void mmap__munmap(struct mmap *map)
>  {
> +=09if (map->affinity_mask.bits)
> +=09=09bitmap_free(map->affinity_mask.bits);

you don't need to check map->affinity_mask.bits, it's checked in free

jirka