Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 29 Nov 2019 14:09:46 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] perf mmap: declare type for cpu mask of arbitrary
 length
Message-ID: <20191129130946.GC14169@krava>
References: <908dbe98-7d8d-0ec1-d4ae-242f3e104979@linux.intel.com>
 <446c4345-cb20-d0ad-3b3d-b34683b1c1e0@linux.intel.com>
MIME-Version: 1.0
In-Reply-To: <446c4345-cb20-d0ad-3b3d-b34683b1c1e0@linux.intel.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 29, 2019 at 01:04:37PM +0300, Alexey Budankov wrote:
>=20
> Declare a dedicated struct map_cpu_mask type for cpu masks of
> arbitrary length. Mask is available thru bits pointer and the
> mask length is kept in nbits field. MMAP_CPU_MASK_BYTES() macro
> returns mask storage size in bytes. perf_mmap__print_cpu_mask()
> function can be used to log text representation of the mask.
>=20
> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
> ---
>  tools/perf/util/mmap.c | 12 ++++++++++++
>  tools/perf/util/mmap.h | 11 +++++++++++
>  2 files changed, 23 insertions(+)
>=20
> diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c
> index 063d1b93c53d..30ff7aef06f2 100644
> --- a/tools/perf/util/mmap.c
> +++ b/tools/perf/util/mmap.c
> @@ -23,6 +23,18 @@
>  #include "mmap.h"
>  #include "../perf.h"
>  #include <internal/lib.h> /* page_size */
> +#include <linux/bitmap.h>
> +
> +#define MASK_SIZE 1023
> +void perf_mmap__print_cpu_mask(struct mmap_cpu_mask *mask, const char *t=
ag)

'mmap_cpu_mask__scnprintf' name follows the name logic we try to use

jirka

> +{
> +=09char buf[MASK_SIZE + 1];
> +=09size_t len;
> +
> +=09len =3D bitmap_scnprintf(mask->bits, mask->nbits, buf, MASK_SIZE);
> +=09buf[len] =3D '\0';
> +=09pr_debug("%p: %s mask[%ld]: %s\n", mask, tag, mask->nbits, buf);
> +}
> =20
>  size_t mmap__mmap_len(struct mmap *map)
>  {
> diff --git a/tools/perf/util/mmap.h b/tools/perf/util/mmap.h
> index bee4e83f7109..598e2def8a48 100644
> --- a/tools/perf/util/mmap.h
> +++ b/tools/perf/util/mmap.h
> @@ -15,6 +15,15 @@
>  #include "event.h"
> =20
>  struct aiocb;
> +
> +struct mmap_cpu_mask {
> +=09unsigned long *bits;
> +=09size_t nbits;
> +};
> +
> +#define MMAP_CPU_MASK_BYTES(m) \
> +=09(BITS_TO_LONGS(((struct mmap_cpu_mask *)m)->nbits) * sizeof(unsigned =
long))
> +
>  /**
>   * struct mmap - perf's ring buffer mmap details
>   *
> @@ -52,4 +61,6 @@ int perf_mmap__push(struct mmap *md, void *to,
> =20
>  size_t mmap__mmap_len(struct mmap *map);
> =20
> +void perf_mmap__print_cpu_mask(struct mmap_cpu_mask *mask, const char *t=
ag);
> +
>  #endif /*__PERF_MMAP_H */
> --=20
> 2.20.1
>=20