Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191120144109.25321-1-alexandre.torgue@st.com> <20191120144109.25321-6-alexandre.torgue@st.com>
In-Reply-To: <20191120144109.25321-6-alexandre.torgue@st.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Fri, 29 Nov 2019 15:20:17 +0100
Message-ID: <CAK8P3a2Bg9KwfEqEE3_NUHxVv=svFGuj--Tnq-w-xFg63cfqAA@mail.gmail.com>
Subject: Re: [PATCH 5/6] ARM: dts: stm32: Adapt STM32MP157 DK boards to stm32
 DT diversity
To:     Alexandre Torgue <alexandre.torgue@st.com>
Cc:     Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        DTML <devicetree@vger.kernel.org>,
        linux-stm32@st-md-mailman.stormreply.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 20, 2019 at 3:41 PM Alexandre Torgue
<alexandre.torgue@st.com> wrote:
>
> To handle STM32MP15 SOCs diversity, some updates have to been done.
> This commit mainly adapt dk1 board to include the correct package and the
> correct SOC version. A new file has been created to factorize common parts.
>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
>
> diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts
> index 3f869bd67082..1292ac3b6890 100644
> --- a/arch/arm/boot/dts/stm32mp157a-dk1.dts
> +++ b/arch/arm/boot/dts/stm32mp157a-dk1.dts
>         model = "STMicroelectronics STM32MP157A-DK1 Discovery Board";
>         compatible = "st,stm32mp157a-dk1", "st,stm32mp157";
> -
> -       aliases {
> -               ethernet0 = &ethernet0;
> -               serial0 = &uart4;
> -       };
> -
> -       chosen {
> -               stdout-path = "serial0:115200n8";
> -       };
> -

As a rule, I would leave aliases and chosen nodes in the .dts file and not
move them into a shared .dtsi, since they tend to be board specific.

(even if that may not be the case in this particular file)

      Arnd