Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH] mips: Fix gettimeofday() in the vdso library
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <0b64c6bb-ffc7-059d-3cb3-012092e0fcf0@arm.com>
Date:   Fri, 29 Nov 2019 16:09:51 +0100
Cc:     Paul Burton <paulburton@kernel.org>,
        mips-creator-ci20-dev@googlegroups.com,
        letux-kernel@openphoenux.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <DCD7A17F-B045-440E-AB66-7F8AB72A19CA@goldelico.com>
References: <20191129143658.12224-1-vincenzo.frascino@arm.com> <307717BD-3233-4313-BAA8-7431F4C78773@goldelico.com> <0b64c6bb-ffc7-059d-3cb3-012092e0fcf0@arm.com>
To:     Vincenzo Frascino <vincenzo.frascino@arm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Am 29.11.2019 um 15:58 schrieb Vincenzo Frascino =
<vincenzo.frascino@arm.com>:
>=20
> On 11/29/19 2:52 PM, H. Nikolaus Schaller wrote:
>>=20
>>> Am 29.11.2019 um 15:36 schrieb Vincenzo Frascino =
<vincenzo.frascino@arm.com>:
>>>=20
>>> The libc provides a discovery mechanism for vDSO library and its
>>> symbols. When a symbol is not exposed by the vDSOs the libc falls =
back
>>> on the system calls.
>>>=20
>>> With the introduction of the unified vDSO library on mips this =
behavior
>>> is not honored anymore by the kernel in the case of gettimeofday().
>>>=20
>>> The issue has been noticed and reported due to a dhclient failure on =
the
>>> CI20 board:
>>>=20
>>> root@letux:~# dhclient
>>> ../../../../lib/isc/unix/time.c:200: Operation not permitted
>>> root@letux:~#
>>>=20
>>> Restore the original behavior fixing gettimeofday() in the vDSO =
library.
>>>=20
>>> Cc: Paul Burton <paulburton@kernel.org>
>>> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
>>> Testes-by: H. Nikolaus Schaller <hns@goldelico.com> # CI20 with =
JZ4780
>> ^^^ funny typo... -> Tested-by:
>=20
> Ops, I copy-pasted it from your email ;) Can't trust you ;)

No :)

Well, typos happen and nobody seems to notice. My favourite:

5f9e832c137075045d15cd6899ab0505cfb2ca4b

BR,
Nikolaus