Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp8292518ybc; Fri, 29 Nov 2019 08:15:41 -0800 (PST) X-Google-Smtp-Source: APXvYqwG+eM6uyLbUot9BUP+tX0v8q6BTp1G5KbEETWL40qzY5+QZdWVnnNKJEem9rpMBE9EtsOg X-Received: by 2002:a17:906:da1d:: with SMTP id fi29mr5932501ejb.205.1575044141578; Fri, 29 Nov 2019 08:15:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575044141; cv=none; d=google.com; s=arc-20160816; b=HEzIAg50n6MFiKn29OgcG3y1joLisBhCSgP43YLKiEHeCTWZn/mpOlxl/hIz3hZUnB QGOhr9retrlwrZZQQSLiavJTPKc8329GZ1tsePUVMX7Hp/ocJXpH/R51MblMj7jfWonJ pwZlSNCseSVHgJkWR6xumU0NJuAmlwcxZ0ySDwAOsAS1q/tfqy/jfBrs2QNHyfZ+7S0a oATpC2FT3UhPMZghoeLCzETb1bJ6CGBQ0OXb0zEewbBc6sk/nD5hAZU4qmmQdWM3Gpi6 DZ6+FhFOdO1n3+yQDdAhZH8JPkOX90DY1I8KzZ3E5zKFB1CIARZoYkfUVZKU+JichQHX LXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=FovemUvA6qctABDabS0NtDnUTnpAPHjSV1V8/RSSR9g=; b=U/M6O0tZY0IVf9mb6XoJQAg6bEOoDOSf9nVgr0W+Ps57LpwLguQFcLDENfHA8kjUKg 6KKW4DpnA8FqhicCdCguP7mmxp4DvVoFz2wuYUk+Nq2k6c26XI9H3bWn+LI4gig9ptcR op5VqImHoKqMeXb0fV5cVee2CvcSggK4F68uWCe5MZWEZjOGHjlCguyQPvzNAIFe+9IW 2ODJoV8jGEdxP38ChYyJ8qcrpPZV/veEHB9ePzAxCGBSR7y6pUp3uDXwrF+R/I6HNWoY YHp1o5tq0XUmPQNkEyarIKLUbP4qsnQ94jgn+6uP8ooezXdIMj64+AjrjLrFHjBuQuqw YwkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=MIp0XX8k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1si13879476eje.298.2019.11.29.08.15.16; Fri, 29 Nov 2019 08:15:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=MIp0XX8k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726971AbfK2QOV (ORCPT + 99 others); Fri, 29 Nov 2019 11:14:21 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:57527 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726909AbfK2QOU (ORCPT ); Fri, 29 Nov 2019 11:14:20 -0500 Received: from localhost (mailhub1-ext [192.168.12.233]) by localhost (Postfix) with ESMTP id 47Pfhn6hbbz9vBLm; Fri, 29 Nov 2019 17:14:17 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=MIp0XX8k; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id czFo_DUix5Vc; Fri, 29 Nov 2019 17:14:17 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 47Pfhn4lwGz9vBLl; Fri, 29 Nov 2019 17:14:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1575044057; bh=FovemUvA6qctABDabS0NtDnUTnpAPHjSV1V8/RSSR9g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MIp0XX8k/I4wsfEgOYSzCsDkEXhTrmYqxehmxuBCm6XkDFcJq3T0hGxEYQ1Kz6NIG M7TpVa13ygd3AwlIJXHrwq1iQnMaePGf8TUnA+J1BqgPr3u+6+v9CF3rnVnRUCz+98 lseISBglyZJmBfRPyJbcLqVhWJ//g3rACrqlq9/Y= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 42FDF8B8DE; Fri, 29 Nov 2019 17:14:19 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 0j_ez_gOcD8Z; Fri, 29 Nov 2019 17:14:19 +0100 (CET) Received: from [172.25.230.103] (po15451.idsi0.si.c-s.fr [172.25.230.103]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 215048B8DC; Fri, 29 Nov 2019 17:14:19 +0100 (CET) Subject: Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw) To: Jens Axboe , "linuxppc-dev@lists.ozlabs.org" , Pavel Begunkov Cc: stable@vger.kernel.org, LKML References: <71cf82d5-5986-43b7-cf1c-acba429a89d6@c-s.fr> <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk> From: Christophe Leroy Message-ID: <4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr> Date: Fri, 29 Nov 2019 17:14:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 29/11/2019 à 17:04, Jens Axboe a écrit : > On 11/29/19 6:53 AM, Christophe Leroy wrote: >>     CC      fs/io_uring.o >> fs/io_uring.c: In function ‘loop_rw_iter’: >> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’ >> [-Werror=implicit-function-declaration] >>       iovec.iov_base = kmap(iter->bvec->bv_page) >>                        ^ >> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer >> without a cast [-Wint-conversion] >>       iovec.iov_base = kmap(iter->bvec->bv_page) >>                      ^ >> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’ >> [-Werror=implicit-function-declaration] >>       kunmap(iter->bvec->bv_page); >>       ^ >> >> >> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter >> fixed rw") clears the failure. >> >> Most likely an #include is missing. > > Huh weird how the build bots didn't catch that. Does the below work? Yes it works, thanks. Christophe