Received: by 2002:a25:7ec1:0:0:0:0:0 with SMTP id z184csp8362730ybc; Fri, 29 Nov 2019 09:18:46 -0800 (PST) X-Google-Smtp-Source: APXvYqyBDn7D3KFuoBb16r3YIhhYbzRIC4DFuVw8zqO++z7bmcY8D6QwQhcF8VZJR6NzHlXmxr8n X-Received: by 2002:a50:875c:: with SMTP id 28mr40781086edv.271.1575047925882; Fri, 29 Nov 2019 09:18:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575047925; cv=none; d=google.com; s=arc-20160816; b=m63KexkQsaV2C9oo2uzJwDFzR5d6yLYNAwb8dLvFrgYZtIUn+8FTzcB5SV4UyEIykE 0tIb3jdUYmuNvuO9ICR6SMykWJdsVy1l267XzDkg55ODJDG6qD2uZIBlvTc8xoxdlRWU bUNUpLM2kztEiA1N8AT5NkDHKQgXXgUR9bkYqFzlINTrV5VNemVQ3YNxk450dXw4bjwe 5FHzS/ePxKP9kiu8+VoPlnLt0iR9Qryi7ytWA3WVy9wHHr4iEmtCCoW3DPaehuJYgM2i HhGZYg61vqodvH4MFrHtl5Z7Uj0+W1BbOZVTgCxLIE5Jfrx7c2gTk+7FnZrzHIGOUK+M 59nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=cJUqaft98JUbJoAJGvOcDoZ/xfTmcquNmc0PZ2Qp0uM=; b=EdxHVYnebkoK/CO2BBpFItT4vBH0DgF/CYxEkfvovCsBHbislEXeJWUbtLZsJFCN/k x/vGTjgERynxtVe8VSX5YR9VdQo1wS5zMhtXTKcvOIqO8TcP1P+Hncfy9tkHpJUnC5ko nURvpNP9ok67FktCuqk0ZHEMgF0UgjgJuELdRJbpIPfWDqIQlN42h3G1EduPLGj+0quN bx9DsZt838LZvkyKoSVRb9fKbht7IP0aJE2vyAnJNsP4q3Xvmfh4ms9G6cieUgrkNp/2 +S7+EHEVMRuCVipHR/Zil0yLvie9ddJhHMtz9yD/8GlpL9g0DeWzsYUPatU6Tf1yuaha vk/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ubBm2VrL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id dm4si9988605edb.440.2019.11.29.09.18.20; Fri, 29 Nov 2019 09:18:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ubBm2VrL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbfK2RQ3 (ORCPT + 99 others); Fri, 29 Nov 2019 12:16:29 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:42169 "EHLO mail-pf1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726608AbfK2RQ3 (ORCPT ); Fri, 29 Nov 2019 12:16:29 -0500 Received: by mail-pf1-f176.google.com with SMTP id l22so2423729pff.9 for ; Fri, 29 Nov 2019 09:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cJUqaft98JUbJoAJGvOcDoZ/xfTmcquNmc0PZ2Qp0uM=; b=ubBm2VrLVzUJImie+uq75o/+w+tTc6Z0mrIfJ5WIoRKYN4Pp8UgmXdvLJ0PB+K9IhA 6HUT780D+oJvXsK4Es3SKuPMCTJ+bOPIxsCqanMKRKhEOgvyTWRTLsgZMTGntNWluwM/ sQSlPJU7T/UAGC+4gs3t94QQhF6xK6ewMvgJnrFdie8m4ZnRAOC1hjxofhhLNmOj72zP ALJLfymTQTKWVuPeIwpJbgFpdCt4C/X+ouBZ2Rdk8NY0VGFuC1qCPqZxFYjFmkVOPkmY FhKWyM2KHapwRofvaaFr5pXTPrXWBqblmVbYiI+wa7LRqdAoktrqqnTdSiXEi5NtbYIW p77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cJUqaft98JUbJoAJGvOcDoZ/xfTmcquNmc0PZ2Qp0uM=; b=YkcC+Bx+rJ4cFP3W5usq7p60RMEiLCiV7zDFJ1NR0RW+LjROzt41dK0PVykHmEjT7+ m31fddRnLRK9e0sGoZPmq2q40oSQLQ7ECDZYpMc8vFZH4VlHIWN6/28+vFp8psAb8YMt ENmCOt07pYgCQ871UOH8ge9YKdug79UNzzOaHZSXXpPQ0Sqb96j0JKO1iAKC2zgoqA3y ILEXiMRYQoIrycoBWBIUhZKfzPfz6uhxMEooNqOwaVWTp/cd6bvzKKDpQStG9y12M5ld r+DOiFr5mgsLYn2pNtMKikUEcN21nzqFAItns1pFSRFUT3nynrp3nTOkkohFJqW9MnMX llSg== X-Gm-Message-State: APjAAAVkVlUMCrZ5rqYfo9ssCyhzywvZ1dnqvGh1exiJZHOSUCsTzWaA gzxYcmZqT3falfNn5p4xR5ILEzf6IZcyug== X-Received: by 2002:a63:5104:: with SMTP id f4mr17722304pgb.192.1575047787014; Fri, 29 Nov 2019 09:16:27 -0800 (PST) Received: from ?IPv6:2605:e000:100e:8c61:c457:26a3:bdc5:9aed? ([2605:e000:100e:8c61:c457:26a3:bdc5:9aed]) by smtp.gmail.com with ESMTPSA id s2sm26042860pfb.109.2019.11.29.09.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2019 09:16:20 -0800 (PST) Subject: Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw) To: Christophe Leroy , "linuxppc-dev@lists.ozlabs.org" , Pavel Begunkov Cc: stable@vger.kernel.org, LKML References: <71cf82d5-5986-43b7-cf1c-acba429a89d6@c-s.fr> <3a95d445-1f5c-7750-f0de-ddc427800b3b@kernel.dk> <4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr> From: Jens Axboe Message-ID: <5389b43a-259d-997c-41e6-5e84a91b012a@kernel.dk> Date: Fri, 29 Nov 2019 09:16:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <4ef71e74-848f-59d4-6b0b-d3a3c52095a0@c-s.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/19 8:14 AM, Christophe Leroy wrote: > > > Le 29/11/2019 à 17:04, Jens Axboe a écrit : >> On 11/29/19 6:53 AM, Christophe Leroy wrote: >>> CC fs/io_uring.o >>> fs/io_uring.c: In function ‘loop_rw_iter’: >>> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’ >>> [-Werror=implicit-function-declaration] >>> iovec.iov_base = kmap(iter->bvec->bv_page) >>> ^ >>> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer >>> without a cast [-Wint-conversion] >>> iovec.iov_base = kmap(iter->bvec->bv_page) >>> ^ >>> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’ >>> [-Werror=implicit-function-declaration] >>> kunmap(iter->bvec->bv_page); >>> ^ >>> >>> >>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter >>> fixed rw") clears the failure. >>> >>> Most likely an #include is missing. >> >> Huh weird how the build bots didn't catch that. Does the below work? > > Yes it works, thanks. Thanks for reporting and testing, I've queued it up with your reported and tested-by. -- Jens Axboe