Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 30 Nov 2019 07:50:35 +0100
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc:     rfontana@redhat.com, gregkh@linuxfoundation.org,
        allison@lohutok.net, kstewart@linuxfoundation.org,
        tglx@linutronix.de, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] media: dvb_dummy_fe: place EXPORT_SYMBOL below
 corresponding function
Message-ID: <20191130075035.28fb3714@kernel.org>
In-Reply-To: <20191106183716.29170-1-dwlsalmeida@gmail.com>
References: <20191106183716.29170-1-dwlsalmeida@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed,  6 Nov 2019 15:37:16 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> escreveu:

> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
> 
> Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>

Looks OK on my eyes.

> ---
>  drivers/media/dvb-frontends/dvb_dummy_fe.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.c b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> index 4db679cb70ad..909dac2345c4 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.c
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.c
> @@ -121,6 +121,7 @@ struct dvb_frontend* dvb_dummy_fe_ofdm_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops;
>  
> @@ -138,6 +139,7 @@ struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_qam_ops;
>  
> @@ -155,6 +157,7 @@ struct dvb_frontend *dvb_dummy_fe_qam_attach(void)
>  	state->frontend.demodulator_priv = state;
>  	return &state->frontend;
>  }
> +EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
>  
>  static const struct dvb_frontend_ops dvb_dummy_fe_ofdm_ops = {
>  	.delsys = { SYS_DVBT },
> @@ -253,7 +256,3 @@ static const struct dvb_frontend_ops dvb_dummy_fe_qpsk_ops = {
>  MODULE_DESCRIPTION("DVB DUMMY Frontend");
>  MODULE_AUTHOR("Emard");
>  MODULE_LICENSE("GPL");
> -
> -EXPORT_SYMBOL(dvb_dummy_fe_ofdm_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qam_attach);
> -EXPORT_SYMBOL(dvb_dummy_fe_qpsk_attach);


Cheers,
Mauro