Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <877e3hfxyq.fsf@mpe.ellerman.id.au>
In-Reply-To: <877e3hfxyq.fsf@mpe.ellerman.id.au>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sat, 30 Nov 2019 14:42:45 -0800
Message-ID: <CAHk-=wj-BW=C8mFr5mWEYyjgngLoq2N6PZ-RKtiL7X-e93poHw@mail.gmail.com>
Subject: Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-1 tag
To:     Michael Ellerman <mpe@ellerman.id.au>,
        Mimi Zohar <zohar@linux.ibm.com>
Cc:     ajd@linux.ibm.com, alastair@d-silva.org,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
        asteinhauser@google.com, Bjorn Helgaas <bhelgaas@google.com>,
        Qian Cai <cai@lca.pw>, chris.packham@alliedtelesis.co.nz,
        chris.smart@humanservices.gov.au,
        Christophe Leroy <christophe.leroy@c-s.fr>, clg@kaod.org,
        cmr@informatik.wtf, David Hildenbrand <david@redhat.com>,
        debmc@linux.vnet.ibm.com,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        gwalbon@linux.ibm.com, harish@linux.ibm.com,
        hbathini@linux.ibm.com, Christoph Hellwig <hch@lst.de>,
        krzk@kernel.org, leonardo@linux.ibm.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linuxppc-dev@lists.ozlabs.org, linuxram@us.ibm.com,
        madalin.bucur@nxp.com, Mathieu Malaterre <malat@debian.org>,
        msuchanek@suse.de, Nathan Chancellor <natechancellor@gmail.com>,
        nathanl@linux.ibm.com, Nayna Jain <nayna@linux.ibm.com>,
        Nick Piggin <npiggin@gmail.com>,
        "Oliver O'Halloran" <oohall@gmail.com>, oss@buserror.net,
        ravi.bangoria@linux.ibm.com, Russell Currey <ruscur@russell.cc>,
        sbobroff@linux.ibm.com, thuth@redhat.com, tyreld@linux.ibm.com,
        vaibhav@linux.ibm.com, valentin@longchamp.me, yanaijie@huawei.com,
        YueHaibing <yuehaibing@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

[ Only tangentially related to the power parts ]

On Sat, Nov 30, 2019 at 2:41 AM Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> There's some changes in security/integrity as part of the secure boot work. They
> were all either written by or acked/reviewed by Mimi.

  -#if (defined(CONFIG_X86) && defined(CONFIG_EFI)) || defined(CONFIG_S390)
  +#if (defined(CONFIG_X86) && defined(CONFIG_EFI)) || defined(CONFIG_S390) \
  + || defined(CONFIG_PPC_SECURE_BOOT)

This clearly should be its own CONFIG variable, and be generated by
having the different architectures just select it.

IOW, IMA should probably have a

   config IMA_SECURE_BOOT

and then s390 would just do the select unconditionally, while x86 and
ppc would do

  select IMA_SECURE_BOOT if EFI

and

  select IMA_SECURE_BOOT if PPC_SECURE_BOOT

respectively.

And then we wouldn't have random architectures adding random "me me me
tooo!!!" type code.

               Linus