Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 30 Nov 2019 19:08:18 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Yannick Fertre <yannick.fertre@st.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Philippe Cornu <philippe.cornu@st.com>,
        Benjamin Gaignard <benjamin.gaignard@st.com>,
        Bastien Nocera <hadess@hadess.net>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - support gt9147 touchpanel
Message-ID: <20191201030818.GM248138@dtor-ws>
References: <1574850526-13518-1-git-send-email-yannick.fertre@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1574850526-13518-1-git-send-email-yannick.fertre@st.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 27, 2019 at 11:28:46AM +0100, Yannick Fertre wrote:
> From: Yannick Fertr? <yannick.fertre@st.com>
> 
> Add support for it by adding compatible and supported chip data
> (default settings used).
> The chip data on GT9147 is similar to GT912, like
> - config data register has 0x8047 address
> - config data register max len is 240
> - config data checksum has 8-bit

If it is compatible with gt912 then the driver does not need another
compatible in the code I think. Rob will tell more.

> 
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
>  drivers/input/touchscreen/goodix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
> index fb43aa7..b470773 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -1045,6 +1045,7 @@ static const struct of_device_id goodix_of_match[] = {
>  	{ .compatible = "goodix,gt9271" },
>  	{ .compatible = "goodix,gt928" },
>  	{ .compatible = "goodix,gt967" },
> +	{ .compatible = "goodix,gt9147",},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, goodix_of_match);
> -- 
> 2.7.4
> 

-- 
Dmitry