Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191127231926.162437-1-heidifahim@google.com> <CAMVcs3vKjd8XVku8VUq2R-OKKSq-X2L=h4niFxuoPBe_D63JAA@mail.gmail.com>
In-Reply-To: <CAMVcs3vKjd8XVku8VUq2R-OKKSq-X2L=h4niFxuoPBe_D63JAA@mail.gmail.com>
From:   SeongJae Park <sj38.park@gmail.com>
Date:   Sun, 1 Dec 2019 22:10:18 +0100
Message-ID: <CAEjAshrJy00VjDu3GY3gV6hu7J8PVcw=1jAeA_-GL02kvXTemQ@mail.gmail.com>
Subject: Re: [PATCH] kunit: testing kunit: Bug fix in test_run_timeout function
To:     Heidi Fahim <heidifahim@google.com>
Cc:     Brendan Higgins <brendanhiggins@google.com>,
        David Gow <davidgow@google.com>, Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, kunit-dev@googlegroups.com,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Nov 28, 2019 at 12:58 AM Heidi Fahim <heidifahim@google.com> wrote:
>
> On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote:
> >
> > Assert in test_run_timeout was not updated with the build_dir argument
> > and caused the following error:
> > AssertionError: Expected call: run_kernel(timeout=3453)
> > Actual call: run_kernel(build_dir=None, timeout=3453)
> >
> > Needed to update kunit_tool_test to reflect this fix
> > https://lkml.org/lkml/2019/9/6/3
>
> Wrong url, here is the correct link to the fix that caused this bug:
> https://lkml.org/lkml/2019/9/6/351

Reviewed-by: SeongJae Park <sjpark@amazon.de>


Thanks,
SeongJae Park