Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp908435ybl; Sun, 1 Dec 2019 15:50:49 -0800 (PST) X-Google-Smtp-Source: APXvYqxMcKImr373/JjSrxY2FSNkEvI3v3OQRYBXf9H4h0Wm5HgbPgUw3uXM/8+oDdE1oHOPcTLe X-Received: by 2002:a17:907:42d3:: with SMTP id ng3mr49766011ejb.9.1575244249232; Sun, 01 Dec 2019 15:50:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575244249; cv=none; d=google.com; s=arc-20160816; b=lY3Zv5ttls5drrcpL9TH8CzKxEQNCmTfLmMes8A2Hv6Hr5T1HOR0eRgrSBnA+x467R 8y41t+HTuuhtDKbVVAcU8Pue5eKxtpifxEmHrsXdGac3jT5RLg+hKLeDpszQ4j+g2eAR SWboRdV7WRGQJn5R7vPFkPk1jvWrGtyNeknzL4zhqBc2hsbUv74ARYZrCcX7Eyz0x73U u406yCO9DFUV+pZ8VvPMhBTiECW9DBul+QjrCPxrb/bQga5Y44uZmEowfQH4gHdU1x2K hUKNP2qZbsAGAvRFffgm5/70irrBU+MWrm2pnr9eWTdUCv0+MXlr2XnW9h1MiD2xWD/f +FdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LQDdCTsWHRA4ZretgJXx0msy4MDgZvvkhcgKOBqu1qQ=; b=fOQQeOw+0EpEb5LAAEGZDzkp+5Tao8dQZdfOCrr9tPUiB16PgPNoezGJJ5n1JLExzd Vu7kVSEelgRcBA95jeMjOFOJA1YhGfBi65LsrvDXmfZFpKJnyXpFPIJcCbCj2RR+FuU3 LxMCctM2UEPSq6qOTwMWhn12+kaFyu9pZpEf9+bq/ChlRm0csoG7Bp3KTwSAb2oTCSpP OrP6DiSmY6cip+LZLbdTOzNdF4x9/xIKbifeQivCDSNg7Ry5Rf0tIz3R7jBuD8E4O0sU wPPmppc+qu6l4LyquPQVSYLF4hBPun114nynePpevFPVK1SRLQorTO+0f+pEiyUHurCT k5aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=sKsz595k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pw7si1849942ejb.321.2019.12.01.15.50.24; Sun, 01 Dec 2019 15:50:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=sKsz595k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbfLAXtP (ORCPT + 99 others); Sun, 1 Dec 2019 18:49:15 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56622 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727266AbfLAXtO (ORCPT ); Sun, 1 Dec 2019 18:49:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LQDdCTsWHRA4ZretgJXx0msy4MDgZvvkhcgKOBqu1qQ=; b=sKsz595kkpRJbxYVC7pvr4NZf eG9oWOCiKP3GFwAgjCYrOQ1tts9LnfboO4de8O1lAaK6k+ei2A1Ya1kWT0DIBltJ4XbmByOuvoDVc fMTLFXuhfAgYvTp0CBwkZocAMnkQ75JoQ6lmwI3N1NGDMC5dwOKabgZE1GnHwHnaHQwDc=; Received: from fw-tnat.cambridge.arm.com ([217.140.96.140] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ibYxk-0000Ed-GX; Sun, 01 Dec 2019 23:49:12 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 36395D02F8B; Sun, 1 Dec 2019 23:49:11 +0000 (GMT) Date: Sun, 1 Dec 2019 23:49:11 +0000 From: Mark Brown To: Torsten Duwe Cc: Liam Girdwood , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] regulator: Defer init completion for a while after late_initcall Message-ID: <20191201234911.GC1998@sirena.org.uk> References: <20190904124250.25844-1-broonie@kernel.org> <20191116125233.GA5570@lst.de> <20191118124654.GD9761@sirena.org.uk> <20191118164101.GA7894@lst.de> <20191118165651.GK9761@sirena.org.uk> <20191118194012.GB7894@lst.de> <20191118202949.GD43585@sirena.org.uk> <20191130152700.GA14121@lst.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Pk6IbRAofICFmK5e" Content-Disposition: inline In-Reply-To: <20191130152700.GA14121@lst.de> X-Cookie: Cleanliness is next to impossible. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Pk6IbRAofICFmK5e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Nov 30, 2019 at 04:27:00PM +0100, Torsten Duwe wrote: > Well, actually the 4 lines above give a good hint :) of_get_regulator() > will look for "dvdd25-supply-supply". I'm fairly relieved that even you > didn't spot this right away. The fix just went to dri-devel, you're Cc'ed. > Unfortunately the documentation for this is buried in the git commit log. Glad you got to the bottom of this! Like I said in reply to your fix (which I saw first) this is covered in the DT binding documentation for the regultaor API. > For the record: I'm still convinced that the original change can uncover > bugs unexpectedly, and is not suited for -stable. Yeah, it's definitely at the upper limit of what I consider safe for stable but it seems to fit the risk profile of what stable wants to include these days and there was demand for it from people working on DT based laptops and desktops. --Pk6IbRAofICFmK5e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3kUXYACgkQJNaLcl1U h9A7Cwf+Ka4ElFEbzAcM1kQ2TqPeE4GdhgoP6Ky0e++Md4T0Eqfukz4PDkb3FnlR +6qyEXTeYDUdWTR0SS8dGzIeplhy13DNBBvKMVKZTt8FMKpdpeqYsNKISxw7kIfN HEy/CSA1B4b5E7cLJlxu+lxno4O/cT5NXwwbXWVjOnIQ68HByQJ7U3rtdbX1yIE3 0pbXlVo0VoffJbjdwuCswgoqwc8JzwN+1tZWaj8CmFGQxF3IJBGZyNqMvJuXqL5e D1joW+R1yEakuVJ7xyY4tXSMoHfaDdxlx3cF63c4i40uHmxboQMtbp4wVZkgsFOZ h16BNH+wpM6CNYcAgmz7ECnJ2dp0Vg== =lMGi -----END PGP SIGNATURE----- --Pk6IbRAofICFmK5e--