Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>, Abel Vesa <abel.vesa@nxp.com>
CC:     Shawn Guo <shawnguo@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        Jacky Bai <ping.bai@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] clk: imx: clk-pll14xx: Switch to clk_hw based API
Thread-Topic: [PATCH 1/7] clk: imx: clk-pll14xx: Switch to clk_hw based API
Thread-Index: AQHVjl59g0Rhyol1lkGW5Jui3luQOw==
Date:   Mon, 2 Dec 2019 05:07:48 +0000
Message-ID: <VI1PR04MB7023CAEB8ADA6B1CA0907A72EE430@VI1PR04MB7023.eurprd04.prod.outlook.com>
References: <1572356175-24950-1-git-send-email-peng.fan@nxp.com>
 <1572356175-24950-2-git-send-email-peng.fan@nxp.com>
 <20191202011721.GA17574@dragon>
 <AM0PR04MB4481B7D74A1861558523F21488430@AM0PR04MB4481.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a29bf61-281a-46bc-8507-08d776e59354
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2019 05:07:48.6298
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mqVqF1mJ6G1KBnafD//XAyPKPAV3g5MgpB89p7ajRl0b0OG5AgSLyPVBSdtWozzBHxAGlQcRDKRV3EC3DOhD3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5967
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2019-12-02 4:26 AM, Peng Fan wrote:=0A=
>> Subject: Re: [PATCH 1/7] clk: imx: clk-pll14xx: Switch to clk_hw based A=
PI=0A=
>> On Tue, Oct 29, 2019 at 01:40:54PM +0000, Peng Fan wrote:=0A=
>>> From: Peng Fan <peng.fan@nxp.com>=0A=
>>>=0A=
>>> Switch the imx_clk_pll14xx function to clk_hw based API, rename=0A=
>>> accordingly and add a macro for clk based legacy. This allows us to=0A=
>>> move closer to a clear split between consumer and provider clk APIs.=0A=
>>>=0A=
>>> diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h index=0A=
>>> bc5bb6ac8636..5038622f1a72 100644=0A=
>>> --- a/drivers/clk/imx/clk.h=0A=
>>> +++ b/drivers/clk/imx/clk.h=0A=
>>> @@ -97,8 +97,12 @@ extern struct imx_pll14xx_clk imx_1443x_pll;=0A=
>>> #define imx_clk_mux(name, reg, shift, width, parents, num_parents) \=0A=
>>>   	imx_clk_hw_mux(name, reg, shift, width, parents, num_parents)->clk=
=0A=
>>>=0A=
>>> -struct clk *imx_clk_pll14xx(const char *name, const char *parent_name,=
=0A=
>>> -		 void __iomem *base, const struct imx_pll14xx_clk *pll_clk);=0A=
>>> +#define imx_clk_pll14xx(name, parent_name, base, pll_clk) \=0A=
>>> +	imx_clk_hw_pll14xx(name, parent_name, base, pll_clk)->clk=0A=
>>> +=0A=
>>=0A=
>> I would suggest to use an inline function for this, which will be more r=
eadable=0A=
>> and complying to kernel coding style.=0A=
> =0A=
> ok, I'll send out v2.=0A=
=0A=
Blindly dereferencing ->clk will crash instead of propagating errors so =0A=
you might want to use the to_clk helper from here:=0A=
=0A=
https://patchwork.kernel.org/patch/11257811/=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=