Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 2 Dec 2019 07:29:34 +0000
From:   cang@codeaurora.org
To:     Avri Altman <Avri.Altman@wdc.com>
Cc:     asutoshd@codeaurora.org, nguyenb@codeaurora.org,
        rnayak@codeaurora.org, linux-scsi@vger.kernel.org,
        kernel-team@android.com, saravanak@google.com, salyzyn@google.com,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Pedro Sousa <pedrom.sousa@synopsys.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bean Huo <beanhuo@micron.com>,
        Evan Green <evgreen@chromium.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: ufs: Give an unique ID to each ufs-bsg
In-Reply-To: <MN2PR04MB699154831CDD5847C4674632FC430@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <0101016ec4a25faa-77e03f78-006b-4b7c-bf8a-d56378f4b1be-000000@us-west-2.amazonses.com>
 <MN2PR04MB699154831CDD5847C4674632FC430@MN2PR04MB6991.namprd04.prod.outlook.com>
Message-ID: <0101016ec583b87a-6f10681d-2567-4ae8-bf1b-d78404ad26fb-000000@us-west-2.amazonses.com>
User-Agent: Roundcube Webmail/1.3.9
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-12-02 15:23, Avri Altman wrote:
> Hi,
>> 
>> Considering there can be multiple UFS hosts in SoC, give each ufs-bsg 
>> an unique
>> ID by appending the scsi host number to its device name.
> Can you refer me to such a design?
> 
> Thanks,
> Avri
> 

Consider a platform which has an embedded UFS device and supports a UFS 
card meanwhile.
This conbination is very popular nowadays. BTW, 845 started supporting 
two UFS hosts 3 years ago.

Thanks,

Can Guo

>> 
>> Signed-off-by: Can Guo <cang@codeaurora.org>
>> 
>> diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c 
>> index
>> dc2f6d2..3ef5b78 100644
>> --- a/drivers/scsi/ufs/ufs_bsg.c
>> +++ b/drivers/scsi/ufs/ufs_bsg.c
>> @@ -202,7 +202,7 @@ int ufs_bsg_probe(struct ufs_hba *hba)
>>         bsg_dev->parent = get_device(parent);
>>         bsg_dev->release = ufs_bsg_node_release;
>> 
>> -       dev_set_name(bsg_dev, "ufs-bsg");
>> +       dev_set_name(bsg_dev, "ufs-bsg%d", shost->host_no);
>> 
>>         ret = device_add(bsg_dev);
>>         if (ret)
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project