Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp39789ybl; Mon, 2 Dec 2019 07:17:53 -0800 (PST) X-Google-Smtp-Source: APXvYqyWKvGwyG1k/16Z11iu37tOg/PbGgASrEKQm0QNLQUtS26CZF+//sMiVAA6bRujSMsUjM+R X-Received: by 2002:aa7:d902:: with SMTP id a2mr8602418edr.90.1575299873284; Mon, 02 Dec 2019 07:17:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575299873; cv=none; d=google.com; s=arc-20160816; b=cvYmLHdXNTyKXYLV2qvhLL+PIBJnHSjnMCeUhsbZodgzE5OBYWg3ot8Bmlfjkn1c/l JrpqyPov5KO8sY+k6Sy1EHSMpm1qbaOccCR7x38pimeBkzBduuAF/AKB+J/4463gxVYG 3/ngAzlTg0cIquP5W91mqyThSsar4OlcswyV6Ny7NfRvmNPcwtLKu2bUHzWXCe5Ac4xW FHiCZBtqU86d69pKmFRC7ARVj+kiz3ld8ix/eVSxfLz07LkrLmzHsFp9DxlZEsLLh1/S XqqhYScW+/ttGrSIHKf+REmspnawjppqSjZxtfB3+S+ZXtIWwzXYgsFF/9+P4W3e92z1 5Gnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=79FGL1bQb1IrNZ/STkWQkqbSilN1R4p14aXmJkyqzE4=; b=VN8UeePUjXlwIycu1XoStFMNxCvcaTy3oRflgj6N50ssbl6xaj052L8q01cLocu0iv K21MU06CzRhisEHNOgWd+pKyZbBnvgvj3wnIBF4iDNODuEkTKBrpqPqIrSCPMh01JZ/X BAOGIfWIwBGlo4TO1OVnQ2c0haxxc5hTqMfE+R30Pcs1XDVNfqJd2ge1zm33Nimvhhn0 ZDrTWvF5jHEZAz/JFIK74rOmKbTzGAIR97PoqJCraRZLReqWatJ72DEyDiKSWwBskwF+ pKxqMafzsAIl1jpCDlt2tWxDNDX4nZhihlKi+SxTHPuZ2KWiseRCYhM6z/1XC339RBfk mQvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ss7si9406886ejb.71.2019.12.02.07.17.28; Mon, 02 Dec 2019 07:17:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbfLBPMV (ORCPT + 99 others); Mon, 2 Dec 2019 10:12:21 -0500 Received: from gentwo.org ([3.19.106.255]:39610 "EHLO gentwo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727401AbfLBPMV (ORCPT ); Mon, 2 Dec 2019 10:12:21 -0500 Received: by gentwo.org (Postfix, from userid 1002) id 3EC1F3EF27; Mon, 2 Dec 2019 15:12:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 3BED73EC03; Mon, 2 Dec 2019 15:12:20 +0000 (UTC) Date: Mon, 2 Dec 2019 15:12:20 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Andrew Morton cc: Yu Zhao , Pekka Enberg , David Rientjes , Joonsoo Kim , "Kirill A . Shutemov" , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" Subject: Re: [FIX] slub: Remove kmalloc under list_lock from list_slab_objects() V2 In-Reply-To: <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> Message-ID: References: <20190914000743.182739-1-yuzhao@google.com> <20191108193958.205102-1-yuzhao@google.com> <20191108193958.205102-2-yuzhao@google.com> <20191109230147.GA75074@google.com> <20191110184721.GA171640@google.com> <20191130150908.06b2646edfa7bdc12a943c25@linux-foundation.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 30 Nov 2019, Andrew Morton wrote: > > Perform the allocation in free_partial() before the list_lock is taken. > > No response here? It looks a lot simpler than the originally proposed > patch? Yup. I prefer this one but its my own patch so I cannot Ack this.