Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <837a221f0fc89b9ef6d3fbd2ceae479a5c98818a.camel@redhat.com>
Subject: Re: [PATCH] drm/dp_mst: Fix build on systems with
 STACKTRACE_SUPPORT=n
From:   Lyude Paul <lyude@redhat.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Mon, 02 Dec 2019 13:49:47 -0500
In-Reply-To: <CAMuHMdUz7gewcFPE=cnVENGdwVp6AZD7U4y1PtwXTAmoGmvGUg@mail.gmail.com>
References: <20191202133650.11964-1-linux@roeck-us.net>
         <CAMuHMdUz7gewcFPE=cnVENGdwVp6AZD7U4y1PtwXTAmoGmvGUg@mail.gmail.com>
Organization: Red Hat
User-Agent: Evolution 3.34.2 (3.34.2-1.fc31)
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Lyude Paul <lyude@redhat.com>

I'll go ahead and push this to drm-misc-next, thanks!

On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > On systems with STACKTRACE_SUPPORT=n, we get:
> > 
> > WARNING: unmet direct dependencies detected for STACKTRACE
> >   Depends on [n]: STACKTRACE_SUPPORT
> >   Selected by [y]:
> >   - STACKDEPOT [=y]
> > 
> > and build errors such as:
> > 
> > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > (.text+0x11c): undefined reference to `save_stack_trace'
> > 
> > Add the missing deendency on STACKTRACE_SUPPORT.
> > 
> > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for
> > debugging")
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
-- 
Cheers,
	Lyude Paul