Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp343575ybl; Mon, 2 Dec 2019 11:35:53 -0800 (PST) X-Google-Smtp-Source: APXvYqx55E9f3G3UyuYVdldZ7FYwkMHGkwKtSZOxJNCELA9SomYjlBq4Ei91WOk+yMx/FMjyBOPQ X-Received: by 2002:a17:906:c355:: with SMTP id ci21mr972181ejb.284.1575315353036; Mon, 02 Dec 2019 11:35:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575315353; cv=none; d=google.com; s=arc-20160816; b=IPGDu0Y4J7CN1Wmtr+l50Ce02Pv4uQ5pT4xGhwGdv1lDbFJsdIqoOQOz5Nq2tFLo4w wY8awwbGCInN0Hr4oSXr5XUgqLQDqKev3jakgYY+KRT3xxpskVKdoIRX8IbhMnndkBRo 6lpK8x4O34oo9CjiKEu6+V9lUshu5cT3jEid18KoBJIIJwAVoZIptuB55nA1Rj52RT33 j4Nh67ujG16XnFYMlArpm4SU2iTn9GvhqiTH83+UQ9/9leqtRnmNSDITqYhAf6e9DWY4 apJ6QtJ+bvO7hy2DVqpiU6g6UkPkxD4v2COP20qi5ojGZwVLu4HKdFTYSHvJ9mPzj8p4 K9kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EnqLbLR1cVsQSuDVKZpkcSUVWl+6KkbtHgbehwBYcX4=; b=ZXWvA8HtemX7QYKjiFMhSmTyaQ2H/DG2pjcmlS0tImTTXPy2QlJKP9vqVvc+CueokB ZvK4dRXfItkTF+HtBS/B5DseunOicrqSqb2IQTLrgYWdTOtbgkVNpfxHnUx9/3pR4ZNy lXnjii6KT9skcv3b1CAmYeuHc9HIHg9lNvvpBH7XoMLZ5tWWHmcdZdV8oBrZYvgVA5Vc os4ShPnn+zLjPdc8I7AnFGwda6QRLjLs0VRR+WofCBueGU2H9pOy4Kd961Ga42VawgqG QIdA71WLXpmIHZTKEBN+QQai1Ndb6sJY3QirL78p1UiM6jX2s/Hl5kAB0UHLzekBwmg2 TyXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id da27si361056edb.256.2019.12.02.11.35.22; Mon, 02 Dec 2019 11:35:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728167AbfLBTdo (ORCPT + 99 others); Mon, 2 Dec 2019 14:33:44 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41244 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728128AbfLBTdo (ORCPT ); Mon, 2 Dec 2019 14:33:44 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 324A428FF58 From: Adrian Ratiu To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-rockchip@lists.infradead.org Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-imx@nxp.com Subject: [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver Date: Mon, 2 Dec 2019 21:33:55 +0200 Message-Id: <20191202193359.703709-1-adrian.ratiu@collabora.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Having a generic Synopsis DesignWare MIPI-DSI host controller bridge driver is a very good idea, however the current implementation has hardcoded quite a lot of the register layouts used by the two supported SoC vendors, STM and Rockchip, which use IP cores v1.30 and v1.31. This makes it hard to support other SoC vendors like the FSL/NXP i.MX 6 which use older v1.01 cores or future versions because, based on history, layout changes should also be expected in new DSI versions / SoCs. This patch series converts the bridge and platform drivers to access registers via generic regmap APIs and allows each platform driver to configure its register layout via struct reg_fields, then adds support for the host controller found on i.MX 6. I only have i.MX hardware with MIPI-DSI panel and relevant documentation available for testing so I'll really appreciate it if someone could test the series on Rockchip and STM... eyeballing register fields could only get me so far, so sorry in advance for any breakage! Many thanks to Boris Brezillon for suggesting the regmap solution and to Liu Ying for doing the initial i.MX platform driver implementation. This series applies on top of latest linux-next tree, next-20191202. v3 -> v4: * Added commmit message to dt-binding patch (Neil) * Converted the dt-binding to yaml dt-schema format (Neil) * Small DT node + driver fixes (Rob) * Renamed platform driver to reflect it's only for i.MX v6 (Fabio) * Added small panel example to the host controller DT binding v2 -> v3: * Added const declarations to dw-mipi-dsi.c structs (Emil) * Fixed Reviewed-by tags and cc'd some more relevant ML (Emil) v1 -> v2: * Moved register definitions & regmap initialization into bridge module. Platform drivers get the regmap via plat_data after calling the bridge probe (Emil). Adrian Ratiu (4): drm: bridge: dw_mipi_dsi: access registers via a regmap drm: bridge: dw_mipi_dsi: abstract register access using reg_fields drm: imx: Add i.MX 6 MIPI DSI host driver dt-bindings: display: add i.MX6 MIPI DSI host controller doc .../display/imx/fsl,mipi-dsi-imx6.yaml | 136 ++++ drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 699 +++++++++++++----- drivers/gpu/drm/imx/Kconfig | 7 + drivers/gpu/drm/imx/Makefile | 1 + drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 378 ++++++++++ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 +- include/drm/bridge/dw_mipi_dsi.h | 2 +- 8 files changed, 1067 insertions(+), 207 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c -- 2.24.0