Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp568467ybl; Mon, 2 Dec 2019 15:10:09 -0800 (PST) X-Google-Smtp-Source: APXvYqzc2rga3VdOteMukE3zmDD5S2wddNW6W8m6IylRgWU+R5RG5BaF14Ix3BUkXUM1ekumRtHb X-Received: by 2002:a54:480f:: with SMTP id j15mr1256207oij.160.1575328209327; Mon, 02 Dec 2019 15:10:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575328209; cv=none; d=google.com; s=arc-20160816; b=p3KslXDGhbrzffzDa48+MNFmapDwFHiHwsTf/xqai4XV/Qj8OYaG2B40IRWI7lxLOY dADoczWFohsI3eLPHjwwhaXIqaobjE5m7I0VyM8X7xSQG5z7ux0ZMoM9i5JS+XivTrTy p0gsmH/LgMXthrBIkVxVi4U8JRQezJs6rHcaPk1rLsU/Od2oYQQp03IRvYca5DjOFINm W9oWhJY1cueK36FYDouGlPaXXnNG/tk1Z7DeMpRgaRz8M1VAv3HIVMrNwDq5IJtbNDUA TGEAt1zZg28FdFNPogn5a4JVYnfbRPpgpjl+1+JVXyjHWe1rJ+Tpl68JwJ2un5eG/EyQ Re4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=TE/uDph1bKu3CvCW5tz9WvzAwR2puavmLOIqAJLk25w=; b=ks/TL10i2OreUf+npB5ihLVFdYp1SEpJ7UMOlU6Vvc9ny8NbUPVBUJu0b4Qpz3Xa7I EpV6f5GYUG8Nkf1/Wmxzvz9g3vVFoFgUmiI5XKzdxfikY+BWCNIWS7OydyHQMcFzX3LW wXVPR6u7EU+7kkI58JyG7jFuEg/32WSO3blMfUH+rFUmLprc7BrsXBkWwUG5AKWv8fPu Xg8otZj9UpAyS6IK01hisJIAjcGU6hVCCbL/4FiunEmJUOcIcZTJYZSfbXkUR9/z512g nIVS+C2QiW6UGouXvvWeTLw2PX6oETHXW59N4UWA1C+kQM7SI9S6WWmlveAxh3BQQsHY WvfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v141si349004oif.161.2019.12.02.15.09.56; Mon, 02 Dec 2019 15:10:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfLBXJJ (ORCPT + 99 others); Mon, 2 Dec 2019 18:09:09 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42308 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLBXJJ (ORCPT ); Mon, 2 Dec 2019 18:09:09 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A69F014DAF87D; Mon, 2 Dec 2019 15:09:08 -0800 (PST) Date: Mon, 02 Dec 2019 15:09:08 -0800 (PST) Message-Id: <20191202.150908.2038427090014426460.davem@davemloft.net> To: leoyang.li@nxp.com Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oss@buserror.net, timur@kernel.org, netdev@vger.kernel.org, linux@rasmusvillemoes.dk, qiang.zhao@nxp.com, christophe.leroy@c-s.fr Subject: Re: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE() From: David Miller In-Reply-To: References: <20191128145554.1297-1-linux@rasmusvillemoes.dk> <20191128145554.1297-45-linux@rasmusvillemoes.dk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Dec 2019 15:09:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Leo Li Date: Mon, 2 Dec 2019 22:51:57 +0000 > > >> -----Original Message----- >> From: Rasmus Villemoes >> Sent: Thursday, November 28, 2019 8:56 AM >> To: Qiang Zhao ; Leo Li ; >> Christophe Leroy >> Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; Scott Wood ; Timur Tabi >> ; Rasmus Villemoes ; >> netdev@vger.kernel.org >> Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of >> IS_ERR_VALUE() > > Hi David, > > Would you help to review patch 44-47 in the series? If it is fine with you, I can take these 4 patches with the whole series though soc tree to enable the QE drivers on ARM and PPC64 with your ACK. Please take it via your tree, that's fine.