Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191202211844.19629-1-enric.balletbo@collabora.com> <20191202211844.19629-2-enric.balletbo@collabora.com>
In-Reply-To: <20191202211844.19629-2-enric.balletbo@collabora.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Tue, 3 Dec 2019 10:15:56 +0800
Message-ID: <CAJKOXPdJSLoEX7+34imGuZ6CEE5unajL=byb+h9VT3Bejc353Q@mail.gmail.com>
Subject: Re: [PATCH 1/2] x86_64_defconfig: Normalize x86_64 defconfig
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>,
        groeck@chromium.org, bleung@chromium.org, dtor@chromium.org,
        fabien.lahoudere@collabora.com, guillaume.tucker@collabora.com,
        "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "Ahmed S. Darwish" <darwish.07@gmail.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Alexey Brodkin <alexey.brodkin@synopsys.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 3 Dec 2019 at 05:18, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> make savedefconfig result in some difference, lets normalize the
> defconfig
>

No, for two reasons:
1. If running savedefconfig at all, split reordering items from
removal of non needed options. This way we can see exactly what is
being removed. This patch moves things around so it is not possible to
understand what exactly you're doing here...
2. Do not remove options just because other select them in a blind way
- via savedefconfig. As it turns out, some developers have different
view on dependencies and they expect that defconfig *explicitly* pulls
out necessary functions. IOW, they can safely remove any visible
symbol dependency assuming that defconfigs are selecting this removed
symbol explicitly. See:
https://patchwork.kernel.org/patch/11260361/
(commit which removed DEBUG_FS - Marek Szyprowski will bring it back,
I think, and Steven Rostedt answer)

Best regards,
Krzysztof

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
>  arch/x86/configs/x86_64_defconfig | 90 +++++++++++--------------------
>  1 file changed, 30 insertions(+), 60 deletions(-)
>