Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp925519ybl; Mon, 2 Dec 2019 21:24:41 -0800 (PST) X-Google-Smtp-Source: APXvYqyRWi1r5+WtetAQhpKHbj69X4RCBPgl0ejbTfp0UmJ/29wFmDzGzGxrw1q27m56hZncAh00 X-Received: by 2002:aca:5490:: with SMTP id i138mr2287272oib.69.1575350681465; Mon, 02 Dec 2019 21:24:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575350681; cv=none; d=google.com; s=arc-20160816; b=Xjy0YoaYNjpoBpRaCzu/OkLq3ha1pa8ymo2MHif9EIxDgTCO0WfNISDEVRgPraq5d5 GAz8YmFzqouVPrJDY3+0NO+3ik43tJFI9VoCSJqO49LZQqw4FlxlJrAJ1AZ0a/robjL0 020BMVdqpvDhSiQOebGuojwZ4TIGsNuuQBDVq6uH6Yb3mDawTlIzHFHE78rHoDDsM+W2 FJlf1VLjB1v7Mc9y3vZWRemGtNO7egNOPGa7Y0S7f93U7whi72ogsDxF4/M+bGGozJ72 Z3Q9YIYVgUlYR089rulzE/IfyCPcIgyRL0znBYlTnRv5T0VEpZUGR7t8qU8n/+pcmAU4 +G2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=jCnbshc6gwC9Lz7KrpZNRQtAnW1kUNCWIyQg9GLVi8g=; b=D9LcHtHyDIk6OWLxivdU24jGvUtAns52LyEJ1CbSdtpK61pRiYdUNhgBiq9VdgvKF4 ymv//XWfab7KyyPlWnfMkVeozFRor5hsBp3LQf9nH1WTEjcrpG0E81NSPn3Ugoi0kqXw Wpa5ua2YF00EBX9t5JMkh0F+ihEBQ/lomyRvucVHarh4+LGehPMFy7a2YD/6+20OGNAY SpWxpodjngc0U+vjISftFONV1EpnzzzfjqmG7yHV/ifeSY1UJZrgx3zs+W2gMlkYa9mY uiRNkMeSc0jRMLtb7q07SQxinl36BiY31YE4vmC9UeVS+Ys1OEghluZ3IaeVQwA/tqmO qd5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OAsl82Oz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d67si802752oig.112.2019.12.02.21.24.29; Mon, 02 Dec 2019 21:24:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=OAsl82Oz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbfLCFXu (ORCPT + 99 others); Tue, 3 Dec 2019 00:23:50 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:39518 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbfLCFXt (ORCPT ); Tue, 3 Dec 2019 00:23:49 -0500 Received: by mail-pg1-f196.google.com with SMTP id b137so1119055pga.6 for ; Mon, 02 Dec 2019 21:23:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=jCnbshc6gwC9Lz7KrpZNRQtAnW1kUNCWIyQg9GLVi8g=; b=OAsl82OzpSmTAhx0IKBHZKzsbwj/Z21pQqt+a4HJyo/HZFuWYG9T4G04aGZRPpDabt +EEHPB/YWvTT1xhURL6ea6bIVo+plxAXVlqEIbZR06NB9Sh2Wq9iHh9wwy3WlzDu+HTw uFjhM186omJhFZh1qp3s9THXC88LAjvd7sLJd4FM4Em2wk/cI/SNy0/OyPbVGovb4Q69 GJEWRkCGmkBjBwaoIDjgfYabTSvOlon7UJgG4w9P5zJVxHSdgpBOicTCBHw2ZvQPh4M2 bsPl8engt05uk4jXYpdp992AtjFowJHclWUqfPjTgcuzgsI2DEJPaghc7lXxnn+s0Qvw e2qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=jCnbshc6gwC9Lz7KrpZNRQtAnW1kUNCWIyQg9GLVi8g=; b=Kd5GdiEUCb7saxzYW1acOdpFw+JOHvDWum0Jt3XDlaV+rKfl0Y/gFUz59gIJXPE2DN Dxl31WQnc2EZAjiXdXhMbmL6d0kx0G5ohg/TrjdEw9vg1Wna/hDWnguA6Hen6Fx0ShlU pdFNYEI1IAYZU4gWedxuiAoRss1Chs+K2RpXw3PKOn+qpy9IJdSDkzoRtNZRPV2t0kjk O6lKSEEl3anOwHKzNYVTRul59F+qIo73AcFtt0VkT+M5htlFavw88vkJcAkfxCWljGWh lcbCNR/VV75EE4E4988BA1s4YIG20U7QzW5kqJktmyQ1r54xYhZNXo5FCp5oZ2SdTnka nuTQ== X-Gm-Message-State: APjAAAWDYmaxihAcJV/Rppia+rha3BbGlAvc22a9pLYf914AtnR1YDEP kqZXMlQi6FQqnvBmof0k26vZzDSPuHo8Dw== X-Received: by 2002:a63:6787:: with SMTP id b129mr3465932pgc.103.1575350627967; Mon, 02 Dec 2019 21:23:47 -0800 (PST) Received: from localhost ([14.96.109.134]) by smtp.gmail.com with ESMTPSA id z30sm1426685pff.131.2019.12.02.21.23.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Dec 2019 21:23:47 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross Cc: Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org Subject: [PATCH v2 3/9] drivers: thermal: tsens: use simpler variables Date: Tue, 3 Dec 2019 10:53:24 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already dereference the sensor and save it into a variable. Use the variable directly to make the code easier to read. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index c2df30a08b9e4..1cbc5a6e5b4fd 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, UPPER, disable); if (d.up_thresh > temp) { dev_dbg(priv->dev, "[%u] %s: re-arm upper\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, UPPER, enable); } else { trigger = true; @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, LOWER, disable); if (d.low_thresh < temp) { dev_dbg(priv->dev, "[%u] %s: re-arm low\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, LOWER, enable); } else { trigger = true; @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) if (trigger) { dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n", hw_id, __func__, temp); - thermal_zone_device_update(priv->sensor[i].tzd, + thermal_zone_device_update(s->tzd, THERMAL_EVENT_UNSPECIFIED); } else { dev_dbg(priv->dev, "[%u] %s: no violation: %d\n", @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high) spin_unlock_irqrestore(&priv->ul_lock, flags); dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n", - s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); + hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); return 0; } -- 2.17.1