Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp925545ybl; Mon, 2 Dec 2019 21:24:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyL57UCSopvhPNHBJ7OTTzrellXSy5fIzMnVxDckjyqGIXdMd+QC6eT5kqBKTk/wOy5toZo X-Received: by 2002:aca:f144:: with SMTP id p65mr2280248oih.131.1575350683824; Mon, 02 Dec 2019 21:24:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575350683; cv=none; d=google.com; s=arc-20160816; b=g3tOYJONAdQfDvcn1QoAHSVotdpTdRidOzwtreKfZSqesYqKs5r5aLCdRfA2An+e80 +XgS4i4UV3Y1Wq36aLAKXdxDC6LMIoUnvTBKiVWLxp0v9Ro8jkhTrpDAsn6l832mjzcx NBoHpUyx1FB7cVM4ikVH8qkMRIMyK8yTnKvTVz2+oc04XiXt2pmky3SL59IIoQA4YZ1F 5WULlKE//q/3FWobkoNWRdNRDOevVsKICaESwGw64jgArJZXTI8hirYWY3xUQ17lEHXj EG8OW/sR8laI4hmSf4h3s9NY6fXwZ+t7XYGKwSMUGq4NsUF9/3eOjvFPwEIbozPsObg6 u3WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=dPgz2TLGaXm8AZ5IU/e4WWLoSFiMiQO40kFKZ/olifE=; b=Tqff0Yn++RK2FCsqAT5IC4zNQNc9LRVbM8PkdCaQtxNZTXDZCF60LRBKALqnm7w8Li SvY+z8QeRcit0NNcQgs8IVxHWwPDVF1Bx2QDVBVVOmw56Hcm036uUpJ4znc5iDe1G8dZ NVvyE45DimYGfvD07cB/7cxM2RV6cfEekALxhPPJ/ZWt1nHMQIe/3PAGlhgKvKizjfZI G1Z+ViqC8l8AR2OonTvMRxCqkQButhPyBrsLxcwGi4y5EDmPXQjpLOJSdczw/sMVBj3l hk3X3xmW/1hLvwA0UxbauThDujuiijC7+rYVoj54NDALIJa5M4RpL/vp1uKs58waA4/M 26CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="RlW/Wke8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f23si645776oto.205.2019.12.02.21.24.32; Mon, 02 Dec 2019 21:24:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="RlW/Wke8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727131AbfLCFXy (ORCPT + 99 others); Tue, 3 Dec 2019 00:23:54 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:34639 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727059AbfLCFXx (ORCPT ); Tue, 3 Dec 2019 00:23:53 -0500 Received: by mail-pg1-f196.google.com with SMTP id r11so1130498pgf.1 for ; Mon, 02 Dec 2019 21:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=dPgz2TLGaXm8AZ5IU/e4WWLoSFiMiQO40kFKZ/olifE=; b=RlW/Wke8DNfq5+TindW3a7DNLR09DVaesqF1xwIrlU7rF0EUhASXBKcdEv9gChCMzZ XYOazRvnQp5BEKikwNaDgdpOXqIZGn3q6lanaKG0VVk49ZOEbdZeDfoipfCq5ELIMQj1 l+zmNmnCi30CeiFDdCpZFNLjVkhEZwrSF5TTeCJsP86nGSsRgQFi17NQBUwsLWN3lPG4 XYVktpX4JahsUhum0NFi75QXwlGDhJzOsawFqpujLOvLJB5PyoyN6ODaS4V7T8uSFZTh //laIC4A0qj7KfbwbD+XBv++Ues5+BnYRmsODvf/kbCaKBOLc+fIzic6drSvmxvM7SDf z2yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=dPgz2TLGaXm8AZ5IU/e4WWLoSFiMiQO40kFKZ/olifE=; b=Da5i5HgyO1q0yr6pEZJBzlzMIDMiocfx48/x5lOlqkw3/9UIKTNsMk4hY9BgH+9mL+ uhZgVpZL+E74VcZHN4o1Q+BxEdev4tYd+pfiI+x5pMxXyp7zbhBusKAQl5NOt48on8hJ /YFmjS0FTyLpgc0WxkBGdbQP8E+7+aCguA2GmJ0CU5ae5PTnJmMON85wcdSxFDLVEAoc or7JuanEBzAkV3Lbiz7swYa7tcd9Fskicz+WJ9fGHyILpvg6v5eG2WHDtE+VJQg94q90 0THOULkhmiWDvEz2/Bxf4iWWM692r78VXVLZcBQTrBdDDGyQmaFQm+59riaAz5BQBn0D qKsw== X-Gm-Message-State: APjAAAXDr7IJF6hFNQVplQmPfaAvl/QVF0i4D9vK5qZCrp4pKjdEeCKA jxNLrIOI3LauDbADUNitO6y2MJ8apxcXeg== X-Received: by 2002:a63:f006:: with SMTP id k6mr3420716pgh.380.1575350631471; Mon, 02 Dec 2019 21:23:51 -0800 (PST) Received: from localhost ([14.96.109.134]) by smtp.gmail.com with ESMTPSA id f10sm1388888pfd.28.2019.12.02.21.23.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Dec 2019 21:23:51 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross Cc: Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org Subject: [PATCH v2 4/9] drivers: thermal: tsens: Release device in success path Date: Tue, 3 Dec 2019 10:53:25 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't currently call put_device in case of successfully initialising the device. Allow control to fall thru so we can use same code to put_device and return error. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens-common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index 1cbc5a6e5b4fd..e84e94a6f1a73 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -687,8 +687,6 @@ int __init init_common(struct tsens_priv *priv) tsens_enable_irq(priv); tsens_debug_init(op); - return 0; - err_put_device: put_device(&op->dev); return ret; -- 2.17.1