Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1575242724-4937-1-git-send-email-sj38.park@gmail.com>
 <20191203070025.GA4206@google.com> <CAEjAshraUy20gEEaff69=b11DhB7zbz8WHT=6wOuw6C2FyJwYA@mail.gmail.com>
In-Reply-To: <CAEjAshraUy20gEEaff69=b11DhB7zbz8WHT=6wOuw6C2FyJwYA@mail.gmail.com>
From:   SeongJae Park <sj38.park@gmail.com>
Date:   Tue, 3 Dec 2019 09:25:57 +0100
Message-ID: <CAEjAsho98ER1RQ6=++ECmoCJxw2mMrGqV4jAgW5wgfb8eEM9eQ@mail.gmail.com>
Subject: Re: [PATCH 0/6] Fix nits in the kunit
To:     Brendan Higgins <brendanhiggins@google.com>
Cc:     Shuah Khan <shuah@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        KUnit Development <kunit-dev@googlegroups.com>,
        linux-doc <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        SeongJae Park <sjpark@amazon.de>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

You're right, the error was due to the assumption of the existence of the
build_dir.  The "kunit: Create default config in '--build_dir'" patch made the
bug.  I fixed it in the second version patchset[1].

[1] https://lore.kernel.org/linux-doc/1575361141-6806-1-git-send-email-sj38.park@gmail.com/


Thanks,
SeongJae Park

On Tue, Dec 3, 2019 at 8:10 AM SeongJae Park <sj38.park@gmail.com> wrote:
>
> On Tue, Dec 3, 2019 at 8:00 AM Brendan Higgins
> <brendanhiggins@google.com> wrote:
> >
> > On Mon, Dec 02, 2019 at 08:25:18AM +0900, SeongJae Park wrote:
> > > From: SeongJae Park <sjpark@amazon.de>
> > >
> > > This patchset contains trivial fixes for the kunit documentations and the
> > > wrapper python scripts.
> > >
> > > SeongJae Park (6):
> > >   docs/kunit/start: Use in-tree 'kunit_defconfig'
> > >   docs/kunit/start: Skip wrapper run command
> > >   kunit: Remove duplicated defconfig creation
> > >   kunit: Create default config in 'build_dir'
> > >   kunit: Place 'test.log' under the 'build_dir'
> > >   kunit: Rename 'kunitconfig' to '.kunitconfig'
> > >
> > >  Documentation/dev-tools/kunit/start.rst | 19 +++++--------------
> > >  tools/testing/kunit/kunit.py            | 10 ++++++----
> > >  tools/testing/kunit/kunit_kernel.py     |  6 +++---
> > >  3 files changed, 14 insertions(+), 21 deletions(-)
> >
> > I applied your patchset to torvalds/master, ran the command:
> >
> > tools/testing/kunit/kunit.py run --timeout=60 --jobs=8 --defconfig --build_dir=.kunit
> >
> > and got the error:
> >
> > Traceback (most recent call last):
> >   File "tools/testing/kunit/kunit.py", line 140, in <module>
> >     main(sys.argv[1:])
> >   File "tools/testing/kunit/kunit.py", line 123, in main
> >     create_default_kunitconfig()
> >   File "tools/testing/kunit/kunit.py", line 36, in create_default_kunitconfig
> >     kunit_kernel.KUNITCONFIG_PATH)
> >   File "/usr/lib/python3.7/shutil.py", line 121, in copyfile
> >     with open(dst, 'wb') as fdst:
> > FileNotFoundError: [Errno 2] No such file or directory: '.kunit/.kunitconfig'
> >
> > It seems that it expects the build_dir to already exist; however, I
> > don't think this is clear from the error message. Would you mind
> > addressing that here?
>
> Thank you for sharing this.  I will take a look!
>
>
> Thanks,
> SeongJae Park
> >
> > Cheers!