Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Dec 2019 09:41:34 +0100
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     Naga Sureshkumar Relli <nagasure@xilinx.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        Michal Simek <michals@xilinx.com>,
        "siva.durga.paladugu@xililnx.com" <siva.durga.paladugu@xililnx.com>
Subject: Re: ubifs mount failure
Message-ID: <20191203084134.tgzir4mtekpm5xbs@pengutronix.de>
References: <MN2PR02MB5727000CBE70BAF31F60FEE4AF420@MN2PR02MB5727.namprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <MN2PR02MB5727000CBE70BAF31F60FEE4AF420@MN2PR02MB5727.namprd02.prod.outlook.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Tue, Dec 03, 2019 at 04:52:32AM +0000, Naga Sureshkumar Relli wrote:
>    Hi,
> 
>     
> 
>    We have upgraded our Linux kernel to 5.4 from 4.19.
> 
>    And I tried mounting ubifs using this kernel on NAND partition with below
>    command and saw that
> 
>    There is an issue with memory allocation.
> 
>    #mount -t ubifs ubi0:data /mnt/
> 
>    mount: mounting ubi0:data on /mnt/ failed: Cannot allocate memory
> 
>     
> 
>    I saw that there is a commit on fs/ubifs/sb.c, where it is allocating all
>    the required memories at one shot.
> 
>    [1]https://lkml.org/lkml/2018/9/7/724
> 
>    By reverting the above patch, I am able to mount successfully the ubifs.
> 
>    By reverting this patch, we are allocating, writing and freeing in a
>    manner such that, we don’t see memory allocation issues.

Sorry, I can't see how this patch causes failing memory allocations. And
no, this is not expected. Could you sprinkle some printks and track down
where it fails? Is it the obvious place here:

	if (!sup || !mst || !idx || !ino || !cs) {
		err = -ENOMEM;
		goto out;
	}

If yes, which allocation fails and how much memory did we try to allocate?
If no, where does it fail? Also, where are you using UBIFS. Is it NAND flash
or NOR flash?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |