Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Dec 2019 10:33:34 +0100
From:   Daniel Vetter <daniel@ffwll.ch>
To:     Lyude Paul <lyude@redhat.com>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/dp_mst: Fix build on systems with
 STACKTRACE_SUPPORT=n
Message-ID: <20191203093334.GB624164@phenom.ffwll.local>
Mail-Followup-To: Lyude Paul <lyude@redhat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>, Sean Paul <sean@poorly.run>,
        David Airlie <airlied@linux.ie>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20191202133650.11964-1-linux@roeck-us.net>
 <CAMuHMdUz7gewcFPE=cnVENGdwVp6AZD7U4y1PtwXTAmoGmvGUg@mail.gmail.com>
 <837a221f0fc89b9ef6d3fbd2ceae479a5c98818a.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <837a221f0fc89b9ef6d3fbd2ceae479a5c98818a.camel@redhat.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 02, 2019 at 01:49:47PM -0500, Lyude Paul wrote:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> 
> I'll go ahead and push this to drm-misc-next, thanks!

drm-misc-next-fixes since it's in the merge window. drm-misc-next is for
5.6 already.
-Daniel

> 
> On Mon, 2019-12-02 at 16:20 +0100, Geert Uytterhoeven wrote:
> > On Mon, Dec 2, 2019 at 2:41 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > On systems with STACKTRACE_SUPPORT=n, we get:
> > > 
> > > WARNING: unmet direct dependencies detected for STACKTRACE
> > >   Depends on [n]: STACKTRACE_SUPPORT
> > >   Selected by [y]:
> > >   - STACKDEPOT [=y]
> > > 
> > > and build errors such as:
> > > 
> > > m68k-linux-ld: kernel/stacktrace.o: in function `stack_trace_save':
> > > (.text+0x11c): undefined reference to `save_stack_trace'
> > > 
> > > Add the missing deendency on STACKTRACE_SUPPORT.
> > > 
> > > Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for
> > > debugging")
> > > Cc: Lyude Paul <lyude@redhat.com>
> > > Cc: Sean Paul <sean@poorly.run>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > 
> > Gr{oetje,eeting}s,
> > 
> >                         Geert
> > 
> -- 
> Cheers,
> 	Lyude Paul
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch