Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1262127ybl; Tue, 3 Dec 2019 04:29:01 -0800 (PST) X-Google-Smtp-Source: APXvYqx0GYga7IhLs3oN4BbSo4xPEwSGSF1fAvcT+dutgvQM3xfdoQd1RX2CBhuhP91h7+Ztz71m X-Received: by 2002:aca:d9d7:: with SMTP id q206mr3358278oig.152.1575376141669; Tue, 03 Dec 2019 04:29:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575376141; cv=none; d=google.com; s=arc-20160816; b=rYVxWOJCNbGpYaDdM6+3/Tg1CB5jEx4bJLTzfFR9H7zev7cx9opxkMBtVjjtyKCAQ9 lVvYvHGM6n0BFORm/JF5pirdM3XXTV/edy4EU1jYeCxYFRNZgJPu2s25wKpzHItbd4V6 d+1dZV1i3kT505+oSzocIKc+61B8OVyXPrS4f5eP7Lfl0hc0vKk39DvtOETbEyP5g+vE GnxkgwmTLhfonGC76WCRUdLb3cMR6JLhKlHpp/UNvUcVhxHbJ1B1nr8QPgQqT5TTu/T2 n6+TXGQUOGjpWydEQGAyA++TgEpC5BuS9LGWjt+/7O6hR4c1qhe1Qof8r08lYlAmNNmK A+8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lPde8Be7r9/wxtONVuki371HY8PY1x8aHotJ6fyWpvE=; b=Hv58j24AoafKKyfvlzRJOGGsy0IBOVBPaf9qcUfUsVjUNFjjQmFUCfvY0ZapJXtpMN VQ81TVbHV9P9Ug5FzJnfufRhaf0vaNgtS8DcLT+9xKFpUxqe4Xr3Ph8Np6km4ta7FaAW 52cpW6AMtZGCDtMftOv09DmI/r+jFvYRoDHbTdHoPFsJdBSJBu7n6vZrADMgG7fj6NUa LVOwW3AWmSI1nqIRF0bbpWowFlthKBaoWp2C5bZC4K6kViRhexPXRaLXSn2102UM5ns9 QEpZP0oZYcTuzXy4g0eSeYP4bg1/QT0znxn3pXKRk/4GQ/tRLEAYpmnaNbct13yIzLy1 B81w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cyRBSgt8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a14si1196926otk.2.2019.12.03.04.28.49; Tue, 03 Dec 2019 04:29:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cyRBSgt8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbfLCM1v (ORCPT + 99 others); Tue, 3 Dec 2019 07:27:51 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:45482 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbfLCM1u (ORCPT ); Tue, 3 Dec 2019 07:27:50 -0500 Received: by mail-lf1-f65.google.com with SMTP id 203so2741785lfa.12; Tue, 03 Dec 2019 04:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lPde8Be7r9/wxtONVuki371HY8PY1x8aHotJ6fyWpvE=; b=cyRBSgt8Vp0TMyavVQuKIzKsahinYHMrmjn4ZPsKZLSEf6RsQxIpOxdj6tR3opxY9h UbFZBYZhS5HxvsHmST7Xp0fTATmTm/C4ORawgBhWmiI9WqtdNj6HaM8ixphoEWd0Ac2h F/2TQz7iT3E1bUm9zHS3O8b1fZvxfBVKTh6gEOVff9OK4oLKDelUM+byurOqrfUBb2vP n4nKAEIHBTHcuEmD8UOTJeQBhMtoyRktZDhu9hs6TH1q1eyj56w4S50FcXUMojr8sYFy 96RvTCIC9yN+wN37w1lwXsUxwl6G+ufj+VvNCGVkeOYuR0AbcKX5xrgMYYFMqiH6IW7K Z/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lPde8Be7r9/wxtONVuki371HY8PY1x8aHotJ6fyWpvE=; b=Vl2sEyM9oJrEasHayCcGt2ZEHyqM7LB6r2546NGx9B+cDEwbHVB66s/Q3BqIGO5p0k YDOeI/qRRG4uenTIeTRokvLtfOQXLXTSQFJ5mnQHe4Vw28UdC39u0b3+RGbF5GBdGdgh Wu/l+6yI2al+K3iW6VGcwNfWtkg3lZPyEPSjTDtsnAQoVKzouBbK+o1Db0B7uJGWOwXj tvRB6z7gyl7Aza/U+i0R8/9jMVQE/U1mkBq4sTnm3dfI797DGpdve9rGHUO6nTFiILpH HM3KTqOBSzm8Z9SRNc/MT9ZsUAkv0KZvh20aDEV5DYCU96kopmJ+94rKBT1mTbAwwqqp iJQA== X-Gm-Message-State: APjAAAXKoleWtLpA/hJPHH+NWjl6WJhp/hMeNStL34j9RddjmVd2UCrH VsqBf0sLZ/6vFSFAe9GprPAYxo0MlP8aokT6VcU= X-Received: by 2002:ac2:4194:: with SMTP id z20mr2592432lfh.20.1575376067703; Tue, 03 Dec 2019 04:27:47 -0800 (PST) MIME-Version: 1.0 References: <20191127203114.766709977@linuxfoundation.org> <20191127203119.676489279@linuxfoundation.org> <20191202145105.GA571975@kroah.com> <828cf8b7-11ac-e707-57b6-cb598cc37f1b@redhat.com> In-Reply-To: <828cf8b7-11ac-e707-57b6-cb598cc37f1b@redhat.com> From: Jack Wang Date: Tue, 3 Dec 2019 13:27:36 +0100 Message-ID: Subject: Re: [PATCH 4.19 067/306] KVM: nVMX: move check_vmentry_postreqs() call to nested_vmx_enter_non_root_mode() To: Paolo Bonzini Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable , Sean Christopherson , Jim Mattson , Sasha Levin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org snip > > > > Should we simply revert the patch, maybe also > > 9fe573d539a8 ("KVM: nVMX: reset cache/shadows when switching loaded VMCS") > > > > Both of them are from one big patchset: > > https://patchwork.kernel.org/cover/10616179/ > > > > Revert both patches recover the regression I see on kvm-unit-tests. > > Greg already included the patches that the bot missed, so it's okay. > > Paolo > Sorry, I think I gave wrong information initially, it's 9fe573d539a8 ("KVM: nVMX: reset cache/shadows when switching loaded VMCS") which caused regression. Should we revert or there's following up fix we should backport? Thanks, Jack