Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1441826ybl; Tue, 3 Dec 2019 07:14:17 -0800 (PST) X-Google-Smtp-Source: APXvYqy926QcIVKaUJoz45by0TI6q0l6LTnWkmTAEFBvYg+EfUtusaavUzkLs+DsGpwOU1r/pAqj X-Received: by 2002:a9d:1d07:: with SMTP id m7mr3507088otm.261.1575386057240; Tue, 03 Dec 2019 07:14:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575386057; cv=none; d=google.com; s=arc-20160816; b=iPeY6CjJmnhiK4/kUfrU+RjmctIJjQvB1vyiroFnBUmRwJbEnEbdEfn2lCabYupKLM nLb73fpm+88KKDzDvSFTLbXu48ce84ltOFMhD/zaQxtyoops1znyDFJFfKIcePOygKYR CumoGzN06w3zO8f+Yl01yNq1oj6FbzoDaMNv6ySfzBfTQ4KKAwrPSrbA3FwSJpUSbSkm prJJl0YWX/uCX1TLAe7WWtn0AfE0ESYU41xl1sn4ihB7QTlDb61bC6d0IF7vy6WkhwVq yLIweJ8r1ZWoVasVQ0mDAa+Q8tNibGiHMYp0V638iHjiexLqu4XzVkP9fZuAAIAozZnJ 7KaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:user-agent:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature; bh=Ys0ox1ao18cOZfxiE9S2+ciC5jFVh+QzhShG4ijPhio=; b=02Na7WVpwPnvjY7r/jXYYl0OCc8BIoeLoPjO+G+2x5PQ2KHvpTnfOpTxW7k8QO3mUu I6e2DnzF2z/6BBSzqd4mgrEL38Kgstu7hNmkYSZeiJJ5dimeDTl4ivxoaCUtiNwBg5dH YoFuEQMlmf/KANMB0P5ATug77J6J984BBMyY/VsTz/+sKCF7N7FQ3WXMnUnrWKhQ2ZjE KE8Jg3q3q3TmMncGFo/AJtUGS7usuDJ5tc0CQvgEbZEpwGZtKj6cmAVOzGMJWRDjUCjX 7tSPbQNCRGcV6mijnQvetVRHvuNO2kkKvxDqQf62hNs5SUEKAVeomu3Onqkgr98QPq3Y BwWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=WGNpS3zn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si1360042otn.150.2019.12.03.07.14.03; Tue, 03 Dec 2019 07:14:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@st.com header.s=STMicroelectronics header.b=WGNpS3zn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbfLCPMs (ORCPT + 99 others); Tue, 3 Dec 2019 10:12:48 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:33905 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCPMr (ORCPT ); Tue, 3 Dec 2019 10:12:47 -0500 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB3Ev0d7030223; Tue, 3 Dec 2019 16:07:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=STMicroelectronics; bh=Ys0ox1ao18cOZfxiE9S2+ciC5jFVh+QzhShG4ijPhio=; b=WGNpS3znEhwLqh5hvH8FyLX+/jjMFKWWrzJEIUohw1R29GLiH6IZzb5aXa44rzZgSofx 0BzsEIjy05zSZ5pXDQrnTLDVJ2qV+aQMdsJQHM0lTkfu0Mvv68gAFSimW/zNQ0dK5oWA sHWYmZc2ALRXTRitClj+9Kc0gCxJOCz6XwOdn5zZFEvgORb2XCJU0ZxE7BAUcfMlx++1 a87Urph9exurYKC60oXEaJfxWMOaPI/+pnCxZixjaB81s+nGfRk9u9QT/rwBQmKVwtUq x0I5l4/mPuENDPRiWbO0MHfxXItgCrFN7KnBgwD426NoPYaCSKnHoqVfCnuxP0waVd8z gQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2wkf2xqw64-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 03 Dec 2019 16:07:23 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9E95B10002A; Tue, 3 Dec 2019 16:07:20 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6D12D2BC7B6; Tue, 3 Dec 2019 16:07:20 +0100 (CET) Received: from SFHDAG6NODE2.st.com (10.75.127.17) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 3 Dec 2019 16:07:20 +0100 Received: from SFHDAG6NODE2.st.com ([fe80::a56f:c186:bab7:13d6]) by SFHDAG6NODE2.st.com ([fe80::a56f:c186:bab7:13d6%20]) with mapi id 15.00.1347.000; Tue, 3 Dec 2019 16:07:19 +0100 From: Olivier MOYSAN To: Mark Brown CC: "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-kernel@vger.kernel.org" , "apatard@mandriva.com" Subject: Re: [PATCH] ASoC: cs42l51: add dac mux widget in codec routes Thread-Topic: [PATCH] ASoC: cs42l51: add dac mux widget in codec routes Thread-Index: AQHVqedr55RsnCXb/EmaRp/MuIs00qeociSA Date: Tue, 3 Dec 2019 15:07:19 +0000 Message-ID: <06c0474b-8b51-0ce6-b2aa-fc3b2c348f04@st.com> References: <20191203141627.29471-1-olivier.moysan@st.com> <20191203143909.GL1998@sirena.org.uk> In-Reply-To: <20191203143909.GL1998@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.50] Content-Type: text/plain; charset="Windows-1252" Content-ID: <5215F65C3009774EA7992774F10B1559@st.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-03_04:2019-12-02,2019-12-03 signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 12/3/19 3:39 PM, Mark Brown wrote: > On Tue, Dec 03, 2019 at 03:16:27PM +0100, Olivier Moysan wrote: > >> - SND_SOC_DAPM_DAC_E("Left DAC", "Left HiFi Playback", >> - CS42L51_POWER_CTL1, 5, 1, >> - cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD), >> - SND_SOC_DAPM_DAC_E("Right DAC", "Right HiFi Playback", >> - CS42L51_POWER_CTL1, 6, 1, >> - cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD), >> + SND_SOC_DAPM_DAC_E("Left DAC", NULL, CS42L51_POWER_CTL1, 5, 1, >> + cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD), >> + SND_SOC_DAPM_DAC_E("Right DAC", NULL, CS42L51_POWER_CTL1, 6, 1, >> + cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD), > This looks like an unrelated formatting change? The reason of this change is to replace "HiFi Playback" by NULL, in=20 order to connect DAC widget to DAC mux widget, instead of connecting it directly to Playback= . Regards Olivier=