Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161004AbWASJz7 (ORCPT ); Thu, 19 Jan 2006 04:55:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161298AbWASJz7 (ORCPT ); Thu, 19 Jan 2006 04:55:59 -0500 Received: from vanessarodrigues.com ([192.139.46.150]:6575 "EHLO jaguar.mkp.net") by vger.kernel.org with ESMTP id S1161004AbWASJz6 (ORCPT ); Thu, 19 Jan 2006 04:55:58 -0500 To: Benjamin LaHaise Cc: Alan Stern , Andrew Morton , Chandra Seetharaman , Keith Owens , Kernel development list Subject: Re: [PATCH 1/8] Notifier chain update References: <20060118181955.GF16285@kvack.org> <20060118214204.GG16285@kvack.org> From: Jes Sorensen Date: 19 Jan 2006 04:55:57 -0500 In-Reply-To: <20060118214204.GG16285@kvack.org> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 986 Lines: 19 >>>>> "Benjamin" == Benjamin LaHaise writes: Benjamin> On Wed, Jan 18, 2006 at 03:23:20PM -0500, Alan Stern wrote: >> You can't use RCU protection around code that may sleep. Whether >> the code remains loaded in the kernel or is part of a removable >> module doesn't enter into it. Benjamin> A notifier callee should not be sleeping, if anything it Benjamin> should be putting its work onto a workqueue and completing Benjamin> it when it gets scheduled if it has to do something that Benjamin> blocks. There are cases where all the notifier client would want to do is kmalloc(); sum_up_some_data(); copy_to_user(); kfree(); very often in the exit() path - doing that via a workqueue seems overly complex. Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/