Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1901087ybl; Tue, 3 Dec 2019 14:40:58 -0800 (PST) X-Google-Smtp-Source: APXvYqyqQXsYbzgdQ4FgfmnBoNwl/6wzXxyENKP4NBKUVIR4jyiWEzgOmxukq9+sC+CMP0ipCLp5 X-Received: by 2002:aca:b38b:: with SMTP id c133mr11442oif.2.1575412858611; Tue, 03 Dec 2019 14:40:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575412858; cv=none; d=google.com; s=arc-20160816; b=mzz7AUkxluLHT+TWcq8kFC9YC26ZLjr3E8L/i9UCKXBKN67bByAV6QHNw1vmM5zTAk zC6Ye7vJxSHx5YfQgq01U3Hrx/Y5OeyembdYHNhst04GsC44Zu3udmZtm/me+LRqngpd GAim4Zl9rv4Euwla9RleGVQokoEpuXSXJnD3bIYpuNWDSd3Cqz+APIjcY7ZD2rOvryth HGuMgRDwhZXjrgkyXl/B6AWFmE4v+0zYPyWBmiRCL6galQ8Bq/WTKd+Keuw/AazlcZc3 4O87sMWOdbCujfgQPQpuj6wtTxk5E2cLZ8AAjrnESJ/SMKZygN03ditwxrT3Rq9dvIQg vd6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jPJVB2ky/lt6U4gL1/rGrWigrWChMcDRbJD0Xz5snFA=; b=gpIt3YaFKQPGy4309Rbz4w+Z+JuRsB8tnidoNf5/3v7eW+xDvf1xFxZ1bkOP1txEo+ 14pJ10xKRi12L9jeYMQ6pcf+uBseX3L1ixWme8zQV20vulzFWSwzbzVC1N0xcLJO5xPr gB8U7ciQ2QHe4nNWiTEeehSH2Ea0aQVYuiWbbeKkPOclUu2Tq09CjgGGWl8BGpPQX2QP ajqsbNb3OdCZHXEKVRIOp2VSOzBOmhwTpY4qZbAa0cG3artEX8uER1jKUN0uw6KCZ6Ox rVovTtUPm8akxbi/bwOPj93iO+cZmVbmPaeZVcqJliksZKAJ1IBCbYC1Z/jLtIttIa/J ZuxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZQwM8M0t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si2273609otk.324.2019.12.03.14.40.46; Tue, 03 Dec 2019 14:40:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZQwM8M0t; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728078AbfLCWit (ORCPT + 99 others); Tue, 3 Dec 2019 17:38:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:48338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728070AbfLCWis (ORCPT ); Tue, 3 Dec 2019 17:38:48 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00CDB20684; Tue, 3 Dec 2019 22:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575412727; bh=JxEp9mup7CCnqaZyUZA3/WKdzQze1ncSfpwctIWZd+w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZQwM8M0tVzI3Kj4WEPvHmv9DgO1uv8VuBv5lA0/ibTkdlW9N7nYdFl08wqTBliWmL 7/z5ESItJDfdZcPMIvMClcZjC2Ea1lbdtW/NEvP10NgFOVbVDMgTIEBgjAr6M+sTW3 5GCV2bRKT/BxJqB2y+AB7JzVbp8N3L4BEe2s2++M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Alan J. Wylie" , Heiner Kallweit , "David S. Miller" Subject: [PATCH 5.4 39/46] r8169: fix jumbo configuration for RTL8168evl Date: Tue, 3 Dec 2019 23:35:59 +0100 Message-Id: <20191203212801.134488734@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203212705.175425505@linuxfoundation.org> References: <20191203212705.175425505@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Heiner Kallweit [ Upstream commit 14012c9f3bb922b9e0751ba43d15cc580a6049bf ] Alan reported [0] that network is broken since the referenced commit when using jumbo frames. This commit isn't wrong, it just revealed another issue that has been existing before. According to the vendor driver the RTL8168e-specific jumbo config doesn't apply for RTL8168evl. [0] https://lkml.org/lkml/2019/11/30/119 Fixes: 4ebcb113edcc ("r8169: fix jumbo packet handling on resume from suspend") Reported-by: Alan J. Wylie Tested-by: Alan J. Wylie Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/realtek/r8169_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4118,7 +4118,7 @@ static void rtl_hw_jumbo_enable(struct r case RTL_GIGA_MAC_VER_27 ... RTL_GIGA_MAC_VER_28: r8168dp_hw_jumbo_enable(tp); break; - case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_34: + case RTL_GIGA_MAC_VER_31 ... RTL_GIGA_MAC_VER_33: r8168e_hw_jumbo_enable(tp); break; default: