Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1905409ybl; Tue, 3 Dec 2019 14:46:08 -0800 (PST) X-Google-Smtp-Source: APXvYqy+TN2k8+Bm8hhbzmLguzC4uEBoZIMYokLrPxHx3INxKdf3LgMAtPpWP32wsPn7auyW2nwn X-Received: by 2002:aca:5490:: with SMTP id i138mr310257oib.69.1575413168490; Tue, 03 Dec 2019 14:46:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575413168; cv=none; d=google.com; s=arc-20160816; b=0ppp8Lui4fHX2xYeHJ41B6UPV0B5olc9Nto4OY9SeTGzMqFm8hs+6tAJ1z3ovlbAUx pVayWV2Lbf+EhS/zsPP08/XCk5lzEtrq4EivggQynWEriFSwb0dI+h43iBCEDW3W3cRn WDTEoLIw877FYqrtgbzxjaXXBFf7+UYjmPR+WDcb2Gklw3yxxYwhbxzXidz2IfccTU8F Z9mJviP6Pod7zhLxvHJoVR5GDmlYp4TaZJ+wFv6DHh3ZnkQBBsLpMq+c9NPN6JWQT7PD Vj517FcBS1jV0K/HCeXMwXQBniKN9pdR1citHUenFa537x/8yB7r3xeeaFo6k5ecnc4j OE+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iO/RxMq6GKPaAt6juAHx/T+IpQLhnXsG8/cV/Oo+YDk=; b=gJpZo3gT3vhGhhNPteAz3BKPV+wJEl8aquf4AsIHY7I0EEm+WCbnCueN7tVAWOzPI1 BJW2SIk42YjOx9KuFmWaXi97uXcAdUMdl1r7n5U3HlSCQzEIwX2FlpaVjc2kyqj2GQKe mte5SQ0k9VE3KvhtM+rhgsD2SVBEO5EocsDuPKzwT3G8pi/BlZcKQXOr82MlDVHzcE1/ DhPBjXOC0w6I4+TWvBs5HEjNghJ97nmhChF/TPP0/jLwxXHSiixxtPn8CAlN4vpoPB5q 0SrMXrap7BHpyCrwbIH/HTZfC2T7sotaTGC9rawCUON6RojiouJ3c3vHwPBIizTBtu5R Xd7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r00BbFkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2si2077618otb.280.2019.12.03.14.45.56; Tue, 03 Dec 2019 14:46:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=r00BbFkF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbfLCWoc (ORCPT + 99 others); Tue, 3 Dec 2019 17:44:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:60528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727883AbfLCWo3 (ORCPT ); Tue, 3 Dec 2019 17:44:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6388820803; Tue, 3 Dec 2019 22:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413068; bh=0m1Avh+7iCfA8efKpYg84A8LNUnhwyMVsTgLBhap1ms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r00BbFkF2HJenufzHOKByUnc/OUvK2Ng5nTtkP2cXh7DeRR+W9oOVoNzfQo4ipFMx Qj7wZTVpyKyR+UADQ9TPt6Lf9F4GFFE+S2CeOjZtuMUb5xwAWbqiBJNsjC4FAwopkz pxjG4JWSbFl0s1pwiiAV5J5S2Ae+6MoaYm8csPcU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jose Abreu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.3 085/135] net: stmmac: xgmac: bitrev32 returns u32 Date: Tue, 3 Dec 2019 23:35:25 +0100 Message-Id: <20191203213034.318173781@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203213005.828543156@linuxfoundation.org> References: <20191203213005.828543156@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jose Abreu [ Upstream commit 3d00e45d498fd5347cea653ef494c56731b651e0 ] The bitrev32 function returns an u32 var, not an int. Fix it. Fixes: 0efedbf11f07 ("net: stmmac: xgmac: Fix XGMAC selftests") Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c index 46d74f407aab6..91d7dec2540a1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -361,7 +361,7 @@ static void dwxgmac2_set_filter(struct mac_device_info *hw, value |= XGMAC_FILTER_HMC; netdev_for_each_mc_addr(ha, dev) { - int nr = (bitrev32(~crc32_le(~0, ha->addr, 6)) >> + u32 nr = (bitrev32(~crc32_le(~0, ha->addr, 6)) >> (32 - mcbitslog2)); mc_filter[nr >> 5] |= (1 << (nr & 0x1F)); } -- 2.20.1