Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1928186ybl; Tue, 3 Dec 2019 15:09:43 -0800 (PST) X-Google-Smtp-Source: APXvYqzmGZbWh4WO1PpsfBTscs/SQKQ5I8J8AKHDVejwCmYoZs2vA8G8vIXqO90hxml52YA+5Qss X-Received: by 2002:a9d:1295:: with SMTP id g21mr262262otg.301.1575414583348; Tue, 03 Dec 2019 15:09:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575414583; cv=none; d=google.com; s=arc-20160816; b=F8Sdb3/U5vc/GxAyhxFuVtHcu/pSdHEuhxbqj3d/LX9oSbADs9+aGyGWlL1uAzFenJ pZijL9XZTnBs7ctTXiLrnP10EQ43717g/4uJplCoB2DDP3jeqJV5Hf3cDz5rJC2RqPGC 5Ph5OgcUHrg40ygZmX5DKRQeBfUqsY0bTlk6iW50oONp9WJNW5zETJxFE5j1uMePkZdy 5S4ASKk6wA+rVOjrXhugtQ6AIdeKeWXMjT9a6vxRiFJ93O0knii9IO8WWyzmfh0DioAI QQweAV6t/zUg4Z9U5xa/THHkM1jNctzNRA8aOj2DrOeMKtTscX7X6vdr7KKN41HIidh4 dCsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dNN20JMqIG6EOBwtgizZ7JOdr4mP9ITYDNmKHeAy14k=; b=iGcdM0yZmna4JQwoRYjPye/Qn1eiJ1u35a0RYDTYHHs4I8NcVnvKWf0K/ddAMe1aCq VNbsUqosENOPpAnVz4MJRrhaY65uZaYqf+SUfwOjyVCo6odxuM9KJcu42xN3pSJ2RsFY XVHqekmmJXGGLhxuNCg89LEV5PxTLavQY0mu2/dJ07TnEPuL3MIBLXRigWIwlICk1Zq7 CGfSgyWfOvnDvhRs/W70Oc5mIFKROGlP+8kYhcBjlXq4eFwhdR6TJDpDzg4EWLl4nnQv 1wwrdIl4ctM6EcWCv6bPBdxsI1in6gro4tQ6dq2v0hvFGdP2ZYsRVcNC9T4wR92XUvdo HuMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2lkMzGuG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s206si2227979oib.73.2019.12.03.15.09.31; Tue, 03 Dec 2019 15:09:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2lkMzGuG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbfLCWq7 (ORCPT + 99 others); Tue, 3 Dec 2019 17:46:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:36762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729251AbfLCWqv (ORCPT ); Tue, 3 Dec 2019 17:46:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D98D2084B; Tue, 3 Dec 2019 22:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413211; bh=Tyhi2JPw7jneTFeLl7BLrdgROznfz5UAxCjic14lyyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2lkMzGuGfMqOrmyMhQIcTISTmK4Ls3qjdZzSSx/hIS3SJe0LVzxTF9wGdhJdYC4aa K+Ad7lGtfgzQ70riuftSwUp6v4pHASUI8Yn/merpnleGwQ0g3sOfQp/4sM6hm8K+nq aKyQM+oAVmusVs3F9Qh6K5ODSHXCZGpAs/y8e84c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Xiaojun Sang , Srinivas Kandagatla , Vinod Koul , Mark Brown , Sasha Levin Subject: [PATCH 4.19 004/321] ASoC: compress: fix unsigned integer overflow check Date: Tue, 3 Dec 2019 23:31:10 +0100 Message-Id: <20191203223427.350424112@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203223427.103571230@linuxfoundation.org> References: <20191203223427.103571230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xiaojun Sang [ Upstream commit d3645b055399538415586ebaacaedebc1e5899b0 ] Parameter fragments and fragment_size are type of u32. U32_MAX is the correct check. Signed-off-by: Xiaojun Sang Signed-off-by: Srinivas Kandagatla Acked-by: Vinod Koul Link: https://lore.kernel.org/r/20191021095432.5639-1-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 516ec35873256..509038d6bccdb 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -529,7 +529,7 @@ static int snd_compress_check_input(struct snd_compr_params *params) { /* first let's check the buffer parameter's */ if (params->buffer.fragment_size == 0 || - params->buffer.fragments > INT_MAX / params->buffer.fragment_size || + params->buffer.fragments > U32_MAX / params->buffer.fragment_size || params->buffer.fragments == 0) return -EINVAL; -- 2.20.1