Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1929507ybl; Tue, 3 Dec 2019 15:10:58 -0800 (PST) X-Google-Smtp-Source: APXvYqwujU60z7mUt85jXQOqgqV3Z/rDDy8uo1M7jq+8vToYGptqIVxpBlnZb3JBz6Te7N17l8wW X-Received: by 2002:aca:c646:: with SMTP id w67mr65406oif.171.1575414658749; Tue, 03 Dec 2019 15:10:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575414658; cv=none; d=google.com; s=arc-20160816; b=VGy+R0Q6p5r1wxkrtIJcSkTVyY7797BDgI1xcyr85GDz2ZVgulAM/QWs+M0/ys04RE HtCU43RKd3hRJ30so9luOZSbOTI8LS6vIKilfxP/g48U6mPRwnGeLGZNeViMzgvpkKOY inYIoBBn2DXXBTVsnOBaTxqL/qIejIix5uXCs7VOjEBMqvem8ObHJxerDnW4aFKoVfsO RKIXlNOQnX4cMzAQ4sjxcSsSRkfR1L5QRcqZj1lCfLXx8Z9nKaPQMPPZjuCepHMrSlX9 fNQ01u655C/yV7Y1hIamVHSBenG2kuhbFcl4tvCsAbLGLqDmkiACxR+lbmdKW5YgcZdP O/gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UQzZmp4fD06e/+rrBg4C1do2HT7wR7BE1i4i/AkWKGE=; b=ljrdAyNQpY2fFs6Gmu+Nxi81iUG2nH5OFky1dI3tPDe+FcMVZNYUE05DV3wsSkGYEX 4QxJKc6XyLmA6x+edOHRJ6q6ujBlhBKI6Q6+ov8P9pNIzk8TqxwuZCpzaTZF/JPqQYc/ 7Phr26W5ddIvU45ROeM4PxnrbkXCd8+/TtSYlZuWHqdkEoGZyhbFgjnmRsJHts603HhH NDspeKDq+U46oHv/uCbKiNRZXnm587L2HeymZhoPkQfrLQ4psS9cwN7KmKyArwJWk4hf x9JPJVAU/j0B4jZIwlR8ZtNMjtku+EvIOG73ckHw9WPZMhcjRlh14Is+QPJvwyWsD1sB 6JTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ic17hu0B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x126si2217499oix.53.2019.12.03.15.10.42; Tue, 03 Dec 2019 15:10:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ic17hu0B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728889AbfLCWn6 (ORCPT + 99 others); Tue, 3 Dec 2019 17:43:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:59544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728883AbfLCWn5 (ORCPT ); Tue, 3 Dec 2019 17:43:57 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BFF42073C; Tue, 3 Dec 2019 22:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575413035; bh=5CfqdPpLGQxt/doP6KHgiyWtQhtxDNWKoNiJXqVrP78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ic17hu0Baswhj78MZ/X2TgPE23LcnqCC6joQ8RwxXq6TR6+Yr66bt8RmzaaJT/q8H Iw6Nf1cVLkTKz7S06iNHjsQxJuqJDbMbwLS596B8y0Oa541JdAbntCzyBxkyrBji9B GEzyFKapX+61sbAffvAb4bkLpm9QaUMW9lY0vkaU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jose Abreu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.3 084/135] net: stmmac: gmac4: bitrev32 returns u32 Date: Tue, 3 Dec 2019 23:35:24 +0100 Message-Id: <20191203213033.340861877@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191203213005.828543156@linuxfoundation.org> References: <20191203213005.828543156@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jose Abreu [ Upstream commit 4d7c47e34fab0d25790bb6e85b85e26fdf0090d5 ] The bitrev32 function returns an u32 var, not an int. Fix it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Jose Abreu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c index 9c73fb759b575..ff830bb5fcaf7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c @@ -438,7 +438,7 @@ static void dwmac4_set_filter(struct mac_device_info *hw, * bits used depends on the hardware configuration * selected at core configuration time. */ - int bit_nr = bitrev32(~crc32_le(~0, ha->addr, + u32 bit_nr = bitrev32(~crc32_le(~0, ha->addr, ETH_ALEN)) >> (32 - mcbitslog2); /* The most significant bit determines the register to * use (H/L) while the other 5 bits determine the bit -- 2.20.1