Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1946583ybl;
        Tue, 3 Dec 2019 15:28:29 -0800 (PST)
X-Google-Smtp-Source: APXvYqzAS2NqTA8gMowDGWR9ykTR1x5gjBIDgMhoGgCyJEXkUwsCewjc/QupSY+XADbu41xh3aDK
X-Received: by 2002:a9d:73d2:: with SMTP id m18mr356211otk.150.1575415709446;
        Tue, 03 Dec 2019 15:28:29 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1575415709; cv=none;
        d=google.com; s=arc-20160816;
        b=k5aN2kRJOXm1S65SxESwjM/6xB8B9punC1aHsYDOsUpkwEpGDdCIOKJdSF7nbN4qVR
         z9wP9pir3/hvq/E8qKohcAGAOaRBmcBhxCtLCTKYY1ANEZv4NAi57esuAN71OLw06OUS
         WxA6VclnBQAHvDx8SXhF/UUkM4FX+FQ1+p+PuhBaf/QUGctQasso0mQ6Lt+Td2WM8lFv
         0VK5nQEnyBUmtYdAZnG467hj8CnKI2u00dpjjAlHvFodWY3/cgM4pbyky8st0poEYWhf
         diozAv7d334K7p6B/yBxmdGlRN6Lf7KQFJtHpe38BBGokC/MSD1Qn4xj4lXYzoC0rNQG
         2mcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=vfVKzdkXztCZYuLAwJxHEwseHcXT4COainOIa886LgM=;
        b=uiHXkWjFXQZuR0xJSPBMlVADsuK2dyN/hZBfKCMILInVPD8ZqL2Zfge+dCKLIxzcOF
         +0zvma33h6JjM2mpzjZanvFgyW/dcXRnhYTva8OY2eEseNCCS8fGA2d5bZ6pfF3v1N04
         zs6zW8NZjESvZqAZ5O6nb5d2ca+gl088EANsJkekLXqaGAiFc2mJesLq3D4Tmu80HmNw
         UJ40Tk9KeL7l0Vt+TjFOWKII0jVNfkTFvNoK3FlSYz5EbQ23J10+u4CbSuqqN6I/c6Sn
         T6QyXMJ0HDagZvPU/YPFhN1MtQk4NtdXTWL5U5t0fTf74FTQLNE4yfAh9J0bxSX15XmT
         RWAw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=FPFsJSgr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h22si2172486oie.15.2019.12.03.15.28.16;
        Tue, 03 Dec 2019 15:28:29 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=FPFsJSgr;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727117AbfLCX1v (ORCPT <rfc822;tluu11sec@gmail.com> + 99 others);
        Tue, 3 Dec 2019 18:27:51 -0500
Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:16586 "EHLO
        hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726144AbfLCX1v (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Dec 2019 18:27:51 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5de6ef660000>; Tue, 03 Dec 2019 15:27:34 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 03 Dec 2019 15:27:49 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 03 Dec 2019 15:27:49 -0800
Received: from [10.2.160.125] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 3 Dec
 2019 23:27:47 +0000
Subject: Re: [PATCH v1 15/17] dt-bindings: tegra186-pmc: Add Tegra PMC clock
 bindings
To:     Rob Herring <robh@kernel.org>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <digetx@gmail.com>, <mperttunen@nvidia.com>,
        <gregkh@linuxfoundation.org>, <sboyd@kernel.org>,
        <tglx@linutronix.de>, <mark.rutland@arm.com>,
        <allison@lohutok.net>, <pdeschrijver@nvidia.com>,
        <pgaikwad@nvidia.com>, <mturquette@baylibre.com>,
        <horms+renesas@verge.net.au>, <Jisheng.Zhang@synaptics.com>,
        <krzk@kernel.org>, <arnd@arndb.de>, <spujar@nvidia.com>,
        <josephl@nvidia.com>, <vidyas@nvidia.com>,
        <daniel.lezcano@linaro.org>, <mmaddireddy@nvidia.com>,
        <markz@nvidia.com>, <devicetree@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1574146234-3871-1-git-send-email-skomatineni@nvidia.com>
 <1574146234-3871-16-git-send-email-skomatineni@nvidia.com>
 <20191203221137.GC22716@bogus>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <5445c579-4a85-ca36-69c9-7fe86dbf1fa9@nvidia.com>
Date:   Tue, 3 Dec 2019 15:28:09 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20191203221137.GC22716@bogus>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1575415654; bh=vfVKzdkXztCZYuLAwJxHEwseHcXT4COainOIa886LgM=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=FPFsJSgr2Xl5lXJiwp7y1kI1MbZpwU1cAbH96ysURG+n0SHopySY23mHtinpTJtFY
         m0ezg6GXZlHqMZFN9l2kGU1AEfslA76swmaNFrQyvBZMa4vSxLCDJ2R+oSLffxhK47
         hq1HRC+K1eVnbYC6gT+b87qkds0w8AS/uBYUMocpTVALujVMKsFFcKxN/hGbo7WYdM
         gLk+erJmzs0gbfpbmGQ1Lr/1vwMlyLmMotm69g6n6hkSbi7Ve5wEW4s/H3RfEDzXAW
         IIe90r+SdLqcaagrCdTDx6RZMb7vg+u8sd5dwcxHN95/Me59xUbDt9I57mIb7fJZpV
         FJqa7SmdFmLsg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/3/19 2:11 PM, Rob Herring wrote:
> On Mon, Nov 18, 2019 at 10:50:32PM -0800, Sowjanya Komatineni wrote:
>> Document clock bindings for pmc clocks clk_out_1, clk_out_2 and clk_out_3.
>> These clocks are part of Tegra PMC block and pmc node is the provider for
>> these clocks.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   .../bindings/arm/tegra/nvidia,tegra186-pmc.txt     | 44 ++++++++++++++++++++++
>>   1 file changed, 44 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt
>> index 2d89cdc39eb0..4576de92e4cc 100644
>> --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt
>> +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.txt
>> @@ -12,6 +12,10 @@ Required properties:
>>     - "aotag"
>>     - "scratch"
>>     - "misc" (Only for Tegra194)
>> +- #clock-cells : Should be 1 for Tegra30 and higher.
>> +  In clock consumers, this cell represents the PMC clock ID.
>> +  The assignments may be found in header file
>> +  <dt-bindings/soc/tegra-pmc.h>.
> Kind of strange the header is shared, but the binding doc is not.

v2 has this patch removed. Tegra186 does not have pmc clocks. They were 
accidentally added in v1 and this is fixed in v2.

>
>>   
>>   Optional properties:
>>   - nvidia,invert-interrupt: If present, inverts the PMU interrupt signal.
>> @@ -130,3 +134,43 @@ Pinctrl client example:
>>   		pinctrl-1 = <&hdmi_on>;
>>   		pinctrl-names = "hdmi-on", "hdmi-off";
>>   	};
>> +
>> +== Clock Control ==
>> +
>> +Tegra PMC has 3 clocks clk_1, clk_2 and clk_3. Each of these clocks has
>> +source selection and enable/disable gate.
>> +Parent/source for these clocks can be either of clk_m, clk_m_div2, clk_m_div4,
>> +or extern clock from Tegra CAR module.
>> +
>> +Clock configuration example:
>> +	pmc: pmc@7000e400 {
>> +		compatible = "nvidia,tegra186-pmc";
>> +		reg = <0 0x0c360000 0 0x10000>,
>> +		      <0 0x0c370000 0 0x10000>,
>> +		      <0 0x0c380000 0 0x10000>,
>> +		      <0 0x0c390000 0 0x10000>;
>> +		reg-names = "pmc", "wake", "aotag", "scratch";
>> +		...
>> +		#clock-cells = <1>;
>> +		...
> Once converted to schema, the examples have to compile and this won't.
> They also have to be complete enough to pass validation checks.
ok, will go thru and run the validation checks.
>> +	};
>> +
>> +Clock consumer example:
>> +	host1x@50000000 {
>> +		...
>> +		vi@54080000 {
>> +		...
>> +		assigned-clocks = <&pmc TEGRA_PMC_CLK_OUT_3_MUX>;
>> +		assigned-clock-parents = <&tegra_car TEGRA210_CLK_EXTERN3>;
> Indentation is wrong.
>
>> +		};
>> +		...
>> +	};
>> +	...
>> +	i2c@7000c500 {
>> +		cam_sensor {
>> +		...
>> +		clocks = <&pmc TEGRA_PMC_CLK_OUT_3>;
>> +		clock-names = "mclk";
> Same here.
>
>> +		...
>> +		};
>> +	};
>> -- 
>> 2.7.4
>>