Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Dec 2019 15:01:05 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Ioana Ciornei <ioana.ciornei@nxp.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add RGMII phy nodes
Message-ID: <20191204070103.GC3365@dragon>
References: <1573055536-21786-1-git-send-email-ioana.ciornei@nxp.com>
 <1573055536-21786-3-git-send-email-ioana.ciornei@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1573055536-21786-3-git-send-email-ioana.ciornei@nxp.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 06, 2019 at 05:52:16PM +0200, Ioana Ciornei wrote:
> Annotate the EMDIO1 node and describe the 2 AR8035 RGMII PHYs.
> Also, add phy-handles for dpmac17 and dpmac18 to its associated PHY.
> The MAC is not capable to add the needed RGMII delays, thus the
> "rgmii-id" phy-connection-type is used.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 27 +++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> index c2817b784232..1e2a7c4031fd 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
> @@ -35,6 +35,33 @@
>  	status = "okay";
>  };
>  
> +&dpmac17 {
> +	phy-handle = <&rgmii_phy1>;
> +	phy-connection-type = "rgmii-id";
> +};
> +
> +&dpmac18 {
> +	phy-handle = <&rgmii_phy2>;
> +	phy-connection-type = "rgmii-id";
> +};
> +
> +&emdio1 {
> +	status = "okay";
> +
> +	rgmii_phy1: ethernet-phy@1 {
> +		/* AR8035 PHY */
> +		compatible = "ethernet-phy-id004d.d072";
> +		reg = <0x1>;
> +		eee-broken-1000t;
> +	};

Please have a newline between nodes.

Shawn

> +	rgmii_phy2: ethernet-phy@2 {
> +		/* AR8035 PHY */
> +		compatible = "ethernet-phy-id004d.d072";
> +		reg = <0x2>;
> +		eee-broken-1000t;
> +	};
> +};
> +
>  &esdhc0 {
>  	sd-uhs-sdr104;
>  	sd-uhs-sdr50;
> -- 
> 1.9.1
>