Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp152353ybl; Tue, 3 Dec 2019 23:55:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxyyP8GSuWWexpv2X25sOPKoB1uHEdaXC4UDyY8VXniKt4ChVWy7y1nOYJARYzfH2UoMLbh X-Received: by 2002:aca:c492:: with SMTP id u140mr1328359oif.80.1575446116224; Tue, 03 Dec 2019 23:55:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575446116; cv=none; d=google.com; s=arc-20160816; b=kbI3n9VLBx9CoxYNeIfzIiN9bcxBuFNfT4fdW4ojvHOODZnGvlK48+EvV+IACcm+Xi Hrdr/Ozh12X36aTyCqNfs6L1PrXR3RIeMcacxdn+wglcfvhPuKA1/6Ikd90Vi1mQvvPZ YCHZ/V8YjyG5/aXuexne45wBRFBwKYY3P3URAm5RjcWEOB8sIwTzAFTM68+6c7bKFUis gsFVVtzTmKnIBKL0aVsyb3tE0RhdhPa/fPBXVzQB7wjUDN+zRqwyzMIACvaPCWmDLR8h vE6hVf3izcurZPmPnb+4LyTWQxfQlh2ZjFZY5JHynFjPzRvosgmieYzf+f59skYJ1z+C Mdww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :robot-unsubscribe:robot-id:message-id:mime-version:references :in-reply-to:cc:subject:to:reply-to:from:date; bh=xuDHSuaeE/bzKqGulYfbBzHEko8ls1qrWZCqzpkh9Xs=; b=DZ41eonng2cnVCOYQtZgwss3VQjbmxg2Zk39CJKkm2gfrcADz7JWhuq8uq9tN1TDUF FGs2PeL+2xnSvtEx9X6OULU7i/4QGAwJuH4xNIy26iuYoVwEQ4f1DmuBuRy6tT/br2Mv g7AnWH1y7LyhhLJftYVKBCJSWu+yD3gbZBAQz5Atj5OKyxHM9j5uqf068n7lpLcV7EUu Ejh3VQNWl2SFo1erhiLocsfvSDWShCPqar4Lr50P2Nx8cGqUuyEbktLqHs6Xuy4MlwvE AhNqUfjdhdv0W78aZxHXZsx9oRoYRTImWNKduETKU0KZOkmWuxfjsrlyaFYGaEedlOpT TASA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si2813054oto.77.2019.12.03.23.55.03; Tue, 03 Dec 2019 23:55:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbfLDHyT (ORCPT + 99 others); Wed, 4 Dec 2019 02:54:19 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:56169 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727429AbfLDHyL (ORCPT ); Wed, 4 Dec 2019 02:54:11 -0500 Received: from [5.158.153.53] (helo=tip-bot2.lab.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1icPU4-0004Wu-C5; Wed, 04 Dec 2019 08:54:04 +0100 Received: from [127.0.1.1] (localhost [IPv6:::1]) by tip-bot2.lab.linutronix.de (Postfix) with ESMTP id 340AB1C264F; Wed, 4 Dec 2019 08:53:55 +0100 (CET) Date: Wed, 04 Dec 2019 07:53:55 -0000 From: "tip-bot2 for Andi Kleen" Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: perf/urgent] perf evsel: Add functions to close evsel on a CPU Cc: Andi Kleen , Jiri Olsa , Arnaldo Carvalho de Melo , x86 , LKML In-Reply-To: <20191121001522.180827-7-andi@firstfloor.org> References: <20191121001522.180827-7-andi@firstfloor.org> MIME-Version: 1.0 Message-ID: <157544603512.21853.17683771347871037830.tip-bot2@tip-bot2> X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 99d6141d677a8cd0b35390a29527c8def42538b1 Gitweb: https://git.kernel.org/tip/99d6141d677a8cd0b35390a29527c8def42538b1 Author: Andi Kleen AuthorDate: Wed, 20 Nov 2019 16:15:16 -08:00 Committer: Arnaldo Carvalho de Melo CommitterDate: Fri, 29 Nov 2019 12:20:45 -03:00 perf evsel: Add functions to close evsel on a CPU Refactor the existing all CPU function to use the per CPU close internally. Export APIs to close per CPU. Signed-off-by: Andi Kleen Acked-by: Jiri Olsa Link: http://lore.kernel.org/lkml/20191121001522.180827-7-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/lib/evsel.c | 27 +++++++++++++++++++++------ tools/perf/lib/include/perf/evsel.h | 1 + 2 files changed, 22 insertions(+), 6 deletions(-) diff --git a/tools/perf/lib/evsel.c b/tools/perf/lib/evsel.c index 5a89857..ea775da 100644 --- a/tools/perf/lib/evsel.c +++ b/tools/perf/lib/evsel.c @@ -114,16 +114,23 @@ int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus, return err; } +static void perf_evsel__close_fd_cpu(struct perf_evsel *evsel, int cpu) +{ + int thread; + + for (thread = 0; thread < xyarray__max_y(evsel->fd); ++thread) { + if (FD(evsel, cpu, thread) >= 0) + close(FD(evsel, cpu, thread)); + FD(evsel, cpu, thread) = -1; + } +} + void perf_evsel__close_fd(struct perf_evsel *evsel) { - int cpu, thread; + int cpu; for (cpu = 0; cpu < xyarray__max_x(evsel->fd); cpu++) - for (thread = 0; thread < xyarray__max_y(evsel->fd); ++thread) { - if (FD(evsel, cpu, thread) >= 0) - close(FD(evsel, cpu, thread)); - FD(evsel, cpu, thread) = -1; - } + perf_evsel__close_fd_cpu(evsel, cpu); } void perf_evsel__free_fd(struct perf_evsel *evsel) @@ -141,6 +148,14 @@ void perf_evsel__close(struct perf_evsel *evsel) perf_evsel__free_fd(evsel); } +void perf_evsel__close_cpu(struct perf_evsel *evsel, int cpu) +{ + if (evsel->fd == NULL) + return; + + perf_evsel__close_fd_cpu(evsel, cpu); +} + int perf_evsel__read_size(struct perf_evsel *evsel) { u64 read_format = evsel->attr.read_format; diff --git a/tools/perf/lib/include/perf/evsel.h b/tools/perf/lib/include/perf/evsel.h index 557f581..e7add55 100644 --- a/tools/perf/lib/include/perf/evsel.h +++ b/tools/perf/lib/include/perf/evsel.h @@ -26,6 +26,7 @@ LIBPERF_API void perf_evsel__delete(struct perf_evsel *evsel); LIBPERF_API int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus, struct perf_thread_map *threads); LIBPERF_API void perf_evsel__close(struct perf_evsel *evsel); +LIBPERF_API void perf_evsel__close_cpu(struct perf_evsel *evsel, int cpu); LIBPERF_API int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread, struct perf_counts_values *count); LIBPERF_API int perf_evsel__enable(struct perf_evsel *evsel);