Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.19 067/306] KVM: nVMX: move check_vmentry_postreqs()
 call to nested_vmx_enter_non_root_mode()
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Jack Wang <jack.wang.usish@gmail.com>,
        linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Jim Mattson <jmattson@google.com>,
        Sasha Levin <sashal@kernel.org>
References: <20191127203114.766709977@linuxfoundation.org>
 <20191127203119.676489279@linuxfoundation.org>
 <CA+res+QKCAn8PsSgbkqXNAF0Ov5pOkj=732=M5seWj+-JFQOwQ@mail.gmail.com>
 <20191202145105.GA571975@kroah.com>
 <bccbfccd-0e96-29c3-b2ba-2b1800364b08@redhat.com>
 <CA+res+SffBsmmeEBYfoDwyLHvL8nqW+O=ZKedWCxccmQ9X6itA@mail.gmail.com>
 <828cf8b7-11ac-e707-57b6-cb598cc37f1b@redhat.com>
 <CA+res+Qo1mX_UFEqDD+sm80PZeW4bRN8VZeNudMDaQ=5-Ss=0g@mail.gmail.com>
 <1387d9b8-0e08-a22e-6dd1-4b7ea58567b3@redhat.com>
 <20191203191655.GC2734645@kroah.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <835e996b-711e-f6fb-a489-db3899c053a2@redhat.com>
Date:   Wed, 4 Dec 2019 12:42:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191203191655.GC2734645@kroah.com>
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/12/19 20:16, Greg Kroah-Hartman wrote:
> On Tue, Dec 03, 2019 at 01:52:47PM +0100, Paolo Bonzini wrote:
>> On 03/12/19 13:27, Jack Wang wrote:
>>>>> Should we simply revert the patch, maybe also
>>>>> 9fe573d539a8 ("KVM: nVMX: reset cache/shadows when switching loaded VMCS")
>>>>>
>>>>> Both of them are from one big patchset:
>>>>> https://patchwork.kernel.org/cover/10616179/
>>>>>
>>>>> Revert both patches recover the regression I see on kvm-unit-tests.
>>>> Greg already included the patches that the bot missed, so it's okay.
>>>>
>>>> Paolo
>>>>
>>> Sorry, I think I gave wrong information initially, it's 9fe573d539a8
>>> ("KVM: nVMX: reset cache/shadows when switching loaded VMCS")
>>> which caused regression.
>>>
>>> Should we revert or there's following up fix we should backport?
>>
>> Hmm, let's revert all four.  This one, the two follow-ups and 9fe573d539a8.
> 
> 4?  I see three patches here, the 2 follow-up patches that I applied to
> the queue, and the "original" backport of b7031fd40fcc ("KVM: nVMX:
> reset cache/shadows when switching loaded VMCS") which showed up in the
> 4.14.157 and 4.19.87 kernels.

The fourth is commit 9fe573d539a8 ("KVM: nVMX: reset cache/shadows when
switching loaded VMCS"), which was also autoselected.

Paolo