Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\))
Subject: Re: [PATCH v15 00/23] Generic page walk and ptdump
From:   Qian Cai <cai@lca.pw>
In-Reply-To: <911fac4a-2204-f994-a101-16a60fba12e8@redhat.com>
Date:   Wed, 4 Dec 2019 09:54:53 -0500
Cc:     Steven Price <steven.price@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>,
        Mark Rutland <Mark.Rutland@arm.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        linux-kernel@vger.kernel.org,
        =?utf-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        James Morse <james.morse@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        "Liang, Kan" <kan.liang@linux.intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <0FA196FD-3FCD-431A-AA3E-21BF00EA07DC@lca.pw>
References: <20191101140942.51554-1-steven.price@arm.com>
 <1572896147.5937.116.camel@lca.pw>
 <7B040741-EC8A-4CC0-964B-4046AE2E617A@lca.pw>
 <16da6118-ac4d-a165-6202-0731a776ac72@arm.com>
 <911fac4a-2204-f994-a101-16a60fba12e8@redhat.com>
To:     David Hildenbrand <david@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Dec 3, 2019, at 6:02 AM, David Hildenbrand <david@redhat.com> =
wrote:
>=20
> On 06.11.19 16:05, Steven Price wrote:
>> On 06/11/2019 13:31, Qian Cai wrote:
>>>=20
>>>=20
>>>> On Nov 4, 2019, at 2:35 PM, Qian Cai <cai@lca.pw> wrote:
>>>>=20
>>>> On Fri, 2019-11-01 at 14:09 +0000, Steven Price wrote:
>> [...]
>>>>> Changes since v14:
>>>>> =
https://lore.kernel.org/lkml/20191028135910.33253-1-steven.price@arm.com/
>>>>> * Switch walk_page_range() into two functions, the existing
>>>>>   walk_page_range() now still requires VMAs (and treats areas =
without a
>>>>>   VMA as a 'hole'). The new walk_page_range_novma() ignores VMAs =
and
>>>>>   will report the actual page table layout. This fixes the =
previous
>>>>>   breakage of /proc/<pid>/pagemap
>>>>> * New patch at the end of the series which reduces the 'level' =
numbers
>>>>>   by 1 to simplify the code slightly
>>>>> * Added tags
>>>>=20
>>>> Does this new version also take care of this boot crash seen with =
v14? Suppose
>>>> it is now breaking CONFIG_EFI_PGT_DUMP=3Dy? The full config is,
>>>>=20
>>>> https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config
>>>>=20
>>>=20
>>> V15 is indeed DOA here.
>>=20
>> Thanks for finding this, it looks like EFI causes issues here. The =
below fixes
>> this for me (booting in QEMU).
>>=20
>> Andrew: do you want me to send out the entire series again for this =
fix, or
>> can you squash this into mm-pagewalk-allow-walking-without-vma.patch?
>>=20
>> Thanks,
>>=20
>> Steve
>>=20
>> ---8<---
>> diff --git a/mm/pagewalk.c b/mm/pagewalk.c
>> index c7529dc4f82b..70dcaa23598f 100644
>> --- a/mm/pagewalk.c
>> +++ b/mm/pagewalk.c
>> @@ -90,7 +90,7 @@ static int walk_pmd_range(pud_t *pud, unsigned long =
addr, unsigned long end,
>>  			split_huge_pmd(walk->vma, pmd, addr);
>>  			if (pmd_trans_unstable(pmd))
>>  				goto again;
>> -		} else if (pmd_leaf(*pmd)) {
>> +		} else if (pmd_leaf(*pmd) || !pmd_present(*pmd)) {
>>  			continue;
>>  		}
>>=20
>> @@ -141,7 +141,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned =
long addr, unsigned long end,
>>  			split_huge_pud(walk->vma, pud, addr);
>>  			if (pud_none(*pud))
>>  				goto again;
>> -		} else if (pud_leaf(*pud)) {
>> +		} else if (pud_leaf(*pud) || !pud_present(*pud)) {
>>  			continue;
>>  		}
>>=20
>>=20
>=20
> Even with this fix, booting for me under QEMU fails. See
>=20
> =
https://lore.kernel.org/linux-mm/b7ce62f2-9a48-6e48-6685-003431e521aa@redh=
at.com/
>=20

Yes, for some reasons, this starts to crash on almost all arches here, =
so it might be worth
for Andrew to revert those in the meantime while allowing Steven to =
rework.