Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp574882ybl; Wed, 4 Dec 2019 07:30:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzdKt7xRlZoVZ+6nIhB5pAhlEBS3vsFPEzgMeC2A3B6Ct0yfeCxUzJ7Fm22eo5jdB9zgiRy X-Received: by 2002:aca:5e04:: with SMTP id s4mr3128327oib.159.1575473409916; Wed, 04 Dec 2019 07:30:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575473409; cv=none; d=google.com; s=arc-20160816; b=Zr4p9WVlbXcPAqYXO8IOcyvnjTIKf7aVM405mJ00OEeZaGweNXYvvsvI23KRc5H+M0 /lDn3QlbMk72I0oYFAq25tGlb/icPSWDa7SHCfhlcGe3yg8BN2hf5CJMt+06ILbDTuda AfmWSMySyE6Fu9LwId6yFWMn6VSab1AFG86PRmt8NnAC106UnKTWukhZehg39RTWq++h W2mF3fkX+H6iC7miz5RDSb+EsdSCdDsjfk8DwwtD8J25fLEhrIBeQomLC0minS5dwQNl NyPGqY2UnbvfsBvzidMBL9VFmMJO+gUQqi8+zuvEuzf+68fQsMyE9MvB8hw0OtqoW4cj MLaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=Sw5knxvH3Jy7ccJOfoLbviBFUVTi32TL8MPDawWZ0V4=; b=S1eQCKpT6/1ZI3wm2Y+gIgkOlGZKYq7bXiRmxjAzJa5ZMawEUGMGWxcmWzPWwc+gUD wRsJ6ip9eu/KVk+w1uM7ThEvKjG4BhkzbBTbhZMMdPs+jaqCwL1QTmpvG3Z4CePmBfsh WMkXPNgP2FO9Nw/2SAYNa/FKH1a3UnuVLt3ZrpYKxwZ80pA4Jjaq9+b5KLrxaiWMmCM6 7abR7skM5sBnIOIGRdTyUt/SNI5o7UolJg1+ftquq3GttjtUvMkSY1kjessa4E21pt0x S63oVPX9r/pSMid8MrFbBDBv0hotgvliNg7YSz5TF+otvET1jgykCB/rklmBVaOXBK47 28cQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=PmwNZwyf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w4si3245931otl.214.2019.12.04.07.29.57; Wed, 04 Dec 2019 07:30:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=PmwNZwyf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728392AbfLDP2P (ORCPT + 99 others); Wed, 4 Dec 2019 10:28:15 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:35452 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728296AbfLDP2M (ORCPT ); Wed, 4 Dec 2019 10:28:12 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB4FOIO7121531; Wed, 4 Dec 2019 15:27:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2019-08-05; bh=Sw5knxvH3Jy7ccJOfoLbviBFUVTi32TL8MPDawWZ0V4=; b=PmwNZwyf0Rem2ACuGe4vPpWPfqqZb2tXJtYTirXPzppAy2kHVHF5VgKlzbGhADia+NIh 68GGrnkRLKFLRgm+Zg4lMZxZMJlfCBNBb6TqS46ugj8zaCCkobnXe0vwZZBkujEnVTT1 u8LamxZqi1alLH2mKHxw1nolRSdR2tmHued+U4waVAz4fXkuOLjiHx23VSp5ZrB3B5qT 4+oXU2iOVMu5OGSKEdxu1ybrQlOThuE+zGoHgJp/SYRTifUM+IL0C41bf1Eg0Bt3yTx4 MTF9ZKZULCf279fnd6zmcrq6h9onWhJ7MKhkDSPl1JmeCe2hy4eXhsEShtoAchc1N4cR 9Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2wkfuuf9yp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Dec 2019 15:27:49 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xB4FNaLm128969; Wed, 4 Dec 2019 15:27:49 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2wnvr01afk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Dec 2019 15:27:48 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xB4FRgUh001216; Wed, 4 Dec 2019 15:27:42 GMT Received: from dhcp-10-175-179-22.vpn.oracle.com (/10.175.179.22) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 04 Dec 2019 07:27:42 -0800 From: Alan Maguire To: brendanhiggins@google.com, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, yamada.masahiro@socionext.com, catalin.marinas@arm.com, joe.lawrence@redhat.com, penguin-kernel@i-love.sakura.ne.jp, urezki@gmail.com, andriy.shevchenko@linux.intel.com, corbet@lwn.net, davidgow@google.com, adilger.kernel@dilger.ca, tytso@mit.edu, mcgrof@kernel.org, linux-doc@vger.kernel.org, Alan Maguire Subject: [PATCH v6 linux-kselftest-test 0/6] kunit: support building core/tests as modules Date: Wed, 4 Dec 2019 15:27:08 +0000 Message-Id: <1575473234-5443-1-git-send-email-alan.maguire@oracle.com> X-Mailer: git-send-email 1.8.3.1 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9461 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=3 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912040128 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9461 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912040128 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The current kunit execution model is to provide base kunit functionality and tests built-in to the kernel. The aim of this series is to allow building kunit itself and tests as modules. This in turn allows a simple form of selective execution; load the module you wish to test. In doing so, kunit itself (if also built as a module) will be loaded as an implicit dependency. Because this requires a core API modification - if a module delivers multiple suites, they must be declared with the kunit_test_suites() macro - we're proposing this patch set as a candidate to be applied to the test tree before too many kunit consumers appear. We attempt to deal with existing consumers in patch 3. Changes since v5: - fixed fs/ext4/Makefile to remove unneeded conditional compilation (Iurii, patch 3) - added Reviewed-by, Acked-by to patches 3, 4, 5 and 6 Changes since v4: - fixed signoff chain to use Co-developed-by: prior to Knut's signoff (Stephen, all patches) - added Reviewed-by, Tested-by for patches 1, 2, 4 and 6 - updated comment describing try-catch-impl.h (Stephen, patch 2) - fixed MODULE_LICENSEs to be GPL v2 (Stephen, patches 3, 5) - added __init to kunit_init() (Stephen, patch 5) Changes since v3: - removed symbol lookup patch for separate submission later - removed use of sysctl_hung_task_timeout_seconds (patch 4, as discussed with Brendan and Stephen) - disabled build of string-stream-test when CONFIG_KUNIT_TEST=m; this is to avoid having to deal with symbol lookup issues - changed string-stream-impl.h back to string-stream.h (Brendan) - added module build support to new list, ext4 tests Changes since v2: - moved string-stream.h header to lib/kunit/string-stream-impl.h (Brendan) (patch 1) - split out non-exported interfaces in try-catch-impl.h (Brendan) (patch 2) - added kunit_find_symbol() and KUNIT_INIT_SYMBOL to lookup non-exported symbols (patches 3, 4) - removed #ifdef MODULE around module licenses (Randy, Brendan, Andy) (patch 4) - replaced kunit_test_suite() with kunit_test_suites() rather than supporting both (Brendan) (patch 4) - lookup sysctl_hung_task_timeout_secs as kunit may be built as a module and the symbol may not be available (patch 5) Alan Maguire (6): kunit: move string-stream.h to lib/kunit kunit: hide unexported try-catch interface in try-catch-impl.h kunit: allow kunit tests to be loaded as a module kunit: remove timeout dependence on sysctl_hung_task_timeout_seconds kunit: allow kunit to be loaded as a module kunit: update documentation to describe module-based build Documentation/dev-tools/kunit/faq.rst | 3 +- Documentation/dev-tools/kunit/index.rst | 3 ++ Documentation/dev-tools/kunit/usage.rst | 16 ++++++++++ fs/ext4/Kconfig | 2 +- fs/ext4/Makefile | 3 +- fs/ext4/inode-test.c | 4 ++- include/kunit/assert.h | 3 +- include/kunit/test.h | 35 ++++++++++++++------ include/kunit/try-catch.h | 10 ------ kernel/sysctl-test.c | 4 ++- lib/Kconfig.debug | 4 +-- lib/kunit/Kconfig | 6 ++-- lib/kunit/Makefile | 14 +++++--- lib/kunit/assert.c | 10 ++++++ lib/kunit/{example-test.c => kunit-example-test.c} | 4 ++- lib/kunit/{test-test.c => kunit-test.c} | 7 ++-- lib/kunit/string-stream-test.c | 5 +-- lib/kunit/string-stream.c | 3 +- {include => lib}/kunit/string-stream.h | 0 lib/kunit/test.c | 25 ++++++++++++++- lib/kunit/try-catch-impl.h | 27 ++++++++++++++++ lib/kunit/try-catch.c | 37 +++++----------------- lib/list-test.c | 4 ++- 23 files changed, 157 insertions(+), 72 deletions(-) rename lib/kunit/{example-test.c => kunit-example-test.c} (97%) rename lib/kunit/{test-test.c => kunit-test.c} (98%) rename {include => lib}/kunit/string-stream.h (100%) create mode 100644 lib/kunit/try-catch-impl.h -- 1.8.3.1