Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp730806ybl; Wed, 4 Dec 2019 09:57:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxWKpChz8xLFs0yisXQjOK2LYx+SNF51dK6+hmwX8MnqvXq+H0WQd9VkB0zolS+lVYQaur8 X-Received: by 2002:a9d:22a8:: with SMTP id y37mr3345291ota.359.1575482236664; Wed, 04 Dec 2019 09:57:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482236; cv=none; d=google.com; s=arc-20160816; b=RZ8lLNw4hLEUMCn3hmF0ngMo7sArklsZW4i+aaRTjWLSOb4YtMhhefxUXyhqwLiqSQ h9kFj1NLuWm6e4/o/iEsIvrlvTylJAI11WK4Ps8e2wz5pz3+/QBzTvUPNWVMb/BT2oUf W7cZAFUR+21dNZ5ufYUSRnn1cg7kLMuRWMBsaQguqy3gKklsNipoC5Cl4ApfMbqEfBeS tjZy9GYtmtTrVYsQCdklfyylRUU4uDVh7eULCUxl+75YdixxP/Ih2V5VD8yJdP2iAE0S N+rS2jxSJ0DF8hMJhM0gG8BjBglxUHyQqB0WUlFj/Ju8Rmcz0mUVn2MlzzoQoRmZGVoF agcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=/QBiOCr7c4l7fZjKklo3yZ4ZIuYTkAcsgsNgIGBN47E=; b=tfWZgm6/DdL1WeirGFKlGH+iNsBVdY6XWIuwT6qsxj69oL68zJN7D5a0enCUr52ird rvzv+nX7rBsB5B7Z6yzfb7oPcDtbPv7jjHYKKn4qTDqtDKh19nmumLpqC13UPRpc8QEB mJ0aV/2iN1fq1lxRYWn+ssdIWyXzWvUY/37DAaTEgpqc3GPA1pl1Xdpb/zZUNA78+vua qSawopOSpoJlA/jTBC2qTelsfygrlkZlKVA9syrYouDp1c4VUE0+GtCvt2bz/3kfV4AM KtHhf4NNZhIyEY5DgNMz1o9sxKju2bJeQ/DQ++oo7PO5aiPfPys4E3PjJUGBFaWJX9dp WsTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=CmqYRADb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si3395428otk.15.2019.12.04.09.57.02; Wed, 04 Dec 2019 09:57:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=CmqYRADb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbfLDRzo (ORCPT + 99 others); Wed, 4 Dec 2019 12:55:44 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:42013 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbfLDRzo (ORCPT ); Wed, 4 Dec 2019 12:55:44 -0500 Received: by mail-ed1-f68.google.com with SMTP id e10so126143edv.9 for ; Wed, 04 Dec 2019 09:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/QBiOCr7c4l7fZjKklo3yZ4ZIuYTkAcsgsNgIGBN47E=; b=CmqYRADbzr0G4HWvjRmoRSG65lHFiqcXXzx9WbxdkJJtwwFPkv6L6uhvSr8NbL8H00 3ezARPSmbB3svk8QCSrCaesCNvwd3cCxpBYJrVUau6Y/wlyJqh4o0Q61o4n/Vfy08utU rk0ZgwPE6al6bX+5S8CbsYWWOIQm0TFRdeFGOXwPBKse5ivL13zdlezYWKuVzPkN9uth L9C3RaP8eZOybLz1t2XIHf9h1vtWINA35xwdU/D152hAFrl/3hd7BxjnxP8o466XkLlX QUO4JYN8wnAWLeM4QY3xtEPmN3f51q8sFeXANuD1LkDioIr9xfYxmX1myGmWjpW/iUdR 5UIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/QBiOCr7c4l7fZjKklo3yZ4ZIuYTkAcsgsNgIGBN47E=; b=U64Y+1M9hYqHwGdhDnIWgO0eczQw5SWH6x0Wd8fmWyd1py+WvRRF3AXC7yw/uJCVLh i6dtP49MAOx4vALKzvhhKRv9OmmGs8x/fie0je+K0b+kX3UaOYadShvjRXWm9B3B+1oS 6fvpqCN9ueJ8Z+3jG42ULWDf+xwgawPc4AZBOoH/5QogB1QejVaJucw9P34HGQ+Urkfw YPXVXIQ2iPe7bNHjV2BfdSVEOF1lgZyGnt4FKbEwukSn2OEQcQObFVQH2wVVfp9O7ehz CIB4ibXfna7t6wjRZWrXnigeBkvPRHojVLL+Ioo4/2nIh4KLpBVeeodsvmpLbvvCSLdh 2VYw== X-Gm-Message-State: APjAAAXQx+1641QDAinrRDUWrn/5lH8eChRgRpD096WmTQRBFvH/PPCP 86sG34C5BZmWivYSMsbny5TL3USFRslkLYwRJRDXDg== X-Received: by 2002:a50:84ab:: with SMTP id 40mr5637114edq.14.1575482142681; Wed, 04 Dec 2019 09:55:42 -0800 (PST) MIME-Version: 1.0 References: <20191127184453.229321-1-pasha.tatashin@soleen.com> <20191127184453.229321-2-pasha.tatashin@soleen.com> <957930d0-8317-9086-c7a1-8de857f358c2@xen.org> In-Reply-To: From: Pavel Tatashin Date: Wed, 4 Dec 2019 12:55:31 -0500 Message-ID: Subject: Re: [Xen-devel] [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call To: Andrew Cooper Cc: Julien Grall , James Morris , Sasha Levin , LKML , Catalin Marinas , Will Deacon , steve.capper@arm.com, Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Mark Rutland , Thomas Gleixner , Greg Kroah-Hartman , allison@lohutok.net, info@metux.net, alexios.zavras@intel.com, Stefano Stabellini , boris.ostrovsky@oracle.com, jgross@suse.com, Stefan Agner , Masahiro Yamada , xen-devel@lists.xenproject.org, Russell King - ARM Linux admin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2019 at 10:10 AM Andrew Cooper wrote: > > On 29/11/2019 15:05, Julien Grall wrote: > > Hi, > > > > On 27/11/2019 18:44, Pavel Tatashin wrote: > >> diff --git a/arch/arm64/include/asm/xen/hypercall.h > >> b/arch/arm64/include/asm/xen/hypercall.h > >> index 3522cbaed316..1a74fb28607f 100644 > >> --- a/arch/arm64/include/asm/xen/hypercall.h > >> +++ b/arch/arm64/include/asm/xen/hypercall.h > >> @@ -1 +1,29 @@ > >> +#ifndef _ASM_ARM64_XEN_HYPERCALL_H > >> +#define _ASM_ARM64_XEN_HYPERCALL_H > >> #include > >> +#include > >> + > >> +static inline long privcmd_call(unsigned int call, unsigned long a1, > >> + unsigned long a2, unsigned long a3, > >> + unsigned long a4, unsigned long a5) > > > > I realize that privcmd_call is the only hypercall using Software PAN > > at the moment. However, dm_op needs the same as hypercall will be > > issued from userspace as well. > > And dm_op() won't be the only example as we continue in cleaning up the > gaping hole that is privcmd. > > > So I was wondering whether we should create a generic function (e.g. > > do_xen_hypercall() or do_xen_user_hypercall()) to cover the two > > hypercalls? > > Probably a good idea. It sounds good to me, but let's keep it outside of this series. Thank you, Pasha