Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp733037ybl; Wed, 4 Dec 2019 09:59:43 -0800 (PST) X-Google-Smtp-Source: APXvYqwo9C/sRQswmqwdMghcqhzSU/vr0TxndqwbpOJpqAyiRDhBlz3KlX9LuQL5aX/f0uwOW3FX X-Received: by 2002:a9d:4e88:: with SMTP id v8mr3384562otk.354.1575482383070; Wed, 04 Dec 2019 09:59:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482383; cv=none; d=google.com; s=arc-20160816; b=l4siYRYMUCtXQay2I6XuE+STYdzbKUQdbiQge25U+5Dflt7BmIsagzSIrA5qbFJAKa qureQCBP1gHcnfW/+KtFut3CHEATUNwE6DL96p78xKPbV/j8nxVP8Kf5T+HtrRZmiCXy PLiDiYnGVsDEIRRqruHsw+RYD0kRf86y61diXICFPSWAYa4D3L9U/8ApAPspAu6sEBjH mLOcACplHyvClF8DnaOsWINBCO90jPzpCKWZE6ZLEyy/vMsxv0rnwKCARxYpT8Gtunxf FabifUh+JvcYR9MxqT/571OX113YkUYLyyPYeDBw9VlblF/qztg736BM2Sw/9o4UWBYJ 2IIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=e9gkQnU+5q50cQeHx8NRu5HJQyIM32Z6cVBwYXSVjIU=; b=Xyu/BVPcLDK9w2EggLReMvRf0XuUhRH+Ooh4CnVnY+pauH7ZK7pCkP2ydbv0jjs+4k CrK62m8tTkuSMV+H7GCkGAK8MTNQ168UWlPEynYYLWpaKbP4t9b5JJi7h+ywU6MtmAUz NDCYXZxIUqjC3JMRrCvtCaCZKpx7VnQ5wGHybvTdzrwcRJXr9CLy1EKv3+H1ThlEibO3 xGHHqvlCXsDmIC0hQMVtOLH9N9wsLx38BXLKmh+E2A9B4Wveen/J/Jq2JTu9BEQTEEI/ 5PKMo+ZobSu/2LjzERhWYCVXCpjvmEEVfnCtqfCVKqesAsVj+fBZa8X2Dq0wuzvrbPmS VkyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=TfH3rUb9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e74si3487043ote.14.2019.12.04.09.59.30; Wed, 04 Dec 2019 09:59:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@soleen.com header.s=google header.b=TfH3rUb9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbfLDR6f (ORCPT + 99 others); Wed, 4 Dec 2019 12:58:35 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:42458 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728777AbfLDR6d (ORCPT ); Wed, 4 Dec 2019 12:58:33 -0500 Received: by mail-ed1-f67.google.com with SMTP id e10so133700edv.9 for ; Wed, 04 Dec 2019 09:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e9gkQnU+5q50cQeHx8NRu5HJQyIM32Z6cVBwYXSVjIU=; b=TfH3rUb9CyqcTteFkO3C0xlnbKPaPL+cKMDbTylgoIZRtg9/X9I+YsgFYMbiZXeyWH 6PlZPH1K/5P+XHiHenDCQt4FvrDjS/BrRzDZryGe9Twd6Hm2D/PuFfB0RuI7ndN7FRkU 53yRO+n+zxjDbzNLl19rt+Ux9N0QapQxf/PcuW0FZFx9aDV2esnmpEXuzPCGcvshVi5c mRfJ/YtyltCIrh/P45bL1k1m4RChqhZSyzX/Jcbu3guo/ePbUMweg/D/uJvHeIaqg4Gm 5uP20oOpH/SKLR8di/NnPJ5v5R0wamwgPJl5jM6Ru4CREPcSt4DIS2z6vz82RA/SVf34 r3SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e9gkQnU+5q50cQeHx8NRu5HJQyIM32Z6cVBwYXSVjIU=; b=XyvwXrjf72jb4JmpIHp7JlpNI/+G3lX5laQL38iNo2bQiKjonnnGn2KNln+0Z62ldo hxAyU8KTdgdX4WEFqVUCnV0t5cdxWmyR/Awf/LXRjx6ZER6LmHwnvWpFNOaOvWa8a83d cGT5XsikV545qO5QQuaQN2TOqiZd5w5scV2b8qXBfY2HVPMnHvk+KwqO1soVHRkItf0F K3DLt42GbjtBXdK/UckY+Bg3o2LPzoz9XetPScQ4cMY5UTGl7jleiEWYO97w0BI9s8Zh z1+5CUZCYmgif9eB82hNyAZbXTX4MG8cZTbMqnK069qDo17meauoaZSubKsniTnbcoHB 3V/A== X-Gm-Message-State: APjAAAVEaUJc38ZKe4xP0Ofs6vf5X5rRLFZ9SIldrV0nwEH0tWv2Yh7J fgW8fAb7AeG8BufuWROIiCr9pr92GJxM+brOaZDnyw== X-Received: by 2002:aa7:d445:: with SMTP id q5mr5540834edr.16.1575482311052; Wed, 04 Dec 2019 09:58:31 -0800 (PST) MIME-Version: 1.0 References: <20191127184453.229321-1-pasha.tatashin@soleen.com> <20191127184453.229321-2-pasha.tatashin@soleen.com> <957930d0-8317-9086-c7a1-8de857f358c2@xen.org> In-Reply-To: <957930d0-8317-9086-c7a1-8de857f358c2@xen.org> From: Pavel Tatashin Date: Wed, 4 Dec 2019 12:58:20 -0500 Message-ID: Subject: Re: [PATCH 1/3] arm/arm64/xen: use C inlines for privcmd_call To: Julien Grall Cc: James Morris , Sasha Levin , LKML , Catalin Marinas , Will Deacon , steve.capper@arm.com, Linux ARM , Marc Zyngier , James Morse , Vladimir Murzin , Mark Rutland , Thomas Gleixner , Greg Kroah-Hartman , allison@lohutok.net, info@metux.net, alexios.zavras@intel.com, Stefano Stabellini , boris.ostrovsky@oracle.com, jgross@suse.com, Stefan Agner , Masahiro Yamada , xen-devel@lists.xenproject.org, Russell King - ARM Linux admin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 29, 2019 at 10:05 AM Julien Grall wrote: > > Hi, > > On 27/11/2019 18:44, Pavel Tatashin wrote: > > diff --git a/arch/arm64/include/asm/xen/hypercall.h b/arch/arm64/include/asm/xen/hypercall.h > > index 3522cbaed316..1a74fb28607f 100644 > > --- a/arch/arm64/include/asm/xen/hypercall.h > > +++ b/arch/arm64/include/asm/xen/hypercall.h > > @@ -1 +1,29 @@ > > +#ifndef _ASM_ARM64_XEN_HYPERCALL_H > > +#define _ASM_ARM64_XEN_HYPERCALL_H > > #include > > +#include > > + > > +static inline long privcmd_call(unsigned int call, unsigned long a1, > > + unsigned long a2, unsigned long a3, > > + unsigned long a4, unsigned long a5) > > I realize that privcmd_call is the only hypercall using Software PAN at > the moment. However, dm_op needs the same as hypercall will be issued > from userspace as well. The clean-up I am working on now is specific to moving current PAN useage to C wraps. Once dm_op requires to use PAN it will need to be used the C variants, because ASM versions are going to be removed by this series. > > So I was wondering whether we should create a generic function (e.g. > do_xen_hypercall() or do_xen_user_hypercall()) to cover the two hypercalls? > > > diff --git a/include/xen/arm/hypercall.h b/include/xen/arm/hypercall.h > > index b40485e54d80..624c8ad7e42a 100644 > > --- a/include/xen/arm/hypercall.h > > +++ b/include/xen/arm/hypercall.h > > @@ -30,8 +30,8 @@ > > * IN THE SOFTWARE. > > */ > > > > -#ifndef _ASM_ARM_XEN_HYPERCALL_H > > -#define _ASM_ARM_XEN_HYPERCALL_H > > +#ifndef _ARM_XEN_HYPERCALL_H > > +#define _ARM_XEN_HYPERCALL_H > > This change feels a bit out of context. Could you split it in a separate > patch? Makes sense, I am splitting this into a separate patch. Thank you, Pasha