Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp736244ybl; Wed, 4 Dec 2019 10:02:05 -0800 (PST) X-Google-Smtp-Source: APXvYqx4vHvrrwflcMKEcwlvwkGXg0PgySEjv8+dSTt8ICRIqydnk/KkepJnEZ1OOJGdD+U61Z17 X-Received: by 2002:a9d:7dc9:: with SMTP id k9mr3541388otn.117.1575482525524; Wed, 04 Dec 2019 10:02:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482525; cv=none; d=google.com; s=arc-20160816; b=GCKdOte2kz254XDokhc/MNlGMB+UlLnTpy6Pzs1QgZ0YFS/MXqH5iK0MGSUl1KVhv4 0HibnLyLO0Hr423+bF3mUHK5Ejt38NVsEFvoy1iz/Gop93EfCbFBterfjWFuqCc3QCz0 05Q/Y6QyZ3U1iRaebo+RhNMH/wlmcH9XD0L+er8oGe2/NQ9h6Lpb9LTnIUjOW3hkQk6H 9Cwmxu34VRKxe7nWXgxZoPTRRrK82KtV9RuDJvXm2YmgZ032opIZON+XRjCqsD4sP0rf lTM1PDK7+xNnAe9mxFh8RvtcNVB8FuEHNES7y3whPQmed+ksJbSG+xyhnrCFWCHzKMbd dA1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e1BP4xciShVUoWIH/U76jiOGFgyEgGdhYY3za2TLRQs=; b=lWwHqjt0bawpkYE8BxDemHdgUzSI0yjLyQ1zAY9WVGhTMCKuHRIqYBcio4a/Ok8uHQ 5ozicE92v9R3bEkf8Bh3182wipSML5p7Iogvop39Rhy+VPG7BD6R6n4RA52uluYbXQLK 4PgGdiI0M9wrEIWXrQJk9jbCvWreMWRfDDGzEHYcGpBFYQebVK/g3ONGt94nwb3Bz91n 5FYnZkN7MJ1v/bs2bCywnnHtkNuwwiEb9EeALhrPxxZ9rbvtkxC6Kmq1qiAhyiW0GKpT Udz4G1ewPTDbNv9dNlCpQOXidKrAe9qT6Py/g/ksseL4D+ESX2T/PxGssSjiup0/FGPk qQ4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MVt1S2lI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l19si3432113oib.48.2019.12.04.10.01.52; Wed, 04 Dec 2019 10:02:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MVt1S2lI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729406AbfLDSAj (ORCPT + 99 others); Wed, 4 Dec 2019 13:00:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:39452 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729390AbfLDSAg (ORCPT ); Wed, 4 Dec 2019 13:00:36 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EE5220863; Wed, 4 Dec 2019 18:00:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482435; bh=IP5ew8cinng8wN83PXrqL1p/+8xz9WNlKNL1skXB5BE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVt1S2lIoXOWpDQ9MKZYk66VyAFyIcPI8X3yysyhxeQBtFERJJ4me3fxzm873yJlV 1g3ov9pbWoESusIsWbrbJevsHjvNwOOodT2djIybIfFLONie1DT0hCnxhUBazIA+MM c6dj9MsKP6qpQthKsk25b9N3CSgEBxQX59J1hSYc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kyle Roeschley , Kalle Valo , Sasha Levin Subject: [PATCH 4.4 46/92] ath6kl: Only use match sets when firmware supports it Date: Wed, 4 Dec 2019 18:49:46 +0100 Message-Id: <20191204174333.263226729@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204174327.215426506@linuxfoundation.org> References: <20191204174327.215426506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kyle Roeschley [ Upstream commit fb376a495fbdb886f38cfaf5a3805401b9e46f13 ] Commit dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") merged the probed and matched SSID lists before sending them to the firmware. In the process, it assumed match set support is always available in ath6kl_set_probed_ssids, which breaks scans for hidden SSIDs. Now, check that the firmware supports matching SSIDs in scheduled scans before setting MATCH_SSID_FLAG. Fixes: dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") Signed-off-by: Kyle Roeschley Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c index 81ac8c59f0ecd..2b79815f59093 100644 --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c @@ -932,7 +932,7 @@ static int ath6kl_set_probed_ssids(struct ath6kl *ar, else ssid_list[i].flag = ANY_SSID_FLAG; - if (n_match_ssid == 0) + if (ar->wiphy->max_match_sets != 0 && n_match_ssid == 0) ssid_list[i].flag |= MATCH_SSID_FLAG; } -- 2.20.1