Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp745666ybl; Wed, 4 Dec 2019 10:09:54 -0800 (PST) X-Google-Smtp-Source: APXvYqz0D9Szhde/bkS1JJRQKMB2X156ADw6AXy7oodlIg9AOsP4+FR56BVGVcxyCUvwAK5zi46N X-Received: by 2002:aca:758c:: with SMTP id q134mr3843090oic.33.1575482993903; Wed, 04 Dec 2019 10:09:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575482993; cv=none; d=google.com; s=arc-20160816; b=xRvT5JRLW5vmmi1fIwPB1MAUCtTwZaR7l0N0C1ae2cv8ZzjoXEaFqmsFL2u3NW5493 OMITml2K9Or34aFMfUnM3ax+S0id3SbRORDc2DxJGRzPBhJWbTTyge6tKbkh1pJxY8Om lLEbadrivHzDUNE/D0+gWUg88+I4AjguF0vRD3ioXaAoO6iL1YESxSumN7LpM0CqMRU8 Z3/J2H2AC4uCCVPcbV4Y9RNOyLpJNXn9rEmW4EZLGS3q6F5rJ+sXbncuzJXjLZOThcS2 zYWj2kzdxytf1mKIyOXkiremEFuoMVQ/eWT8gmfwDmthJ/Ih3zcG7do43Fr4/AH+QftB RG0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uVUXdy2SDz0jfMceyRovnaX1UOnvxsaL3s7BHj2kav4=; b=dDSLLqeSHeaIPGddLnD+OZKkzh69n3e6EEOh52S+jurz/bMey9yQ/Cy8duHaROIVL9 W2XP8/vorjqxfcjgulHGjRUpN2nOpQjIIm9kL2uiqtMUSdahDteo3rU/SJyF2KLQDV+G dnY7+cY4nQRyFXJr6zA/kiGtgkraaf96gOxupMKPmZDRK75JSP4sx6NFiv/wCAj4/c28 N/dlSZclHP6gfcLuJmN8E6uCOYtfYcrHjUiLylnw97SXuTCTXZj2+MqdSntsRBaavuZE 38/OVu3hQoLrFmA4vdANm3s9+dtuJN+iGALfYSd5gCNQzillJ6f6I5Hx4bzcqhFKdsrA oxbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iFsB0G0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e31si223667otb.157.2019.12.04.10.09.39; Wed, 04 Dec 2019 10:09:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iFsB0G0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730252AbfLDSI3 (ORCPT + 99 others); Wed, 4 Dec 2019 13:08:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:60010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730347AbfLDSIV (ORCPT ); Wed, 4 Dec 2019 13:08:21 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6265B20674; Wed, 4 Dec 2019 18:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575482900; bh=n+Wons8GrY+1VzeMZgkyPKXji48Eh6cjTU8tvUR/bUM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iFsB0G0ABE8UEbWk+H0qeS0zgaFMc88tHYbVvOj/1k4BtGiHOonCz7g69cmzgwSk/ irx3ZxIq6Izo/+CWAVJd/kRrVh48EJKT+8X276GVOnsj1NRcnfjA2ILguBS8m5nT23 OXDy/nCtaAoOIbHYMEGsxuITJWw94jDnyBTo1Taw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 143/209] net: dev: Use unsigned integer as an argument to left-shift Date: Wed, 4 Dec 2019 18:55:55 +0100 Message-Id: <20191204175333.161893781@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175321.609072813@linuxfoundation.org> References: <20191204175321.609072813@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andy Shevchenko [ Upstream commit f4d7b3e23d259c44f1f1c39645450680fcd935d6 ] 1 << 31 is Undefined Behaviour according to the C standard. Use U type modifier to avoid theoretical overflow. Signed-off-by: Andy Shevchenko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 40b830d55fe50..4725a9d9597fc 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3522,7 +3522,7 @@ static inline u32 netif_msg_init(int debug_value, int default_msg_enable_bits) if (debug_value == 0) /* no output */ return 0; /* set low N bits */ - return (1 << debug_value) - 1; + return (1U << debug_value) - 1; } static inline void __netif_tx_lock(struct netdev_queue *txq, int cpu) -- 2.20.1