Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp749696ybl; Wed, 4 Dec 2019 10:13:27 -0800 (PST) X-Google-Smtp-Source: APXvYqx6/ZB6m212OrWBQ2k/GPAsbncT69QvZ0X42/a7TR0npzIviILuV1kuPlZdceTkhg7q3eFX X-Received: by 2002:aca:aad8:: with SMTP id t207mr3589525oie.138.1575483207747; Wed, 04 Dec 2019 10:13:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483207; cv=none; d=google.com; s=arc-20160816; b=G/hsS97zxWeyn4fvsRCGl6hCSOY2NmXewahkXPl8C26XmWFSRQvvVXOLxMUPbD+nA/ DS8IKd0j9fUTbN03PhBXHksnEhM4hA5geqiVoBL6n8qLENKx10gqjtgVzvHS9N5VHIyE fi1nKIlwjRmU/iekgiOXacip6QO+rc9fQ3COlbgqxPFbkX3VcYn2N6Kbak8YXsINDp+1 MKAU9dFcPfM9lyxjMwk7+KbtkwSTSNcWzq8u28ICh86fB2uNY1+q6zA8ceEZUzyIaI69 Dc/JZxm/ayGy4WcpwSJZbNpte/nLT3RX1WWZTQeEhLTllTE2rSHAMVGMSW1zbxfv0bkg bxEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8SB/+UAEVjDdRZdXLLprkB5Lhq7/AnEQwPAzLOKtP2o=; b=hP+GLN8xyMKTBKRspz7PPezWmDXOEOc4qf+daR37GeIAlqf2YmUJT9JqH/3GSBXODf Z/2yYDagnJGyDHl5dDLWiZGfQsW+QTMsEPr3PetTn6IhY201NP/NmLrDu+eUFStk27Ui MyQuwgRBObCTtkJneFSe8jiBdcOljn3kjJRpbhIsGzARn0NEqVlJCi99keTljdXQ4vJL Yoz+uVfJAvEsvMvKrJxz14WvB5NBAkMACICVweyO7zsRNmDO10N1xVgjQ45Is1qTr9z4 Wfs/QqAkiL9wj5OblN1H3Mv1/6DK6iskQO+hodXNbfeVdK/QNcsoM6Hta8nd9AsoaRpU f74A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gcCNNOgs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si3761262otr.45.2019.12.04.10.13.06; Wed, 04 Dec 2019 10:13:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gcCNNOgs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731526AbfLDSL6 (ORCPT + 99 others); Wed, 4 Dec 2019 13:11:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:40386 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731535AbfLDSL4 (ORCPT ); Wed, 4 Dec 2019 13:11:56 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 862CD20675; Wed, 4 Dec 2019 18:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483116; bh=u+OorGplPoo4KPqhEBpJTPq5149qy2NJwf/txWg4fFg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gcCNNOgsncrEyVsLy3QI5E4FWk5qQRPpE2hSr7dnFcH1ZyCdouIzhXe25UmRmYYT8 JYNTkTHPooMM7nYit1a5xCU2ut+GkH6bZEma2jI5MLfXbbSIm3ad/2wunAxf9edp2R GWEKagFSve5Qp5gjRAlE5IP/pkrknm+ncoLD9VH8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kyle Roeschley , Kalle Valo , Sasha Levin Subject: [PATCH 4.9 058/125] ath6kl: Only use match sets when firmware supports it Date: Wed, 4 Dec 2019 18:56:03 +0100 Message-Id: <20191204175322.495760838@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kyle Roeschley [ Upstream commit fb376a495fbdb886f38cfaf5a3805401b9e46f13 ] Commit dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") merged the probed and matched SSID lists before sending them to the firmware. In the process, it assumed match set support is always available in ath6kl_set_probed_ssids, which breaks scans for hidden SSIDs. Now, check that the firmware supports matching SSIDs in scheduled scans before setting MATCH_SSID_FLAG. Fixes: dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") Signed-off-by: Kyle Roeschley Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c index b7fe0af4cb240..0cce5a2bca161 100644 --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c @@ -934,7 +934,7 @@ static int ath6kl_set_probed_ssids(struct ath6kl *ar, else ssid_list[i].flag = ANY_SSID_FLAG; - if (n_match_ssid == 0) + if (ar->wiphy->max_match_sets != 0 && n_match_ssid == 0) ssid_list[i].flag |= MATCH_SSID_FLAG; } -- 2.20.1