Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp750319ybl; Wed, 4 Dec 2019 10:14:02 -0800 (PST) X-Google-Smtp-Source: APXvYqwbOr9svracaAdav80KJQji5+EKIdZtTAhQJdketj81doev+RvH2r5RqQtslBDQD3gmI7jK X-Received: by 2002:aca:f484:: with SMTP id s126mr3594239oih.48.1575483242170; Wed, 04 Dec 2019 10:14:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483242; cv=none; d=google.com; s=arc-20160816; b=C4Mv4K2PeQa3a0I1ZZG8jHIKM9UFJ63E/j8zJbTn1MyMRmQxnn2zqGyR5I/QBn39dD E6ZsHh0Ubnb9KPuayKEPDpE9FjAWDkyPAUtf2RNurMIIvVx5p7vK29IPTL12TQ8952EU Am9myQiQzaQ9XnH0L490ZvCKTeAC9ukiub5KQFRtKeIOl88AbqFDEBVpaB/AcDQk/unE tfmQwyVeAMX23ulm9c18VRF6rwfkcf0An1Rq7ikzHkdzw/R02ISNL/2zGSFiPwelRmJD xBJCycyixaebUc5379XvQZJfJNUpswEKJmNIRdDI2ZttSp0PldMF0Am/F+wrBvGrsfV8 DG0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IS6p3FH/hB6r2D6c13EQoR6AcE/ZoCWnkuipNpiEM3Q=; b=b7hLCUeaK9x6iFDJF5UtPT600NM50vKwVRT4t8yUUoFJ0I6vmJBfl8oFk6g5rtMhZS JyM9XaTH64LudNaAM6++bIgsg8LuQOKEI7Nl+hynpZTt1R/zBpnaOCxnNQA33jlUVtZa +wVHYnMvJM57SQsLUFL1+SVBfV/Pzm8FEgrJN3+gHDLpT+gbg+r2tf7p5UpSmMekI3/p 2hMbj+FBopWA5TDTULvVlsLO1UcAdfV8waWP2oSfbHGzoz369TXUQRsWekKPVEEklZWI zUOecFtfr2Du86Exf5pw7sEkfJAIiVxzEt5xqD+8j4svefFFL7ykpvQYNIm7iYpGm+3M oQyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xixNRhSp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z21si3942728oti.25.2019.12.04.10.13.50; Wed, 04 Dec 2019 10:14:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xixNRhSp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730935AbfLDSMO (ORCPT + 99 others); Wed, 4 Dec 2019 13:12:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:40744 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731566AbfLDSMK (ORCPT ); Wed, 4 Dec 2019 13:12:10 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D38F1214AF; Wed, 4 Dec 2019 18:12:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483130; bh=72si8NNBzDHWEy6P8LB/sxnbv3JGkev8Astuf7ElLT0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xixNRhSpQEyVu6Tp6ZGGa7Jg4ZQC7XiAn1QvfmjkETTai5El1xuGCbtGCMqTRLVoU q33IwUR6qVRDgg2uG2M0qinMOM8hEjz5wtTmfifskjWSCdC5ysttv617fTh0vsEihu 0tqm1SzFoatU3jtIFu4W8sf1O20ONS2joy/M8SVU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Benjamin Tissoires , Jiri Kosina , Sasha Levin Subject: [PATCH 4.9 037/125] HID: intel-ish-hid: fixes incorrect error handling Date: Wed, 4 Dec 2019 18:55:42 +0100 Message-Id: <20191204175321.235489390@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 6e0856d317440a950b17c00a9283114f025e5699 ] The memory chunk allocated by hid_allocate_device() should be released by hid_destroy_device(), not kfree(). Fixes: 0b28cb4bcb1("HID: intel-ish-hid: ISH HID client driver") Signed-off-by: Pan Bian Reviewed-by: Benjamin Tissoires Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c index 277983aa1d90a..d0b902285fc3a 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid.c @@ -222,7 +222,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev, err_hid_device: kfree(hid_data); err_hid_data: - kfree(hid); + hid_destroy_device(hid); return rv; } -- 2.20.1