Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp752646ybl; Wed, 4 Dec 2019 10:16:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyZ68uCT+S/8t9D6e4XOAPu2kLlggVkDnRmkA17eLqmRlvx3c56OYdzZ7NqObEEYwFNSNXN X-Received: by 2002:aca:f495:: with SMTP id s143mr3655048oih.118.1575483367706; Wed, 04 Dec 2019 10:16:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575483367; cv=none; d=google.com; s=arc-20160816; b=c3I0SoBb0wON6gXqWXSssLWVizQb19HBCDNjEhbbAuybCf2GG5tiUuXorMtw3GBOC3 wDLyYVpMwwInUjODwjYoiEMdFJ2nb72WkZmoYxXmkOc0fiZExPgeg17OxG5U9fUrzog0 buN9nZFuUD8G3oX5wEYqXwZf3k53twn5180Xti9Rj1Acp1UX1CAt2e0t7K+dK4RQJlZY 2whFnOjZY2XoDbfg1gRlcV+6mDkfOTIc0lGL+ATJRn/t+JuAwUXFUYhfeZRRng+gIC7l 0WjMLkZKZ7sz9QmVBI3Dq8M7/r8rtBJWMmQjru8FowhCR4jQQqqxbazLmHJxSmQS4lmy hcdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w2p0FHT9ofEAntJ+D1Egb4SIXLWlhSXAfr8ZXTAUaIk=; b=gD0r4N40XiPfZpXYhkx/St9z1IuA+qGkxVLcQ1XwJg9hKEo/wKs5Wd4rE5Gsvykmwm 0IL9//xtOOAAD1WZaIXMDL+8VkGjg3hpLEtUO62MLU/66IKPFSNPnb/w4izGZN0T4Bb2 vtTKurQ1O3tA9KZ5+vDSXCyrZblZ1AKVsAOLBaWf7RaUxDi22rdyXi/CcXSZqT+Su7QH 2ybh1y1AvjiWmDbSsfPVKuzd2kJz8Taa+9RJJ5i52xPmiDLw1e1Ed40iShBvo4xpniUV MyaVQsJB+Z+5q861GvZp0s8f1SPYF5yGlCjcYIv0Gu4f6+mN8rAZ247CPtJI9wXTJ0kA E89A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xX0HIrKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1si3550592otk.80.2019.12.04.10.15.54; Wed, 04 Dec 2019 10:16:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xX0HIrKe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731953AbfLDSOo (ORCPT + 99 others); Wed, 4 Dec 2019 13:14:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:44018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731937AbfLDSOi (ORCPT ); Wed, 4 Dec 2019 13:14:38 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 274AD206DF; Wed, 4 Dec 2019 18:14:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575483277; bh=O4H8gKKIofBTYa/ahR2HGrSqNn62ReqrOkWXmkecmG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xX0HIrKePm037n4YDctYkyFxHL0Wvh1eytcgLSzILWOGADtV9Tswbli/M400/Dcnq Wn8cszbxd39tXDm3iOVjmh/LB1PBjZDmzZUGXEdgokt49P7oeHTAw83Q4KqCSRS8TC 04G8KcuwQSze5nEScCGoWyPlveCgqSdwq6whWMuc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lionel Debieve , Herbert Xu , Mathieu Poirier Subject: [PATCH 4.9 123/125] hwrng: stm32 - fix unbalanced pm_runtime_enable Date: Wed, 4 Dec 2019 18:57:08 +0100 Message-Id: <20191204175326.886744435@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191204175308.377746305@linuxfoundation.org> References: <20191204175308.377746305@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lionel Debieve commit af0d4442dd6813de6e77309063beb064fa8e89ae upstream. No remove function implemented yet in the driver. Without remove function, the pm_runtime implementation complains when removing and probing again the driver. Signed-off-by: Lionel Debieve Signed-off-by: Herbert Xu Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/char/hw_random/stm32-rng.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/char/hw_random/stm32-rng.c +++ b/drivers/char/hw_random/stm32-rng.c @@ -166,6 +166,13 @@ static int stm32_rng_probe(struct platfo return devm_hwrng_register(dev, &priv->rng); } +static int stm32_rng_remove(struct platform_device *ofdev) +{ + pm_runtime_disable(&ofdev->dev); + + return 0; +} + #ifdef CONFIG_PM static int stm32_rng_runtime_suspend(struct device *dev) { @@ -202,6 +209,7 @@ static struct platform_driver stm32_rng_ .of_match_table = stm32_rng_match, }, .probe = stm32_rng_probe, + .remove = stm32_rng_remove, }; module_platform_driver(stm32_rng_driver);